[MIG] hr_timesheet_begin_end: Migration to 17.0

Author: NICO-SOLUTIONS

hr_timesheet_begin_end/README.rst

@@ -68,6 +68,7 @@ Contributors
    -  Andrea Stirpe
 
 -  Sunanda Chhatbar <sunanda.chhatbar@initos.com>
+-  Nils Coenen <nils.coenen@nico-solutions.de>
 
 Maintainers
 -----------

hr_timesheet_begin_end/__manifest__.py

@@ -4,7 +4,7 @@
 
 {
     "name": "Timesheet - Begin/End Hours",
-    "version": "16.0.1.0.0",
+    "version": "17.0.1.0.0",
     "author": "Camptocamp, Tecnativa, Odoo Community Association (OCA)",
     "license": "AGPL-3",
     "category": "Human Resources",

hr_timesheet_begin_end/models/account_analytic_line.py

@@ -64,12 +64,13 @@ def _check_time_start_stop(self):
                 message = _("Lines can't overlap:\n")
                 message += "\n".join(
                     [
-                        "%s - %s"
-                        % (
+                        "{} - {}".format(
                             value_to_html(other.time_start, None),
                             value_to_html(other.time_stop, None),
                         )
-                        for other in (line + others).sorted(lambda l: l.time_start)
+                        for other in (line + others).sorted(
+                            key=lambda item: item.time_start
+                        )
                     ]
                 )
                 raise exceptions.ValidationError(message)
@@ -84,7 +85,7 @@ def onchange_hours_start_stop(self):
 
     def merge_timesheets(self):  # pragma: no cover
         """This method is needed in case hr_timesheet_sheet is installed"""
-        lines = self.filtered(lambda l: not l.time_start and not l.time_stop)
+        lines = self.filtered(lambda line: not line.time_start and not line.time_stop)
         if lines:
             return super(AccountAnalyticLine, lines).merge_timesheets()
         return self[0]

hr_timesheet_begin_end/readme/CONTRIBUTORS.md

@@ -5,3 +5,4 @@
 - [Onestein](https://www.onestein.eu):
   - Andrea Stirpe
 - Sunanda Chhatbar \<<sunanda.chhatbar@initos.com>\>
+- Nils Coenen \<<nils.coenen@nico-solutions.de>\>

hr_timesheet_begin_end/static/description/index.html

@@ -414,6 +414,7 @@ <h2><a class="toc-backref" href="#toc-entry-4">Contributors</a></h2>
 </ul>
 </li>
 <li>Sunanda Chhatbar &lt;<a class="reference external" href="mailto:sunanda.chhatbar&#64;initos.com">sunanda.chhatbar&#64;initos.com</a>&gt;</li>
+<li>Nils Coenen &lt;<a class="reference external" href="mailto:nils.coenen&#64;nico-solutions.de">nils.coenen&#64;nico-solutions.de</a>&gt;</li>
 </ul>
 </div>
 <div class="section" id="maintainers">

hr_timesheet_begin_end/tests/test_timesheet_begin_end.py

@@ -6,19 +6,20 @@
 
 
 class TestBeginEnd(common.TransactionCase):
-    def setUp(self):
-        super(TestBeginEnd, self).setUp()
-        self.timesheet_line_model = self.env["account.analytic.line"]
-        self.analytic = self.env.ref("analytic.analytic_administratif")
-        self.user = self.env.ref("base.user_root")
-        self.base_line = {
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls.timesheet_line_model = cls.env["account.analytic.line"]
+        cls.analytic = cls.env.ref("analytic.analytic_administratif")
+        cls.user = cls.env.ref("base.user_root")
+        cls.base_line = {
             "name": "test",
             "date": fields.Date.today(),
             "time_start": 10.0,
             "time_stop": 12.0,
-            "user_id": self.user.id,
+            "user_id": cls.user.id,
             "unit_amount": 2.0,
-            "account_id": self.analytic.id,
+            "account_id": cls.analytic.id,
             "amount": -60.0,
         }