[FIX] hr_timesheet_purchase_order: fix minor bugs

Change field label
Add validation for the setting product and add test for him
Add groups to the view

Author: dessanhemrayev

hr_timesheet_purchase_order/data/ir_actions_server.xml

@@ -8,6 +8,10 @@
         <field name="name">Create Purchase Order</field>
         <field name="model_id" ref="model_hr_timesheet_sheet" />
         <field name="binding_model_id" ref="model_hr_timesheet_sheet" />
+        <field
+            name="groups_id"
+            eval="[(6, 0, [ref('hr_timesheet.group_timesheet_manager')])]"
+        />
         <field name="binding_view_types">list</field>
         <field name="state">code</field>
         <field name="code">

hr_timesheet_purchase_order/models/hr_timesheet_sheet.py

@@ -13,6 +13,22 @@ class HrTimesheetSheet(models.Model):
         related="employee_id.allow_generate_purchase_order"
     )
 
+    def action_timesheet_confirm(self):
+        """Confirm valid timesheets
+
+        Raises:
+            UserError:  You need to set a timesheet billing product
+                        in settings in order to create a PO
+        """
+        if not self.company_id.timesheet_product_id:
+            raise UserError(
+                _(
+                    "You need to set a timesheet billing product"
+                    "in settings in order to create a PO"
+                )
+            )
+        super().action_timesheet_confirm()
+
     def action_create_purchase_order(self):
         """
         Create Purchase Order

hr_timesheet_purchase_order/models/res_partner.py

@@ -11,7 +11,9 @@
 class ResPartner(models.Model):
     _inherit = "res.partner"
 
-    is_auto_po_generate = fields.Boolean(string="Automatic PO generation")
+    is_auto_po_generate = fields.Boolean(
+        string="Automatic PO generation from timesheet sheets"
+    )
     recurrence_id = fields.Many2one("hr.timesheet.recurrence", copy=False)
     employee_ids = fields.One2many(
         comodel_name="hr.employee",

hr_timesheet_purchase_order/tests/__init__.py

@@ -1,2 +1,3 @@
+from . import test_create_timesheet_po_recurrence_not_product
 from . import test_create_timesheet_purchase_order
 from . import test_create_timesheet_po_recurrence

hr_timesheet_purchase_order/tests/test_create_timesheet_po_recurrence_not_product.py

@@ -0,0 +1,61 @@
+# Copyright (C) 2024 Cetmix OÜ
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from datetime import date
+
+from freezegun import freeze_time
+
+from odoo.exceptions import UserError
+from odoo.tests.common import Form
+
+from .common_po_recurrence import TestTimesheetPOrecurrenceCommon
+
+
+class TestTimesheetPORecurrenceNotProduct(TestTimesheetPOrecurrenceCommon):
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))
+
+        config_obj = cls.env["res.config.settings"]
+        config = config_obj.create({"timesheet_product_id": False})
+        config.execute()
+
+    def test_recurrence_cron_repeat_until(self):
+        with freeze_time("2020-01-01"):
+            form = Form(self.outsourcing_company)
+            form.is_auto_po_generate = True
+            form.repeat_interval = 1
+            form.repeat_unit = "month"
+            form.repeat_type = "until"
+            form.repeat_until = date(2020, 2, 20)
+            form.repeat_on_month = "date"
+            form.repeat_day = "15"
+
+            form.property_supplier_payment_term_id = self.account_payment_term_30days
+            form.property_payment_method_id = self.account_payment_method_manual_out
+            form.receipt_reminder_email = True
+            form.reminder_date_before_receipt = 3
+
+            form.save()
+
+            sheet_form = Form(self.hr_timesheet_sheet_obj.with_user(self.user_1))
+            with sheet_form.timesheet_ids.new() as timesheet:
+                timesheet.name = "test until month"
+                timesheet.project_id = self.project
+                timesheet.unit_amount = 1.0
+            sheet_1 = sheet_form.save()
+            self.assertFalse(sheet_1.purchase_order_id, msg="Must be equal False")
+
+            # cannot create purchase order (sheet not approved)
+            with self.assertRaises(UserError):
+                sheet_1.action_create_purchase_order()
+
+            with self.assertRaises(
+                UserError,
+                msg=(
+                    "You need to set a timesheet billing product"
+                    "in settings in order to create a PO"
+                ),
+            ):
+                sheet_1.action_timesheet_confirm()

hr_timesheet_purchase_order/views/hr_timesheet_sheet_view.xml

@@ -23,6 +23,7 @@
                             ('state', '!=', 'done'),
                         ],
                     }"
+                    groups="hr_timesheet.group_timesheet_manager"
                 />
                 <button
                     name="action_open_purchase_order"