[18.0][MIG] base_tier_validation_forward: Migration to 18.0

Author: absal-smile

base_tier_validation_forward/models/tier_review.py

@@ -50,4 +50,4 @@ def _compute_definition_data(self):
             rec.reviewer_id = rec.definition_id.reviewer_id
             rec.reviewer_group_id = rec.definition_id.reviewer_group_id
             rec.has_comment = rec.definition_id.has_comment
-            rec.approve_sequence = rec.definition_id.approve_sequence
+            rec.approve_sequence = rec.definition_id.approve_sequence

base_tier_validation_forward/models/tier_validation.py

@@ -91,4 +91,4 @@ def _notify_forwarded_reviews_body(self):
             return _("A review was forwarded from %(user_name)s %(comment)s") % (
                 {"user_name": self.env.user.name, "comment": comment}
             )
-        return _("A review was forwarded by %s.") % (self.env.user.name)
+        return _("A review was forwarded by %s.") % (self.env.user.name)

base_tier_validation_forward/templates/tier_validation_templates.xml

@@ -4,7 +4,6 @@
         inherit_id="base_tier_validation.tier_validation_label"
     >
         <xpath expr="//button[@name='reject_tier']" position="after">
-            <field name="can_forward" invisible="1" />
             <button
                 name="forward_tier"
                 string="Forward"

base_tier_validation_forward/tests/test_tier_validation.py

@@ -4,17 +4,16 @@
 from odoo_test_helper import FakeModelLoader
 
 from odoo.tests import Form
-from odoo.tests.common import TransactionCase, tagged
+from odoo.tests.common import tagged
 
-from odoo.addons.base.tests.common import DISABLED_MAIL_CONTEXT
+from odoo.addons.base.tests.common import BaseCommon
 
 
 @tagged("post_install", "-at_install")
-class TierTierValidation(TransactionCase):
+class TierTierValidation(BaseCommon):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
-        cls.env = cls.env(context=dict(cls.env.context, **DISABLED_MAIL_CONTEXT))
         cls.loader = FakeModelLoader(cls.env, cls.__module__)
         cls.loader.backup_registry()
         from odoo.addons.base_tier_validation.tests.tier_validation_tester import (

base_tier_validation_forward/wizard/forward_wizard.py

@@ -1,6 +1,6 @@
 # Copyright 2020 Ecosoft Co., Ltd. (http://ecosoft.co.th)
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
-from odoo import _, fields, models
+from odoo import fields, models
 
 
 class ValidationForwardWizard(models.TransientModel):
@@ -29,7 +29,7 @@ def add_forward(self):
             self._context.get("comment_id")
         )
         prev_comment.write(
-            {"comment": _(">> %s") % self.forward_reviewer_id.display_name}
+            {"comment": self.env._(">> %s") % self.forward_reviewer_id.display_name}
         )
         prev_reviews = prev_comment.add_comment()
         review = self.env["tier.review"].create(

base_tier_validation_forward/wizard/forward_wizard_view.xml

@@ -30,4 +30,4 @@
             </form>
         </field>
     </record>
-</odoo>
+</odoo>