refactoring

Author: yaseentai

report_py3o/static/src/js/py3oactionservice.esm.js

@@ -10,9 +10,9 @@ registry
             let url = `/report/py3o/${action.report_name}`;
             const actionContext = action.context || {};
             if (
-                action.data === "undefined"||
-                action.data == null ||
-                (_typeof(action.data) === 'object' && action.data !== null)
+                typeof action.data === "undefined" ||
+                action.data === null ||
+                typeof action.data === "object"
             ) {
                 // Build a query string with `action.data` (it's the place where reports
                 // using a wizard to customize the output traditionally put their options)

report_py3o/tests/test_report_py3o.py

@@ -5,22 +5,15 @@
 import logging
 import os
 import shutil
+import sys
 import tempfile
 from base64 import b64decode, b64encode
 from contextlib import contextmanager
 from unittest import mock
-from packaging import version
-import sys
-
-# Ensuring compatibility with PyPDF2 versions depending on the Python version
-PYTHON_VERSION = version.parse(sys.version)
-
-# Conditional import based on Python version
-if PYTHON_VERSION <= version.parse("3.10"):
-    from PyPDF2.pdf import PageObject
-else:
-    from PyPDF2 import PageObject
 
+import pkg_resources
+from packaging import version
+from PyPDF2 import PdfFileWriter
 
 from odoo import tools
 from odoo.exceptions import ValidationError
@@ -39,6 +32,15 @@
 except ImportError:
     logger.debug("Cannot import genshi.core")
 
+# Ensuring compatibility with PyPDF2 versions depending on the Python version
+PYTHON_VERSION = version.parse(sys.version)
+
+# Conditional import based on Python version
+if PYTHON_VERSION <= version.parse("3.10"):
+    from PyPDF2.pdf import PageObject
+else:
+    from PyPDF2 import PageObject
+
 
 @contextmanager
 def temporary_copy(path):

report_py3o/views/ir_actions_report.xml

@@ -8,12 +8,21 @@
         <field name="arch" type="xml">
             <xpath expr="/form/field[1]" position="before">
                 <field name="is_py3o_report_not_available" invisible="1" />
-                <div class="alert alert-danger" role="alert" style="margin-bottom:0px;" invisible="is_py3o_report_not_available == False">
+                <div
+                    class="alert alert-danger"
+                    role="alert"
+                    style="margin-bottom:0px;"
+                    invisible="is_py3o_report_not_available == False"
+                >
                     <field name="msg_py3o_report_not_available" />
                 </div>
             </xpath>
             <xpath expr="//page[@name='security']" position="before">
-                <page string="LibreOffice Template" name="py3o_tab" invisible="report_type != 'py3o'">
+                <page
+                    string="LibreOffice Template"
+                    name="py3o_tab"
+                    invisible="report_type != 'py3o'"
+                >
                     <group name="py3o_params">
                         <field name="lo_bin_path" />
                         <field name="py3o_filetype" />
@@ -32,8 +41,12 @@
         <field name="inherit_id" ref="base.act_report_xml_search_view" />
         <field name="arch" type="xml">
             <field name="model" position="after">
-                <field name="report_type" invisible="1"/>
-                <filter name="py3o" string="Py3o Reports" domain="[('report_type', '=', 'py3o')]" />
+                <field name="report_type" invisible="1" />
+                <filter
+                    name="py3o"
+                    string="Py3o Reports"
+                    domain="[('report_type', '=', 'py3o')]"
+                />
             </field>
         </field>
     </record>

requirements.txt

@@ -1,4 +1,6 @@
 # generated from manifests external_dependencies
 lxml
+py3o.formats
+py3o.template
 xlrd
 xlsxwriter