[MIG] partner_phone_secondary: Migration to 18.0

Author: paradoxxxzero

partner_phone_secondary/__manifest__.py

@@ -5,7 +5,7 @@
     "name": "Secondary phone number on partners",
     "summary": "Adds a secondary phone number on partners",
     "license": "AGPL-3",
-    "version": "14.0.1.0.0",
+    "version": "18.0.1.0.0",
     "author": "Iván Todorovich, Odoo Community Association (OCA)",
     "maintainers": ["ivantodorovich"],
     "category": "Customer Relationship Management",

partner_phone_secondary/models/res_partner.py

@@ -11,7 +11,10 @@ class ResPartner(models.Model):
 
     @api.onchange("phone2", "country_id", "company_id")
     def _onchange_phone2_validation(self):
-        # Compatibility with phone_validation
-        if hasattr(self, "phone_format"):
-            if self.phone2:
-                self.phone2 = self.phone_format(self.phone2)
+        # This is done in onchange to keep consistent with phone_validation
+        # phone and mobile validation
+        if self.phone2:
+            self.phone2 = (
+                self._phone_format(fname="phone2", force_format="INTERNATIONAL")
+                or self.phone2
+            )

partner_phone_secondary/tests/test_partner_phone_secondary.py

@@ -1,19 +1,24 @@
 # Copyright 2020 - Iván Todorovich
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
-from odoo.tests.common import Form, TransactionCase
+from odoo.tests import Form, TransactionCase, tagged
 
 
+@tagged("post_install", "-at_install")
 class TestPartnerPhoneSecondary(TransactionCase):
     def test_01_phone_validation_compatibility(self):
-        # This is here only to get code coverage.
-        with Form(self.env["res.partner"]) as form:
-            form.name = "French Partner"
-            form.country_id = self.env.ref("base.fr")
-            form.phone = "766666666"
-            form.phone2 = "766666666"
-            # It's not the purpose of this module to test phone_validation,
-            # nor how it formats phone numbers. Also it's not directly depended
-            # by this module. We do know for sure, though, that the same number
-            # is going to be formatted in the exact same way.
-            self.assertEqual(form.phone, form.phone2)
+        is_phone_validation_installed = self.env["ir.module.module"].search(
+            [("name", "=", "phone_validation"), ("state", "=", "installed")]
+        )
+
+        form = Form(self.env["res.partner"])
+        form.country_id = self.env.ref("base.be")
+        form.phone = "0456998877"
+        form.phone2 = "0456998899"
+
+        if is_phone_validation_installed:
+            self.assertEqual(form.phone, "+32 456 99 88 77")
+            self.assertEqual(form.phone2, "+32 456 99 88 99")
+        else:
+            self.assertEqual(form.phone, "0456998877")
+            self.assertEqual(form.phone2, "0456998899")