[16.0][IMP] maintenance_account: Create equipment description from move line name

carolinafernandez-tecnativa · carolinafernandez-tecnativa · commit 8eaa93adc88f · 2024-03-07T23:48:45.000+01:00
TT47802
diff --git a/maintenance_account/README.rst b/maintenance_account/README.rst
@@ -7,7 +7,7 @@ Maintenance Account
    !! This file is generated by oca-gen-addon-readme !!
    !! changes will be overwritten.                   !!
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-   !! source digest: sha256:dcc1add7dc957ff122be4ff4e3777cad68abf215cc992e2909610be94ef0842a
+   !! source digest: sha256:396551f06fa48974314ca308f3634616f2e12383244bac71f9f432904463ae8f
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 
 .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
@@ -72,6 +72,7 @@ Contributors
 
   * Víctor Martínez
   * Pedro M. Baeza
+  * Carolina Fernandez
 
 Maintainers
 ~~~~~~~~~~~
diff --git a/maintenance_account/models/account_move.py b/maintenance_account/models/account_move.py
@@ -1,4 +1,5 @@
 # Copyright 2022 Tecnativa - Víctor Martínez
+# Copyright 2024 Tecnativa - Carolina Fernandez
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 from odoo import api, fields, models
 
@@ -113,13 +114,20 @@ def _set_equipment_category(self):
             self.equipment_category_id = category.id
 
     def _prepare_equipment_vals(self):
+        equipment_name = self.name
+        description = False
+        if "\n" in self.name:
+            lf_index = self.name.index("\n")
+            equipment_name = self.name[:lf_index]
+            description = self.name[lf_index + 1 :].replace("\n", "<br>")
         return {
             "move_line_id": self.id,
-            "name": self.product_id.name,
+            "name": equipment_name,
             "product_id": self.product_id.id,
             "category_id": self.equipment_category_id.id,
             "assign_date": self.move_id.date,
             "effective_date": self.move_id.date,
             "partner_id": self.move_id.partner_id.id,
             "partner_ref": self.move_id.ref,
+            "note": description,
         }
diff --git a/maintenance_account/readme/CONTRIBUTORS.rst b/maintenance_account/readme/CONTRIBUTORS.rst
@@ -4,3 +4,4 @@
 
   * Víctor Martínez
   * Pedro M. Baeza
+  * Carolina Fernandez
diff --git a/maintenance_account/static/description/index.html b/maintenance_account/static/description/index.html
@@ -1,3 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
 <head>
@@ -366,7 +367,7 @@ <h1 class="title">Maintenance Account</h1>
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-!! source digest: sha256:dcc1add7dc957ff122be4ff4e3777cad68abf215cc992e2909610be94ef0842a
+!! source digest: sha256:396551f06fa48974314ca308f3634616f2e12383244bac71f9f432904463ae8f
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
 <p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/maintenance/tree/16.0/maintenance_account"><img alt="OCA/maintenance" src="https://img.shields.io/badge/github-OCA%2Fmaintenance-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_account"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/maintenance&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module automatically creates the equipment when validating the purchase invoices.</p>
@@ -416,6 +417,7 @@ <h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
 <li><a class="reference external" href="https://www.tecnativa.com">Tecnativa</a>:<ul>
 <li>Víctor Martínez</li>
 <li>Pedro M. Baeza</li>
+<li>Carolina Fernandez</li>
 </ul>
 </li>
 </ul>
diff --git a/maintenance_account/tests/test_maintenance_account.py b/maintenance_account/tests/test_maintenance_account.py
@@ -1,17 +1,23 @@
 # Copyright 2022-2024 Tecnativa - Víctor Martínez
+# Copyright 2024 Tecnativa - Carolina Fernandez
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl)
 
 from odoo import fields
 from odoo.tests import Form, common, new_test_user
 from odoo.tests.common import users
 
-from odoo.addons.base.tests.common import DISABLED_MAIL_CONTEXT
-
 
 class TestAccountMove(common.TransactionCase):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
+        DISABLED_MAIL_CONTEXT = {
+            "tracking_disable": True,
+            "mail_create_nolog": True,
+            "mail_create_nosubscribe": True,
+            "mail_notrack": True,
+            "no_reset_password": True,
+        }
         cls.env = cls.env(context=dict(cls.env.context, **DISABLED_MAIL_CONTEXT))
         new_test_user(
             cls.env, login="test-account-user", groups="account.group_account_invoice"
@@ -27,15 +33,17 @@ def setUpClass(cls):
             {
                 "name": "Test Account",
                 "code": "TEST",
-                "account_type": "liability_payable",
+                "user_type_id": cls.env.ref(
+                    "account.data_account_type_current_liabilities"
+                ).id,
                 "reconcile": True,
             }
         )
         cls.account_expense = cls.env["account.account"].create(
             {
                 "name": "Test Account",
                 "code": "ACC",
-                "account_type": "expense",
+                "user_type_id": cls.env.ref("account.data_account_type_expenses").id,
             }
         )
         cls.journal = cls.env["account.journal"].create(
@@ -60,6 +68,7 @@ def _create_invoice(self, move_type="in_invoice"):
         move_form.invoice_date = fields.Date.from_string("2000-01-01")
         with move_form.invoice_line_ids.new() as line_form:
             line_form.product_id = self.product_a
+            line_form.name = "Product A\nTest description product A\n<b>B</b>"
             line_form.quantity = 2
         with move_form.invoice_line_ids.new() as line_form:
             line_form.product_id = self.product_b
@@ -92,8 +101,10 @@ def test_invoice_action_post_equipment_1(self):
         self.assertEqual(len(line_a.equipment_ids), 2)
         self.assertEqual(len(line_b.equipment_ids), 0)
         equipment = fields.first(equipments)
-        self.assertEqual(equipment.name, self.product_a.name)
-        self.assertEqual(equipment.product_id, self.product_a)
+        self.assertEqual(equipment.name, "Product A")
+        self.assertEqual(
+            equipment.note, "<p>Test description product A<br><b>B</b></p>"
+        )
         self.assertEqual(equipment.category_id.product_category_id, self.categ)
         self.assertEqual(equipment.assign_date, invoice.date)
         self.assertEqual(equipment.effective_date, invoice.date)

Original file line number	Diff line number	Diff line change
`@@ -4,3 +4,4 @@`
`4`	`4`
`5`	`5`	`* Víctor Martínez`
`6`	`6`	`* Pedro M. Baeza`
	`7`	`+ * Carolina Fernandez`