[MIG] maintenance_account: Migration to 16.0

TT47043

Author: victoralmau

maintenance_account/README.rst

@@ -7,7 +7,7 @@ Maintenance Account
    !! This file is generated by oca-gen-addon-readme !!
    !! changes will be overwritten.                   !!
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-   !! source digest: sha256:67684d651aad4f717395cb7f97e2a9d365438bb7ae35f38e692b39cc05848999
+   !! source digest: sha256:dcc1add7dc957ff122be4ff4e3777cad68abf215cc992e2909610be94ef0842a
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 
 .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
@@ -17,13 +17,13 @@ Maintenance Account
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fmaintenance-lightgray.png?logo=github
-    :target: https://github.com/OCA/maintenance/tree/15.0/maintenance_account
+    :target: https://github.com/OCA/maintenance/tree/16.0/maintenance_account
     :alt: OCA/maintenance
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/maintenance-15-0/maintenance-15-0-maintenance_account
+    :target: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_account
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/maintenance&target_branch=15.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/maintenance&target_branch=16.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -51,7 +51,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/maintenance/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/maintenance/issues/new?body=module:%20maintenance_account%0Aversion:%2015.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/maintenance/issues/new?body=module:%20maintenance_account%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -94,6 +94,6 @@ Current `maintainer <https://odoo-community.org/page/maintainer-role>`__:
 
 |maintainer-victoralmau| 
 
-This module is part of the `OCA/maintenance <https://github.com/OCA/maintenance/tree/15.0/maintenance_account>`_ project on GitHub.
+This module is part of the `OCA/maintenance <https://github.com/OCA/maintenance/tree/16.0/maintenance_account>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

maintenance_account/__manifest__.py

@@ -2,7 +2,7 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 {
     "name": "Maintenance Account",
-    "version": "15.0.1.0.1",
+    "version": "16.0.1.0.0",
     "category": "Maintenance",
     "website": "https://github.com/OCA/maintenance",
     "author": "Tecnativa, Odoo Community Association (OCA)",

maintenance_account/i18n/es.po

@@ -69,12 +69,3 @@ msgstr "Apunte"
 #: model:ir.model.fields,help:maintenance_account.field_maintenance_equipment__move_id
 msgid "The move of this entry line."
 msgstr "El movimiento de esta línea de entrada."
-
-#~ msgid "Display Name"
-#~ msgstr "Nombre mostrado"
-
-#~ msgid "ID"
-#~ msgstr "ID"
-
-#~ msgid "Last Modified on"
-#~ msgstr "Última modificación el"

maintenance_account/i18n/it.po

@@ -68,12 +68,3 @@ msgstr "Riga movimento"
 #: model:ir.model.fields,help:maintenance_account.field_maintenance_equipment__move_id
 msgid "The move of this entry line."
 msgstr "Il movimento per questa riga di registrazione."
-
-#~ msgid "Display Name"
-#~ msgstr "Nome visualizzato"
-
-#~ msgid "ID"
-#~ msgstr "ID"
-
-#~ msgid "Last Modified on"
-#~ msgstr "Ultima modifica il"

maintenance_account/static/description/index.html

@@ -1,4 +1,3 @@
-<?xml version="1.0" encoding="utf-8"?>
 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
 <head>
@@ -367,9 +366,9 @@ <h1 class="title">Maintenance Account</h1>
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-!! source digest: sha256:67684d651aad4f717395cb7f97e2a9d365438bb7ae35f38e692b39cc05848999
+!! source digest: sha256:dcc1add7dc957ff122be4ff4e3777cad68abf215cc992e2909610be94ef0842a
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/maintenance/tree/15.0/maintenance_account"><img alt="OCA/maintenance" src="https://img.shields.io/badge/github-OCA%2Fmaintenance-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/maintenance-15-0/maintenance-15-0-maintenance_account"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/maintenance&amp;target_branch=15.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/maintenance/tree/16.0/maintenance_account"><img alt="OCA/maintenance" src="https://img.shields.io/badge/github-OCA%2Fmaintenance-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_account"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/maintenance&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module automatically creates the equipment when validating the purchase invoices.</p>
 <p><strong>Table of contents</strong></p>
 <div class="contents local topic" id="contents">
@@ -399,7 +398,7 @@ <h1><a class="toc-backref" href="#toc-entry-2">Bug Tracker</a></h1>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/maintenance/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/maintenance/issues/new?body=module:%20maintenance_account%0Aversion:%2015.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/maintenance/issues/new?body=module:%20maintenance_account%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -430,7 +429,7 @@ <h2><a class="toc-backref" href="#toc-entry-6">Maintainers</a></h2>
 promote its widespread use.</p>
 <p>Current <a class="reference external" href="https://odoo-community.org/page/maintainer-role">maintainer</a>:</p>
 <p><a class="reference external image-reference" href="https://github.com/victoralmau"><img alt="victoralmau" src="https://github.com/victoralmau.png?size=40px" /></a></p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/maintenance/tree/15.0/maintenance_account">OCA/maintenance</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/maintenance/tree/16.0/maintenance_account">OCA/maintenance</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>

maintenance_account/tests/test_maintenance_account.py

@@ -1,26 +1,20 @@
-# Copyright 2022-2023 Tecnativa - Víctor Martínez
+# Copyright 2022-2024 Tecnativa - Víctor Martínez
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl)
 
 from odoo import fields
 from odoo.tests import Form, common, new_test_user
 from odoo.tests.common import users
 
+from odoo.addons.base.tests.common import DISABLED_MAIL_CONTEXT
+
 
 class TestAccountMove(common.TransactionCase):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
-        ctx = {
-            "mail_create_nolog": True,
-            "mail_create_nosubscribe": True,
-            "mail_notrack": True,
-            "no_reset_password": True,
-        }
+        cls.env = cls.env(context=dict(cls.env.context, **DISABLED_MAIL_CONTEXT))
         new_test_user(
-            cls.env,
-            login="test-account-user",
-            groups="account.group_account_invoice",
-            context=ctx,
+            cls.env, login="test-account-user", groups="account.group_account_invoice"
         )
         cls.categ = cls.env["product.category"].create({"name": "Test category"})
         cls.product_a = cls.env["product.product"].create(
@@ -33,15 +27,15 @@ def setUpClass(cls):
             {
                 "name": "Test Account",
                 "code": "TEST",
-                "user_type_id": cls.env.ref("account.data_account_type_payable").id,
+                "account_type": "liability_payable",
                 "reconcile": True,
             }
         )
         cls.account_expense = cls.env["account.account"].create(
             {
                 "name": "Test Account",
                 "code": "ACC",
-                "user_type_id": cls.env.ref("account.data_account_type_expenses").id,
+                "account_type": "expense",
             }
         )
         cls.journal = cls.env["account.journal"].create(
@@ -67,11 +61,9 @@ def _create_invoice(self, move_type="in_invoice"):
         with move_form.invoice_line_ids.new() as line_form:
             line_form.product_id = self.product_a
             line_form.quantity = 2
-            line_form.account_id = self.account_expense
         with move_form.invoice_line_ids.new() as line_form:
             line_form.product_id = self.product_b
             line_form.quantity = 2
-            line_form.account_id = self.account_expense
         invoice = move_form.save()
         return invoice
 

maintenance_account/views/account_move_view.xml

@@ -4,7 +4,6 @@
         <field name="name">account.move.form</field>
         <field name="model">account.move</field>
         <field name="inherit_id" ref="account.view_move_form" />
-        <field name="groups_id" eval="[(4, ref('account.group_account_invoice'))]" />
         <field name="arch" type="xml">
             <xpath expr="//div[hasclass('oe_button_box')]" position="inside">
                 <button
@@ -13,11 +12,13 @@
                     class="oe_stat_button"
                     icon="fa-cubes"
                     attrs="{'invisible': [('equipment_count', '=', 0)]}"
+                    groups="account.group_account_invoice"
                 >
                     <field
                         string="Equipment(s)"
                         name="equipment_count"
                         widget="statinfo"
+                        groups="account.group_account_invoice"
                     />
                 </button>
             </xpath>
@@ -29,8 +30,13 @@
                     name="equipment_category_id"
                     attrs="{'column_invisible': [('parent.move_type', '!=', 'in_invoice')]}"
                     optional="hide"
+                    groups="account.group_account_invoice"
+                />
+                <field
+                    name="equipment_ids"
+                    invisible="1"
+                    groups="account.group_account_invoice"
                 />
-                <field name="equipment_ids" invisible="1" />
             </xpath>
             <xpath
                 expr="//notebook//field[@name='line_ids']/tree/field[@name='date_maturity']"
@@ -40,8 +46,13 @@
                     name="equipment_category_id"
                     domain="[('company_id','=', parent.company_id)]"
                     optional="hide"
+                    groups="account.group_account_invoice"
+                />
+                <field
+                    name="equipment_ids"
+                    invisible="1"
+                    groups="account.group_account_invoice"
                 />
-                <field name="equipment_ids" invisible="1" />
             </xpath>
         </field>
     </record>

maintenance_account/views/maintenance_equipment_view.xml

@@ -6,7 +6,7 @@
         <field name="inherit_id" ref="maintenance.hr_equipment_view_form" />
         <field name="arch" type="xml">
             <xpath expr="//field[@name='serial_no']" position="after">
-                <field name="move_id" />
+                <field name="move_id" groups="account.group_account_invoice" />
             </xpath>
         </field>
     </record>