[MIG] hr_contract_update_overtime: Migration to 17.0

Author: BhaveshHeliconia

hr_contract_update_overtime/README.rst

@@ -17,13 +17,13 @@ Update Overtime from HR Contract
     :target: http://www.gnu.org/licenses/lgpl-3.0-standalone.html
     :alt: License: LGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fhr--attendance-lightgray.png?logo=github
-    :target: https://github.com/OCA/hr-attendance/tree/16.0/hr_contract_update_overtime
+    :target: https://github.com/OCA/hr-attendance/tree/17.0/hr_contract_update_overtime
     :alt: OCA/hr-attendance
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/hr-attendance-16-0/hr-attendance-16-0-hr_contract_update_overtime
+    :target: https://translation.odoo-community.org/projects/hr-attendance-17-0/hr-attendance-17-0-hr_contract_update_overtime
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/hr-attendance&target_branch=16.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/hr-attendance&target_branch=17.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -34,9 +34,9 @@ Overtime.
 
 You can Update Overtime in different ways:
 
--  An action on the Contract History tree view
--  Header button on Contract History form view
--  Header button on Contract form view
+- An action on the Contract History tree view
+- Header button on Contract History form view
+- Header button on Contract form view
 
 If you Update Overtime from Contract History, leaves will also be
 reorganized across their contract calendars.
@@ -77,7 +77,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/hr-attendance/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/hr-attendance/issues/new?body=module:%20hr_contract_update_overtime%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/hr-attendance/issues/new?body=module:%20hr_contract_update_overtime%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -92,7 +92,8 @@ Authors
 Contributors
 ------------
 
--  Eduardo de Miguel (`Moduon <https://www.moduon.team/>`__)
+- Eduardo de Miguel (`Moduon <https://www.moduon.team/>`__)
+- ``Heliconia Solutions Pvt. Ltd. <https://www.heliconia.io>``\ \_
 
 Maintainers
 -----------
@@ -118,6 +119,6 @@ Current `maintainers <https://odoo-community.org/page/maintainer-role>`__:
 
 |maintainer-Shide| |maintainer-rafaelbn| 
 
-This module is part of the `OCA/hr-attendance <https://github.com/OCA/hr-attendance/tree/16.0/hr_contract_update_overtime>`_ project on GitHub.
+This module is part of the `OCA/hr-attendance <https://github.com/OCA/hr-attendance/tree/17.0/hr_contract_update_overtime>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

hr_contract_update_overtime/__manifest__.py

@@ -4,7 +4,7 @@
 {
     "name": "Update Overtime from HR Contract",
     "summary": "Update Overtime from HR Contract",
-    "version": "16.0.1.0.0",
+    "version": "17.0.1.0.0",
     "development_status": "Alpha",
     "category": "Human Resources/Contracts",
     "website": "https://github.com/OCA/hr-attendance",

hr_contract_update_overtime/data/hr_contract_history_data.xml

@@ -7,10 +7,10 @@
         <field name="name">Update Overtime</field>
         <field name="model_id" ref="hr_contract.model_hr_contract_history" />
         <field name="binding_model_id" ref="hr_contract.model_hr_contract_history" />
-        <field name="binding_view_types">tree</field>
+        <field name="binding_view_types">list</field>
         <field
             name="groups_id"
-            eval="[(4, ref('hr_attendance.group_hr_attendance_user'))]"
+            eval="[(4, ref('hr_attendance.group_hr_attendance_officer'))]"
         />
         <field name="state">code</field>
         <field name="code">records.action_update_overtime()</field>

hr_contract_update_overtime/readme/CONTRIBUTORS.md

@@ -1 +1,2 @@
 -   Eduardo de Miguel ([Moduon](https://www.moduon.team/))
+- `Heliconia Solutions Pvt. Ltd. <https://www.heliconia.io>`_

hr_contract_update_overtime/static/description/index.html

@@ -369,7 +369,7 @@ <h1 class="title">Update Overtime from HR Contract</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:a735232b2f18ecb1807c245231cd5ad03f9ea9de28112c85bf14ea9345ad9bcb
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Alpha" src="https://img.shields.io/badge/maturity-Alpha-red.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/lgpl-3.0-standalone.html"><img alt="License: LGPL-3" src="https://img.shields.io/badge/licence-LGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/hr-attendance/tree/16.0/hr_contract_update_overtime"><img alt="OCA/hr-attendance" src="https://img.shields.io/badge/github-OCA%2Fhr--attendance-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/hr-attendance-16-0/hr-attendance-16-0-hr_contract_update_overtime"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/hr-attendance&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Alpha" src="https://img.shields.io/badge/maturity-Alpha-red.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/lgpl-3.0-standalone.html"><img alt="License: LGPL-3" src="https://img.shields.io/badge/licence-LGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/hr-attendance/tree/17.0/hr_contract_update_overtime"><img alt="OCA/hr-attendance" src="https://img.shields.io/badge/github-OCA%2Fhr--attendance-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/hr-attendance-17-0/hr-attendance-17-0-hr_contract_update_overtime"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/hr-attendance&amp;target_branch=17.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module extends the functionality of Contracts and Attendances to
 support recalculating Overtime and to allow you to keep up to date your
 Overtime.</p>
@@ -424,7 +424,7 @@ <h1><a class="toc-backref" href="#toc-entry-3">Bug Tracker</a></h1>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/hr-attendance/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/hr-attendance/issues/new?body=module:%20hr_contract_update_overtime%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/hr-attendance/issues/new?body=module:%20hr_contract_update_overtime%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -439,6 +439,7 @@ <h2><a class="toc-backref" href="#toc-entry-5">Authors</a></h2>
 <h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
 <ul class="simple">
 <li>Eduardo de Miguel (<a class="reference external" href="https://www.moduon.team/">Moduon</a>)</li>
+<li><tt class="docutils literal">Heliconia Solutions Pvt. Ltd. <span class="pre">&lt;https://www.heliconia.io&gt;</span></tt>_</li>
 </ul>
 </div>
 <div class="section" id="maintainers">
@@ -452,7 +453,7 @@ <h2><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h2>
 promote its widespread use.</p>
 <p>Current <a class="reference external" href="https://odoo-community.org/page/maintainer-role">maintainers</a>:</p>
 <p><a class="reference external image-reference" href="https://github.com/Shide"><img alt="Shide" src="https://github.com/Shide.png?size=40px" /></a> <a class="reference external image-reference" href="https://github.com/rafaelbn"><img alt="rafaelbn" src="https://github.com/rafaelbn.png?size=40px" /></a></p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/hr-attendance/tree/16.0/hr_contract_update_overtime">OCA/hr-attendance</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/hr-attendance/tree/17.0/hr_contract_update_overtime">OCA/hr-attendance</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>

hr_contract_update_overtime/tests/test_hr_contract_update_overtime.py

@@ -29,7 +29,7 @@ def setUpClass(cls):
 
         def make_dtt(days_before, h=0, m=0, to_date=False):
             dat = datetime.combine(
-                today - timedelta(days=days_before), datetime.min.time()
+                today - timedelta(days=days_before + 1), datetime.min.time()
             ).replace(hour=h, minute=m)
             if to_date:
                 return dat.date().strftime(DEFAULT_SERVER_DATE_FORMAT)
@@ -197,33 +197,37 @@ def make_dtt(days_before, h=0, m=0, to_date=False):
             ]
         )
         # Create all leaves on last contract
-        leaves = cls.env["resource.calendar.leaves"].create(
-            [
-                {
-                    "name": "Test Leave 2h",
-                    "date_from": make_dtt(4, h=8, m=0),
-                    "date_to": make_dtt(4, h=8, m=30),
-                    "resource_id": cls.employee.resource_id.id,
-                    "calendar_id": rc_8h_day.id,
-                    "company_id": company.id,
-                },
-                {
-                    "name": "Test Leave 4h",
-                    "date_from": make_dtt(3, h=8, m=0),
-                    "date_to": make_dtt(3, h=8, m=30),
-                    "resource_id": cls.employee.resource_id.id,
-                    "calendar_id": rc_8h_day.id,
-                    "company_id": company.id,
-                },
-                {
-                    "name": "Test Leave 8h",
-                    "date_from": make_dtt(2, h=8, m=0),
-                    "date_to": make_dtt(2, h=8, m=30),
-                    "resource_id": cls.employee.resource_id.id,
-                    "calendar_id": rc_8h_day.id,
-                    "company_id": company.id,
-                },
-            ]
+        leaves = (
+            cls.env["resource.calendar.leaves"]
+            .with_context(leave_skip_date_check=True)
+            .create(
+                [
+                    {
+                        "name": "Test Leave 2h",
+                        "date_from": make_dtt(4, h=8, m=0),
+                        "date_to": make_dtt(4, h=10, m=0),
+                        "resource_id": cls.employee.resource_id.id,
+                        "calendar_id": rc_8h_day.id,
+                        "company_id": company.id,
+                    },
+                    {
+                        "name": "Test Leave 4h",
+                        "date_from": make_dtt(3, h=10, m=30),
+                        "date_to": make_dtt(3, h=13, m=30),
+                        "resource_id": cls.employee.resource_id.id,
+                        "calendar_id": rc_8h_day.id,
+                        "company_id": company.id,
+                    },
+                    {
+                        "name": "Test Leave 8h",
+                        "date_from": make_dtt(2, h=14, m=0),
+                        "date_to": make_dtt(2, h=22, m=0),
+                        "resource_id": cls.employee.resource_id.id,
+                        "calendar_id": rc_8h_day.id,
+                        "company_id": company.id,
+                    },
+                ]
+            )
         )
         # `hr_holidays_attendance` adds extra constrains when considering one
         # leave valid for an employee. It wouldn't be a problem, but it's
@@ -263,7 +267,7 @@ def test_overtime(self):
             .mapped("duration")
         )
         # Check Overtime
-        self.assertEqual(sum(total_overtime), -1.5)
+        self.assertEqual(sum(total_overtime), 2.5)
         # Check Leaves has been moved correctly
         for contract in self.contract_history.contract_ids:
             self.assertEqual(len(contract.resource_calendar_id.leave_ids), 1)

hr_contract_update_overtime/views/hr_contract_history_view.xml

@@ -11,7 +11,7 @@
                     name="action_update_overtime"
                     string="Update Overtime"
                     type="object"
-                    groups="hr_attendance.group_hr_attendance_user"
+                    groups="hr_attendance.group_hr_attendance_officer"
                     help="Update Overtime on Running and Expired contracts"
                     confirm="This action will also reorganize all the Employee's leaves by distributing them across their contract calendars. If you do not want this to happen, you can Update Overtime from a specific contract."
                 />

hr_contract_update_overtime/views/hr_contract_view.xml

@@ -11,8 +11,8 @@
                     name="action_update_overtime"
                     string="Update Overtime"
                     type="object"
-                    groups="hr_attendance.group_hr_attendance_user"
-                    attrs="{'invisible': [('state', 'not in', ['open', 'close'])]}"
+                    groups="hr_attendance.group_hr_attendance_officer"
+                    invisible="state not in ('open', 'close')"
                 />
             </xpath>
         </field>