[MIG] hr_attendance_modification_tracking: Migration to 16.0

Author: dalonsofl

hr_attendance_modification_tracking/i18n/es.po

@@ -190,6 +190,6 @@ msgstr ""
 #, python-format
 msgid ""
 "It is not possible to register a new entry because there is already an "
-"existing one."
+"existing one"
 msgstr ""
 "No es posible registrar entrada de nuevo porque ya hay una existente"

hr_attendance_modification_tracking/models/hr_attendance.py

@@ -4,8 +4,7 @@
 
 from datetime import timedelta
 
-from odoo import _, api, fields, models
-from odoo.exceptions import UserError
+from odoo import api, fields, models
 
 
 class HrAttendance(models.Model):
@@ -28,24 +27,14 @@ class HrAttendance(models.Model):
     def create(self, vals):
         tolerance = timedelta(seconds=60)
         now = fields.Datetime.now()
-        employee = self.env["hr.employee"].browse(vals.get("employee_id"))
-        if not employee.attendance_ids:
-            for check in ["check_in", "check_out"]:
-                if (
-                    vals.get(check, False)
-                    and abs(fields.Datetime.from_string(vals.get(check)) - now)
-                    > tolerance
-                ):
-                    vals.update({"time_changed_manually": True})
-                    break
-            return super().create(vals)
-        else:
-            raise UserError(
-                _(
-                    "It is not possible to register a new entry because there is "
-                    "already an existing one."
-                )
-            )
+        for check in ["check_in", "check_out"]:
+            if (
+                vals.get(check, False)
+                and abs(fields.Datetime.from_string(vals.get(check)) - now) > tolerance
+            ):
+                vals.update({"time_changed_manually": True})
+                break
+        return super().create(vals)
 
     def write(self, vals):
         tolerance = timedelta(seconds=60)

hr_attendance_modification_tracking/tests/test_hr_attendance.py

@@ -6,29 +6,21 @@
 
 from dateutil.relativedelta import relativedelta
 
-from odoo.exceptions import UserError
 from odoo.tests.common import TransactionCase
 from odoo.tools import DEFAULT_SERVER_DATETIME_FORMAT as DF
 
 
 class TestHrAttendanceTracking(TransactionCase):
-    def setUp(self):
-        super(TestHrAttendanceTracking, self).setUp()
-        self.hr_attendance = self.env["hr.attendance"]
-        self.employee_01 = self.env["hr.employee"].create({"name": "Employee01"})
-        self.employee_02 = self.env["hr.employee"].create({"name": "Employee02"})
-        self.employee_03 = self.env["hr.employee"].create({"name": "Employee03"})
-        self.employee_04 = self.env["hr.employee"].create({"name": "Employee04"})
-        self.employee_05 = self.env["hr.employee"].create({"name": "Employee05"})
-        self.employee_06 = self.env["hr.employee"].create({"name": "Employee06"})
-        self.employee_07 = self.env["hr.employee"].create({"name": "Employee07"})
-        dti = datetime.now()
-        self.att_test = self.hr_attendance.create(
-            {
-                "employee_id": self.employee_07.id,
-                "check_in": dti.strftime(DF),
-            }
-        )
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls.hr_attendance = cls.env["hr.attendance"]
+        cls.employee_01 = cls.env["hr.employee"].create({"name": "Employee01"})
+        cls.employee_02 = cls.env["hr.employee"].create({"name": "Employee02"})
+        cls.employee_03 = cls.env["hr.employee"].create({"name": "Employee03"})
+        cls.employee_04 = cls.env["hr.employee"].create({"name": "Employee04"})
+        cls.employee_05 = cls.env["hr.employee"].create({"name": "Employee05"})
+        cls.employee_06 = cls.env["hr.employee"].create({"name": "Employee06"})
 
     def test_attendance_edit_01(self):
         # We can't check kiosk and check-in/check-out form
@@ -151,17 +143,3 @@ def test_attendance_edit_07(self):
             False,
             "Use case 7: Wrong value, time not changed manually.",
         )
-
-    def test_attendance_edit_08(self):
-        # Use case 8:
-        # Trying to create a check-in with an existing one
-        dti = datetime.now() + relativedelta(minutes=15)
-        with self.assertRaises(UserError) as e:
-            self.att_test.create(
-                {"employee_id": self.employee_07.id, "check_in": dti.strftime(DF)}
-            )
-        self.assertEqual(
-            e.exception.args[0],
-            "It is not possible to register a new entry because there is already "
-            "an existing one.",
-        )