[BPRT] edi: Backport from 14.0 (third part)

Author: MiquelRForgeFlow

edi_oca/__manifest__.py

@@ -18,6 +18,7 @@
     "depends": [
         "base_edi",
         "component_event",
+        "http_routing",
         "mail",
         "base_sparse_field",
         "queue_job",

edi_oca/models/edi_backend.py

@@ -223,6 +223,7 @@ def exchange_generate(self, exchange_record, store=True, force=False, **kw):
                     "edi_exchange_state": "output_pending",
                 }
             )
+            exchange_record._onchange_edi_exchange_state()
         try:
             # TODO: Remove this on 15.0, we will keep it in order to not break current
             # installations
@@ -240,6 +241,7 @@ def exchange_generate(self, exchange_record, store=True, force=False, **kw):
                 exchange_record.update(
                     {"edi_exchange_state": state, "exchange_error": error}
                 )
+                exchange_record._onchange_edi_exchange_state()
         exchange_record.notify_action_complete("generate", message=message)
         return message
 
@@ -330,6 +332,7 @@ def exchange_send(self, exchange_record):
                     "exchanged_on": fields.Datetime.now(),
                 }
             )
+            exchange_record._onchange_edi_exchange_state()
         exchange_record.notify_action_complete("send", message=message)
         return res
 
@@ -491,6 +494,7 @@ def exchange_process(self, exchange_record):
                     "exchange_error": error,
                 }
             )
+            exchange_record._onchange_edi_exchange_state()
             if (
                 state == "input_processed_error"
                 and old_state != "input_processed_error"
@@ -551,6 +555,7 @@ def exchange_receive(self, exchange_record):
                     "exchanged_on": fields.Datetime.now(),
                 }
             )
+            exchange_record._onchange_edi_exchange_state()
         exchange_record.notify_action_complete("receive", message=message)
         return res
 
@@ -637,7 +642,8 @@ def _find_existing_exchange_records(
         return self.env["edi.exchange.record"].search(domain, count=count_only)
 
     def action_view_exchanges(self):
-        action = self.env.ref("edi_oca.act_open_edi_exchange_record_view")
+        action = self.env.ref(
+            "edi_oca.act_open_edi_exchange_record_view").sudo().read()[0]
         action["context"] = {
             "search_default_backend_id": self.id,
             "default_backend_id": self.id,
@@ -646,7 +652,8 @@ def action_view_exchanges(self):
         return action
 
     def action_view_exchange_types(self):
-        action = self.env.ref("edi_oca.act_open_edi_exchange_type_view")
+        action = self.env.ref(
+            "edi_oca.act_open_edi_exchange_type_view").sudo().read()[0]
         action["context"] = {
             "search_default_backend_id": self.id,
             "default_backend_id": self.id,

edi_oca/models/edi_exchange_consumer_mixin.py

@@ -184,7 +184,8 @@ def edi_create_exchange_record(self, exchange_type_id):
         return self._edi_get_create_record_wiz_action(exchange_type_id)
 
     def _edi_get_create_record_wiz_action(self, exchange_type_id):
-        action = self.env.ref("edi_oca.edi_exchange_record_create_act_window")
+        action = self.env.ref(
+            "edi_oca.edi_exchange_record_create_act_window").sudo().read()[0]
         action["context"] = {
             "default_res_id": self.id,
             "default_model": self._name,
@@ -244,7 +245,8 @@ def _compute_exchange_record_count(self):
 
     def action_view_edi_records(self):
         self.ensure_one()
-        action = self.env.ref("edi_oca.act_open_edi_exchange_record_view")
+        action = self.env.ref(
+            "edi_oca.act_open_edi_exchange_record_view").sudo().read()[0]
         action["domain"] = [("model", "=", self._name), ("res_id", "=", self.id)]
         # Purge default search filters from ctx to avoid hiding records
         ctx = action.get("context") or {}

edi_oca/models/edi_exchange_record.py

@@ -8,7 +8,6 @@
 from collections import defaultdict
 
 from odoo import _, api, exceptions, fields, models
-from odoo import SUPERUSER_ID
 from odoo.exceptions import MissingError
 
 _logger = logging.getLogger(__name__)
@@ -132,8 +131,8 @@ def _compute_exchange_filename(self):
             if not rec.exchange_filename:
                 rec.exchange_filename = rec.type_id._make_exchange_filename(rec)
 
-    @api.constrains("edi_exchange_state")
-    def _compute_exchanged_on(self):
+    @api.onchange("edi_exchange_state")
+    def _onchange_edi_exchange_state(self):
         for rec in self:
             if rec.edi_exchange_state in ("input_received", "output_sent"):
                 rec.exchanged_on = fields.Datetime.now()
@@ -193,9 +192,11 @@ def record(self):
         # data from parent
         if not self.model and not self.parent_id:
             return None
-        if not self.model and self.parent_id:
+        elif not self.model and self.parent_id:
             return self.parent_id.record
-        return self.env[self.model].browse(self.res_id).exists()
+        elif self.model in self.env.registry.models:
+            return self.env[self.model].browse(self.res_id).exists()
+        return None
 
     def _set_file_content(
         self, output_string, encoding="utf-8", field_name="exchange_file"
@@ -222,7 +223,7 @@ def name_get(self):
         result = []
         for rec in self:
             rec_name = rec.identifier
-            if rec.res_id and rec.model:
+            if rec.res_id and rec.model and rec.record:
                 rec_name = rec.record.display_name
             name = "[{}] {}".format(rec.type_id.name, rec_name)
             result.append((rec.id, name))
@@ -356,7 +357,8 @@ def action_open_related_exchanges(self):
         self.ensure_one()
         if not self.related_exchange_ids:
             return {}
-        action = self.env.ref("edi_oca.act_open_edi_exchange_record_view")
+        action = self.env.ref(
+            "edi_oca.act_open_edi_exchange_record_view").sudo().read()[0]
         action["domain"] = [("id", "in", self.related_exchange_ids.ids)]
         return action
 
@@ -453,8 +455,8 @@ def _search(
             count=False,
             access_rights_uid=access_rights_uid,
         )
-        if self._uid == SUPERUSER_ID:
-            # rules do not apply for the superuser
+        if self.env.user._is_system():
+            # rules do not apply to group "Settings"
             return len(ids) if count else ids
 
         # TODO highlight orphaned EDI records in UI:
@@ -531,7 +533,7 @@ def check_access_rule(self, operation):
         """In order to check if we can access a record, we are checking if we can access
         the related document"""
         super(EDIExchangeRecord, self).check_access_rule(operation)
-        if self._uid == SUPERUSER_ID:
+        if self.env.user._is_superuser():
             return
         default_checker = self.env["edi.exchange.consumer.mixin"].get_edi_access
         by_model_rec_ids = defaultdict(set)
@@ -584,8 +586,9 @@ def _inverse_res_id(self):
             if not rec.model or not rec.res_id:
                 continue
             try:
-                rec.env[rec.model].browse(rec.res_id).write({
-                    'exchange_record_ids': [(4, rec.id)]
-                })
+                if "exchange_record_ids" in rec.env[rec.model]._fields:
+                    rec.env[rec.model].browse(rec.res_id).write({
+                        'exchange_record_ids': [(4, rec.id)]
+                    })
             except (KeyError, ValueError, MissingError):
                 continue

edi_oca/models/edi_exchange_type.py

@@ -185,6 +185,13 @@ def _compute_ack_for_type_ids(self):
         for rec in self:
             rec.ack_for_type_ids = [x.id for x in by_type_id.get(rec.id, [])]
 
+    @api.multi
+    @api.returns('self', lambda value: value.id)
+    def copy(self, default=None):
+        rec = super(EDIExchangeType, self.with_context(
+            deprecated_rule_fields_bypass_inverse=True)).copy(default)
+        return rec
+
     def get_settings(self):
         return self.advanced_settings
 
@@ -237,7 +244,8 @@ def _make_exchange_filename(self, exchange_record):
         )
 
     def _get_record_name(self, exchange_record):
-        if not exchange_record.res_id or not exchange_record.model:
+        if (not exchange_record.res_id or not exchange_record.model or
+                not exchange_record.record):
             return slugify(exchange_record.display_name)
         if hasattr(exchange_record.record, "_get_edi_exchange_record_name"):
             return exchange_record.record._get_edi_exchange_record_name(exchange_record)

edi_oca/security/ir_model_access.xml

@@ -90,15 +90,6 @@
         <field name="perm_write" eval="1" />
         <field name="perm_unlink" eval="1" />
     </record>
-    <record model="ir.model.access" id="access_edi_exchange_record_create_user">
-        <field name="name">access_edi_exchange_record user</field>
-        <field name="model_id" ref="model_edi_exchange_record_create_wiz" />
-        <field name="group_id" ref="base.group_user" />
-        <field name="perm_read" eval="1" />
-        <field name="perm_create" eval="1" />
-        <field name="perm_write" eval="1" />
-        <field name="perm_unlink" eval="1" />
-    </record>
     <record id="rule_edi_exchange_record_user" model="ir.rule">
         <field name="name">Assigned EDI exchange records</field>
         <field name="model_id" ref="edi_oca.model_edi_exchange_record" />

edi_oca/tests/test_backend_input.py

@@ -40,6 +40,7 @@ def test_receive_record_nothing_todo(self):
 
     def test_receive_record(self):
         self.record.edi_exchange_state = "input_pending"
+        self.record._onchange_edi_exchange_state()
         self.backend.with_context(fake_output="yeah!").exchange_receive(self.record)
         self.assertEqual(self.record._get_file_content(), "yeah!")
         self.assertRecordValues(self.record, [{"edi_exchange_state": "input_received"}])

edi_oca/tests/test_backend_output.py

@@ -46,6 +46,7 @@ def test_generate_record_output_pdf(self):
 
     def test_send_record(self):
         self.record.write({"edi_exchange_state": "output_pending"})
+        self.record._onchange_edi_exchange_state()
         self.record._set_file_content("TEST %d" % self.record.id)
         self.assertFalse(self.record.exchanged_on)
         now = fields.Datetime.now()
@@ -58,6 +59,7 @@ def test_send_record(self):
 
     def test_send_record_with_error(self):
         self.record.write({"edi_exchange_state": "output_pending"})
+        self.record._onchange_edi_exchange_state()
         self.record._set_file_content("TEST %d" % self.record.id)
         self.assertFalse(self.record.exchanged_on)
         self.record.with_context(

edi_oca/tests/test_backend_process.py

@@ -34,6 +34,7 @@ def setUp(self):
 
     def test_process_record(self):
         self.record.write({"edi_exchange_state": "input_received"})
+        self.record._onchange_edi_exchange_state()
         now = fields.Datetime.now()
         self.record.action_exchange_process()
         self.assertTrue(FakeInputProcess.check_called_for(self.record))
@@ -47,6 +48,7 @@ def test_process_record(self):
 
     def test_process_record_with_error(self):
         self.record.write({"edi_exchange_state": "input_received"})
+        self.record._onchange_edi_exchange_state()
         self.record._set_file_content("TEST %d" % self.record.id)
         self.record.with_context(
             test_break_process="OOPS! Something went wrong :("
@@ -65,6 +67,7 @@ def test_process_record_with_error(self):
     @mute_logger("odoo.models.unlink")
     def test_process_no_file_record(self):
         self.record.write({"edi_exchange_state": "input_received"})
+        self.record._onchange_edi_exchange_state()
         self.record.exchange_file = False
         with self.assertRaises(UserError):
             self.record.action_exchange_process()

edi_oca/tests/test_backend_validate.py

@@ -44,6 +44,7 @@ def setUp(self):
 
     def test_receive_validate_record(self):
         self.record_in.write({"edi_exchange_state": "input_pending"})
+        self.record_in._onchange_edi_exchange_state()
         self.backend.exchange_receive(self.record_in)
         self.assertTrue(FakeInputValidate.check_called_for(self.record_in))
         self.assertRecordValues(
@@ -52,6 +53,7 @@ def test_receive_validate_record(self):
 
     def test_receive_validate_record_error(self):
         self.record_in.write({"edi_exchange_state": "input_pending"})
+        self.record_in._onchange_edi_exchange_state()
         exc = EDIValidationError("Data seems wrong!")
         self.backend.with_context(test_break_validate=exc).exchange_receive(
             self.record_in
@@ -69,6 +71,7 @@ def test_receive_validate_record_error(self):
 
     def test_generate_validate_record(self):
         self.record_out.write({"edi_exchange_state": "new"})
+        self.record_out._onchange_edi_exchange_state()
         self.backend.exchange_generate(self.record_out)
         self.assertTrue(FakeOutputValidate.check_called_for(self.record_out))
         self.assertRecordValues(
@@ -77,6 +80,7 @@ def test_generate_validate_record(self):
 
     def test_generate_validate_record_error(self):
         self.record_out.write({"edi_exchange_state": "new"})
+        self.record_out._onchange_edi_exchange_state()
         exc = EDIValidationError("Data seems wrong!")
         self.backend.with_context(test_break_validate=exc).exchange_generate(
             self.record_out

edi_oca/tests/test_consumer_mixin.py

@@ -9,7 +9,6 @@
 
 from lxml import etree
 from odoo_test_helper import FakeModelLoader
-from odoo.tools.safe_eval import safe_eval
 
 from odoo.tests.common import Form
 
@@ -49,7 +48,7 @@ def _setup_records(cls):
             direction="output",
             exchange_file_ext="csv",
             backend_id=False,
-            exchange_filename_pattern="{record.name}-{type.code}-{dt}",
+            exchange_filename_pattern="{record_name}-{type.code}-{dt}",
             rule_ids=[(0, 0, rule_vals)],
         )
         rule_vals = {
@@ -91,7 +90,7 @@ def test_mixin(self):
         self.consumer_record.refresh()
         self.assertEqual(
             exchange_record, self.env["edi.exchange.record"].search(
-                safe_eval(action["domain"]))
+                action["domain"])
         )
         self.assertTrue(
             self.consumer_record._has_exchange_record(
@@ -165,10 +164,9 @@ def test_multiple_backend(self):
         )
         self.assertNotEqual(action["res_model"], "edi.exchange.record")
         self.assertEqual(action["res_model"], "edi.exchange.record.create.wiz")
-        context = safe_eval(action["context"])
         wizard = (
             self.env[action["res_model"]]
-            .with_context(**context)
+            .with_context(**action["context"])
             .create({"backend_id": self.backend_02.id})
         )
         wizard.create_edi()

edi_oca/tests/test_edi_backend_cron.py

@@ -83,6 +83,7 @@ def test_exchange_generate_output_ready_auto_send(self):
             self.assertEqual(rec.edi_exchange_state, "new")
         self.record1._set_file_content("READY")
         self.record1.edi_exchange_state = "output_sent"
+        self.record1._onchange_edi_exchange_state()
         self.backend.with_context(
             fake_update_values={"edi_exchange_state": "output_sent_and_processed"}
         )._cron_check_output_exchange_sync(skip_sent=False)

edi_oca/tests/test_record.py

@@ -69,6 +69,7 @@ def test_record_exchange_date(self):
         self.assertFalse(record.exchanged_on)
         now = fields.Datetime.now()
         record.edi_exchange_state = "output_sent"
+        record._onchange_edi_exchange_state()
         record.refresh()
         self.assertAlmostEqual(
             (record.exchanged_on - now).total_seconds(), 0, places=2
@@ -209,6 +210,7 @@ def test_retry(self):
         record0 = self.backend.create_record("test_csv_output", vals)
         self.assertFalse(record0.retryable)
         record0.edi_exchange_state = "output_error_on_send"
+        record0._onchange_edi_exchange_state()
         self.assertTrue(record0.retryable)
         with mock.patch.object(type(record0), "_execute_next_action") as mocked:
             record0.action_retry()