[IMP] edi_storage_oca: Fix permission

Enable any internal user to trigger creation of EDI records without EDI Manager group nor read access to storage.backend

Author: tuantrantg

edi_storage_oca/components/base.py

@@ -79,7 +79,7 @@ def _get_remote_file(self, state, filename=None, binary=False):
             # TODO: support match via pattern (eg: filename-prefix-*)
             # otherwise is impossible to retrieve input files and acks
             # (the date will never match)
-            return self.storage.get(path.as_posix(), binary=binary)
+            return self.storage.sudo().get(path.as_posix(), binary=binary)
         except FileNotFoundError:
             _logger.info(
                 "Ignored FileNotFoundError when trying "

edi_storage_oca/components/receive.py

@@ -15,5 +15,5 @@ class EDIStorageReceiveComponent(Component):
 
     def receive(self):
         path = self._get_remote_file_path("pending")
-        filedata = self.storage.get(path.as_posix())
+        filedata = self.storage.get(path.as_posix(), binary=True)
         return filedata

edi_storage_oca/components/send.py

@@ -25,7 +25,7 @@ def send(self):
             return True
         filedata = self.exchange_record.exchange_file
         path = self._get_remote_file_path("pending")
-        self.storage.add(path.as_posix(), filedata, binary=False)
+        self.storage.sudo().add(path.as_posix(), filedata, binary=False)
         # TODO: delegate this to generic storage backend
         # except paramiko.ssh_exception.AuthenticationException:
         #     # TODO this exc handling should be moved to sftp backend IMO

edi_storage_oca/models/edi_backend.py

@@ -72,7 +72,7 @@ def _component_match_attrs(self, exchange_record, key):
         res = super()._component_match_attrs(exchange_record, key)
         if not self.storage_id or key not in self._storage_actions:
             return res
-        res["storage_backend_type"] = self.storage_id.backend_type
+        res["storage_backend_type"] = self.sudo().storage_id.backend_type
         return res
 
     def _component_sort_key(self, component_class):

edi_storage_oca/tests/common.py

@@ -106,11 +106,11 @@ def _mocked_backend_list_files(self, mocked_paths, path, **kwargs):
 
     def _mock_storage_backend_get(self, mocked_paths):
         mocked = functools.partial(self._mocked_backend_get, mocked_paths)
-        return mock.patch(STORAGE_BACKEND_MOCK_PATH + "._get_b64_data", mocked)
+        return mock.patch(STORAGE_BACKEND_MOCK_PATH + ".get", mocked)
 
     def _mock_storage_backend_add(self):
         return mock.patch(
-            STORAGE_BACKEND_MOCK_PATH + "._add_b64_data", self._mocked_backend_add
+            STORAGE_BACKEND_MOCK_PATH + ".add", self._mocked_backend_add
         )
 
     def _mock_storage_backend_list_files(self, mocked_paths):

edi_storage_oca/tests/test_components_base.py

@@ -30,7 +30,7 @@ def test_remote_file_path(self):
             self.checker_input._get_remote_file_path("WHATEVER", "foo.csv")
 
     def test_get_remote_file(self):
-        with mock.patch(STORAGE_BACKEND_MOCK_PATH + "._get_b64_data") as mocked:
+        with mock.patch(STORAGE_BACKEND_MOCK_PATH + ".get") as mocked:
             self.checker._get_remote_file("pending")
             mocked.assert_called_with(
                 "demo_out/pending/{}".format(self._filename(self.record)), binary=False