[IMP] base_import_pdf_by_template: Add fixed value compatibility to different types of fields

TT51379

Author: victoralmau

base_import_pdf_by_template/README.rst

@@ -102,7 +102,6 @@ Known issues / Roadmap
 ======================
 
 - Add operator in template lines (= or ilike)
-- Add support for selection fields as default value.
 - Simplify auto-detection (defining a text only to search the system should search the
   corresponding regular expression).
 - Allow compatibility with registration process created from email alias (for purchase

base_import_pdf_by_template/demo/base_import_pdf_template.xml

@@ -49,6 +49,16 @@
         <field name="value_type">fixed</field>
         <field name="fixed_value" ref="base.user_admin" />
     </record>
+    <record
+        id="demo_base_import_pdf_template_res_partner_header_05"
+        model="base.import.pdf.template.line"
+    >
+        <field name="template_id" ref="demo_base_import_pdf_template_res_partner" />
+        <field name="related_model">header</field>
+        <field name="field_id" ref="base.field_res_partner__ref" />
+        <field name="value_type">fixed</field>
+        <field name="fixed_value_char">fixed-ref</field>
+    </record>
     <record
         id="demo_base_import_pdf_template_res_partner_line_01"
         model="base.import.pdf.template.line"

base_import_pdf_by_template/models/base_import_pdf_template.py

@@ -127,7 +127,9 @@ def _prepare_ctx_from_model(self, model):
         for fixed_key in list(fixed_fields.keys()):
             ctx_key = "default_%s" % fixed_key
             fixed_value = fixed_fields[fixed_key]
-            ctx.update({ctx_key: fixed_value.id})
+            if isinstance(fixed_value, models.Model):
+                fixed_value = fixed_value.id
+            ctx.update({ctx_key: fixed_value})
         return ctx
 
     def _get_fixed_fields_from_model(self, model):
@@ -136,7 +138,7 @@ def _get_fixed_fields_from_model(self, model):
             lambda x: x.model == model and x.value_type == "fixed"
         )
         for fixed_field in fixed_fields:
-            res[fixed_field.field_name] = fixed_field.fixed_value
+            res[fixed_field.field_name] = fixed_field._get_fixed_value()
         return res
 
     def _get_field_header_values(self, text):
@@ -275,6 +277,16 @@ class BaseImportPdfTemplateLine(models.Model):
         default="variable",
         string="Value type",
     )
+    fixed_value_char = fields.Char()
+    fixed_value_date = fields.Date()
+    fixed_value_datetime = fields.Datetime()
+    fixed_value_float = fields.Float()
+    fixed_value_html = fields.Html()
+    fixed_value_integer = fields.Integer()
+    fixed_value_selection = fields.Many2one(
+        comodel_name="ir.model.fields.selection", domain="[('field_id', '=', field_id)]"
+    )
+    fixed_value_text = fields.Text()
     fixed_value = fields.Reference(
         selection="_selection_reference_value",
         string="Fixed value",
@@ -313,6 +325,27 @@ def _compute_model(self):
                 else item.template_id.child_model
             )
 
+    def _get_fixed_field_name_ttype_mapped(self):
+        return {
+            "char": "fixed_value_char",
+            "date": "fixed_value_date",
+            "datetime": "fixed_value_datetime",
+            "float": "fixed_value_float",
+            "html": "fixed_value_html",
+            "integer": "fixed_value_integer",
+            "selection": "fixed_value_selection",
+            "text": "fixed_value_text",
+            "many2one": "fixed_value",
+        }
+
+    def _get_fixed_value(self):
+        self.ensure_one()
+        f_name = self._get_fixed_field_name_ttype_mapped()[self.field_ttype]
+        f_value = self[f_name]
+        if self.field_ttype == "selection":
+            f_value = f_value.value
+        return f_value
+
     def _replace_text(self, text, letters, prefix):
         for letter in letters:
             text = text.replace(letter, prefix + letter)

base_import_pdf_by_template/readme/ROADMAP.rst

@@ -1,5 +1,4 @@
 - Add operator in template lines (= or ilike)
-- Add support for selection fields as default value.
 - Simplify auto-detection (defining a text only to search the system should search the
   corresponding regular expression).
 - Allow compatibility with registration process created from email alias (for purchase

base_import_pdf_by_template/static/description/index.html

@@ -8,11 +8,10 @@
 
 /*
 :Author: David Goodger (goodger@python.org)
-:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $
+:Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $
 :Copyright: This stylesheet has been placed in the public domain.
 
 Default cascading style sheet for the HTML output of Docutils.
-Despite the name, some widely supported CSS2 features are used.
 
 See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to
 customize this style sheet.
@@ -275,7 +274,7 @@
   margin-left: 2em ;
   margin-right: 2em }
 
-pre.code .ln { color: gray; } /* line numbers */
+pre.code .ln { color: grey; } /* line numbers */
 pre.code, code { background-color: #eeeeee }
 pre.code .comment, code .comment { color: #5C6576 }
 pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
@@ -301,7 +300,7 @@
 span.pre {
   white-space: pre }
 
-span.problematic, pre.problematic {
+span.problematic {
   color: red }
 
 span.section-subtitle {
@@ -465,7 +464,6 @@ <h1><a class="toc-backref" href="#toc-entry-2">Usage</a></h1>
 <h1><a class="toc-backref" href="#toc-entry-3">Known issues / Roadmap</a></h1>
 <ul class="simple">
 <li>Add operator in template lines (= or ilike)</li>
-<li>Add support for selection fields as default value.</li>
 <li>Simplify auto-detection (defining a text only to search the system should search the
 corresponding regular expression).</li>
 <li>Allow compatibility with registration process created from email alias (for purchase
@@ -531,9 +529,7 @@ <h2><a class="toc-backref" href="#toc-entry-7">Contributors</a></h2>
 <div class="section" id="maintainers">
 <h2><a class="toc-backref" href="#toc-entry-8">Maintainers</a></h2>
 <p>This module is maintained by the OCA.</p>
-<a class="reference external image-reference" href="https://odoo-community.org">
-<img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
-</a>
+<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>

base_import_pdf_by_template/tests/test_base_import_pdf_by_template.py

@@ -87,6 +87,7 @@ def test_wizard_base_import_pdf_by_template_01(self):
         self.assertEqual(record.country_id.code, "ES")
         self.assertEqual(record.industry_id.name, "Food")
         self.assertEqual(record.user_id, self.user)
+        self.assertEqual(record.ref, "fixed-ref")
         self.assertEqual(len(record.child_ids), 3)
         child_1 = record.child_ids.filtered(lambda x: x.name == "Child 1")
         self.assertEqual(child_1.street, "Address 1")
@@ -123,6 +124,7 @@ def test_wizard_base_import_pdf_by_template_02(self):
         self.assertEqual(record.country_id.code, "ES")
         self.assertEqual(record.industry_id.name, "Food")
         self.assertEqual(record.user_id, self.user)
+        self.assertEqual(record.ref, "fixed-ref")
         self.assertEqual(len(record.child_ids), 3)
         child_1 = record.child_ids.filtered(lambda x: x.name == "Child 1")
         self.assertEqual(child_1.street, "Address 1")
@@ -133,7 +135,7 @@ def test_wizard_base_import_pdf_by_template_02(self):
         child_3 = record.child_ids.filtered(lambda x: x.name == "Child 3")
         self.assertEqual(child_3.street, "Address 3")
         self.assertEqual(child_3.country_id.code, "ES")
-        self.assertFalse(record.message_ids)
+        self.assertTrue(record.message_ids)  # Error message to set ref to childs
 
     def test_wizard_base_import_pdf_by_template_error(self):
         self.env.ref(

base_import_pdf_by_template/views/base_import_pdf_template_line_views.xml

@@ -51,10 +51,53 @@
                                 name="search_subfield_id"
                                 attrs="{'invisible': [('search_field_ttype', '!=', 'one2many')]}"
                             />
+                            <!-- Fixed value !-->
+                            <field
+                                name="fixed_value_char"
+                                string="Fixed value"
+                                attrs="{'invisible': ['|', ('value_type', '!=', 'fixed'),('field_ttype', '!=', 'char')]}"
+                            />
+                            <field
+                                name="fixed_value_date"
+                                string="Fixed value"
+                                attrs="{'invisible': ['|', ('value_type', '!=', 'fixed'),('field_ttype', '!=', 'date')]}"
+                            />
+                            <field
+                                name="fixed_value_datetime"
+                                string="Fixed value"
+                                attrs="{'invisible': ['|', ('value_type', '!=', 'fixed'),('field_ttype', '!=', 'datetime')]}"
+                            />
+                            <field
+                                name="fixed_value_float"
+                                string="Fixed value"
+                                attrs="{'invisible': ['|', ('value_type', '!=', 'fixed'),('field_ttype', '!=', 'float')]}"
+                            />
+                            <field
+                                name="fixed_value_html"
+                                string="Fixed value"
+                                attrs="{'invisible': ['|', ('value_type', '!=', 'fixed'),('field_ttype', '!=', 'html')]}"
+                            />
+                            <field
+                                name="fixed_value_integer"
+                                string="Fixed value"
+                                attrs="{'invisible': ['|', ('value_type', '!=', 'fixed'),('field_ttype', '!=', 'integer')]}"
+                            />
+                            <field
+                                name="fixed_value_selection"
+                                string="Fixed value"
+                                attrs="{'invisible': ['|', ('value_type', '!=', 'fixed'),('field_ttype', '!=', 'selection')]}"
+                            />
+                            <field
+                                name="fixed_value_text"
+                                string="Fixed value"
+                                attrs="{'invisible': ['|', ('value_type', '!=', 'fixed'),('field_ttype', '!=', 'text')]}"
+                            />
                             <field
                                 name="default_value"
+                                string="Fixed value"
                                 attrs="{'invisible': ['|', ('value_type', '=', 'fixed'),('field_relation', '=', False)]}"
                             />
+                            <!-- Fixed value !-->
                             <field
                                 name="log_distinct_value"
                                 attrs="{'invisible': ['|', ('field_id', '=', False),('value_type', '=', 'fixed')]}"

base_import_pdf_by_template/wizards/wizard_base_import_pdf_upload.py

@@ -194,7 +194,19 @@ def _process_form(self):
                     template.child_model
                 )
                 for field_name in list(child_fixed_values.keys()):
-                    setattr(line_form, field_name, child_fixed_values[field_name])
+                    child_field_value = child_fixed_values[field_name]
+                    try:
+                        setattr(line_form, field_name, child_field_value)
+                    except Exception:
+                        if not self.log_text:
+                            self.log_text = ""
+                        self.log_text += _(
+                            "Error to set %(field_name)s with value %(value)s"
+                        ) % {
+                            "field_name": field_name,
+                            "value": child_field_value,
+                        }
+
                 # et the values of any line
                 for field_name in list(line.keys()):
                     self.with_context(

test_base_import_pdf_by_template/demo/base_import_pdf_template.xml

@@ -82,6 +82,13 @@
         <field name="pattern">ES[0-9]{10}</field>
         <field name="value_type">variable</field>
     </record>
+    <record id="po_decathlon_line_origin" model="base.import.pdf.template.line">
+        <field name="template_id" ref="po_decathlon" />
+        <field name="related_model">header</field>
+        <field name="field_id" ref="purchase.field_purchase_order__origin" />
+        <field name="value_type">fixed</field>
+        <field name="fixed_value_char">fixed-origin</field>
+    </record>
     <record id="po_decathlon_line_product_id" model="base.import.pdf.template.line">
         <field name="template_id" ref="po_decathlon" />
         <field name="related_model">lines</field>
@@ -215,6 +222,16 @@
         <field name="value_type">fixed</field>
         <field name="fixed_value" ref="partner_tecnativa" />
     </record>
+    <record id="invoice_tecnativa_line_move_type" model="base.import.pdf.template.line">
+        <field name="template_id" ref="invoice_tecnativa" />
+        <field name="related_model">header</field>
+        <field name="field_id" ref="account.field_account_move__move_type" />
+        <field name="value_type">fixed</field>
+        <field
+            name="fixed_value_selection"
+            ref="account.selection__account_invoice_report__move_type__in_invoice"
+        />
+    </record>
     <record
         id="invoice_tecnativa_line_product_id"
         model="base.import.pdf.template.line"

test_base_import_pdf_by_template/tests/test_base_import_pdf_by_template.py

@@ -74,6 +74,7 @@ def test_purchase_order_decathlon(self):
         attachments = self._get_attachments(record)
         self.assertEqual(record.partner_id, self.partner_decathlon)
         self.assertEqual(record.partner_ref, "ES9812110233")
+        self.assertEqual(record.origin, "fixed-origin")
         self.assertIn(attachment, attachments)
         self.assertEqual(len(record.order_line), 5)
         self.assertEqual(sum(record.order_line.mapped("product_uom_qty")), 5)
@@ -88,12 +89,13 @@ def test_purchase_order_decathlon(self):
     def test_account_invoice_tecnativa(self):
         attachment = self._create_ir_attachment("account_invoice_tecnativa.pdf")
         wizard = self._create_wizard_base_import_pdf_upload("account.move", attachment)
-        # Similar context from Vendor invoices menu
-        wizard = wizard.with_context(**{"default_move_type": "in_invoice"})
+        # Similar context from Customer invoices menu
+        wizard = wizard.with_context(**{"default_move_type": "out_invoice"})
         res = wizard.action_process()
         self.assertEqual(res["res_model"], "account.move")
         record = self.env[res["res_model"]].browse(res["res_id"])
         attachments = self._get_attachments(record)
+        self.assertEqual(record.move_type, "in_invoice")
         self.assertEqual(record.partner_id, self.partner_tecnativa)
         self.assertIn(attachment, attachments)
         self.assertEqual(len(record.invoice_line_ids), 6)