Skip to content

Commit 5d22c1b

Browse files
committed
edi_oca: edi.conf cleanup tests
1 parent 963f766 commit 5d22c1b

File tree

2 files changed

+9
-72
lines changed

2 files changed

+9
-72
lines changed

edi_oca/tests/fake_components.py

+8-14
Original file line numberDiff line numberDiff line change
@@ -141,22 +141,16 @@ class FakeConfigurationListener(FakeComponentMixin):
141141
_inherit = "base.event.listener"
142142
_apply_on = ["edi.exchange.consumer.test"]
143143

144-
def on_record_write_configuration(self, record, fields=None, **kwargs):
144+
def on_record_write(self, record, fields=None, **kwargs):
145145
trigger = "on_record_write"
146-
if kwargs.get("vals", False):
147-
for rec in record:
148-
confs = record.edi_config_ids.edi_get_conf(trigger)
149-
for conf in confs:
150-
conf.edi_exec_snippet_do(rec, **kwargs)
146+
confs = record.edi_config_ids.edi_get_conf(trigger)
147+
for conf in confs:
148+
conf.edi_exec_snippet_do(record, **kwargs)
151149
return True
152150

153-
def on_record_create_configuration(self, record, fields=None, **kwargs):
151+
def on_record_create(self, record, fields=None, **kwargs):
154152
trigger = "on_record_create"
155-
val_list = kwargs.get("vals", False)
156-
if val_list:
157-
for rec, vals in zip(record, val_list):
158-
kwargs["vals"] = {rec.id: vals}
159-
confs = rec.edi_config_ids.edi_get_conf(trigger)
160-
for conf in confs:
161-
conf.edi_exec_snippet_do(rec, **kwargs)
153+
confs = record.edi_config_ids.edi_get_conf(trigger)
154+
for conf in confs:
155+
conf.edi_exec_snippet_do(record, **kwargs)
162156
return True

edi_oca/tests/fake_models.py

+1-58
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# @author: Enric Tobella
33
# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).
44

5-
from odoo import api, fields, models
5+
from odoo import fields, models
66

77

88
class EdiExchangeConsumerTest(models.Model):
@@ -22,60 +22,3 @@ class EdiExchangeConsumerTest(models.Model):
2222

2323
def _get_edi_exchange_record_name(self, exchange_record):
2424
return self.id
25-
26-
@api.model_create_multi
27-
def create(self, vals_list):
28-
records = super().create(vals_list)
29-
operation = "create"
30-
31-
new_records = self.browse()
32-
new_vals_list = []
33-
34-
for rec, vals in zip(records, vals_list):
35-
if not rec._edi_configuration_skip(operation):
36-
new_records |= rec
37-
new_vals_list.append(vals)
38-
39-
if new_records:
40-
self._event("on_record_create_configuration").notify(
41-
new_records,
42-
operation=operation,
43-
vals=new_vals_list,
44-
)
45-
return records
46-
47-
def write(self, vals):
48-
operation = "write"
49-
new_records = self.browse()
50-
51-
for rec in self:
52-
if not rec._edi_configuration_skip(operation):
53-
new_records |= rec
54-
55-
old_vals = {}
56-
for record in new_records:
57-
old_vals[record.id] = {field: record[field] for field in vals.keys()}
58-
59-
res = super().write(vals)
60-
61-
new_values = {}
62-
for record in new_records:
63-
new_values[record.id] = {field: record[field] for field in vals.keys()}
64-
65-
if new_values:
66-
self._event("on_record_write_configuration").notify(
67-
new_records,
68-
operation=operation,
69-
old_vals=old_vals,
70-
vals=new_values,
71-
)
72-
return res
73-
74-
def _edi_configuration_skip(self, operation):
75-
skip_reason = None
76-
if self.env.context.get("edi_skip_configuration"):
77-
skip_reason = "edi_skip_configuration ctx key found"
78-
# TODO: Add more skip cases
79-
if skip_reason:
80-
return True
81-
return False

0 commit comments

Comments
 (0)