[IMP] improve logging

sbidoul · sbidoul · commit fa18e1eb614e · 2023-12-20T16:59:29.000+01:00
Better use of logging so tools like sentry deduplicate the message.
diff --git a/base_delivery_carrier_label/models/stock_move_line.py b/base_delivery_carrier_label/models/stock_move_line.py
@@ -33,7 +33,7 @@ def get_weight(self):
             # if not defined we assume it's in kg
             if product.uom_id.id not in allowed:
                 _logger.warning(
-                    "Type conversion not implemented for product %s" % product.id
+                    "Type conversion not implemented for product %s", product.id
                 )
                 cant_calc_total = True
             # reserved_qty may be 0 if you don't set move line

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ def get_weight(self):`
`33`	`33`	`# if not defined we assume it's in kg`
`34`	`34`	`if product.uom_id.id not in allowed:`
`35`	`35`	`_logger.warning(`
`36`		`- "Type conversion not implemented for product %s" % product.id`
	`36`	`+ "Type conversion not implemented for product %s", product.id`
`37`	`37`	`)`
`38`	`38`	`cant_calc_total = True`
`39`	`39`	`# reserved_qty may be 0 if you don't set move line`