Skip to content

Commit bfa283b

Browse files
[IMP] add hook to get package vals for EDI
1 parent 8c792a4 commit bfa283b

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

delivery_roulier_geodis_fr/models/stock_picking.py

+4-5
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,9 @@
3434
class StockPicking(models.Model):
3535
_inherit = "stock.picking"
3636

37-
geodis_shippingid = fields.Char(help="Shipping Id in Geodis terminology", copy=False)
37+
geodis_shippingid = fields.Char(
38+
help="Shipping Id in Geodis terminology", copy=False
39+
)
3840

3941
def _geodis_fr_convert_address(self, partner):
4042
"""Truncate address and name to 35 chars."""
@@ -96,10 +98,7 @@ def _geodis_fr_prepare_edi(self):
9698
picking = self
9799

98100
packages = picking.package_ids
99-
parcels = [
100-
{"barcode": pack.geodis_cab, "weight": pack.shipping_weight or pack.weight}
101-
for pack in packages
102-
]
101+
parcels = [pack._get_edi_pack_vals() for pack in packages]
103102

104103
return {
105104
"product": picking.carrier_id.code,

delivery_roulier_geodis_fr/models/stock_quant_package.py

+7
Original file line numberDiff line numberDiff line change
@@ -39,3 +39,10 @@ def _geodis_fr_should_include_customs(self, picking):
3939

4040
def _geodis_fr_get_tracking_link(self):
4141
return self.parcel_tracking_uri
42+
43+
def _get_edi_pack_vals(self):
44+
self.ensure_one()
45+
return {
46+
"barcode": self.geodis_cab,
47+
"weight": self.shipping_weight or self.weight,
48+
}

0 commit comments

Comments
 (0)