Skip to content

Commit 9b07dd9

Browse files
florian-dacostayankinmax
authored andcommittedJul 12, 2024
[FIX] delivery_roulier : get_tracking_link should return an url instead of a list of urls
1 parent 881d2ab commit 9b07dd9

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed
 

‎delivery_roulier/models/delivery_carrier.py

+8-11
Original file line numberDiff line numberDiff line change
@@ -31,17 +31,14 @@ def cancel_shipment(self, pickings):
3131
# is on picking. An we could have multiple urls for 1 picking, if there
3232
# are multiple package...
3333
# Maybe we will merge all this in future versions
34-
def get_tracking_link(self, pickings):
35-
if self._is_roulier():
36-
trackings = []
37-
for picking in pickings:
38-
packages = picking.package_ids
39-
first_package = packages and packages[0]
40-
if first_package:
41-
trackings.append(first_package._get_tracking_link())
42-
return trackings
43-
else:
44-
return super().get_tracking_link(pickings)
34+
def get_tracking_link(self, picking):
35+
if not self._is_roulier():
36+
return super().get_tracking_link(picking)
37+
packages = picking.package_ids
38+
if not packages:
39+
return ""
40+
first_package = packages[0]
41+
return first_package._get_tracking_link()
4542

4643
def rate_shipment(self, order):
4744
res = super().rate_shipment(order)

0 commit comments

Comments
 (0)