Skip to content

Commit 7ced30f

Browse files
update delivery_schenker
1 parent e81b8cf commit 7ced30f

File tree

4 files changed

+14
-11
lines changed

4 files changed

+14
-11
lines changed

delivery_schenker/README.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Delivery Schenker
77
!! This file is generated by oca-gen-addon-readme !!
88
!! changes will be overwritten. !!
99
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
10-
!! source digest: sha256:d4bb07ec262f28ebf12722c6b529cee813a3022a5f73e4010970171abe752de3
10+
!! source digest: sha256:4f0a596c6bac6914af4ecc42714c6f39e446a09b4404bca36651af0fd55792ff
1111
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
1212
1313
.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png

delivery_schenker/__manifest__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"license": "AGPL-3",
1212
"application": False,
1313
"installable": True,
14-
"depends": ["delivery_package_number", "delivery_state"],
14+
"depends": ["delivery_state"],
1515
"external_dependencies": {"python": ["zeep"]},
1616
"data": [
1717
"views/delivery_schenker_view.xml",

delivery_schenker/models/delivery_carrier.py

+11-8
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,7 @@ def _schenker_shipping_information_with_packages(self, picking):
404404
for package in picking.package_ids
405405
]
406406

407-
def _schenker_shipping_information_without_packages_volume(self, picking):
407+
def _schenker_shipping_information_without_packages_volume(self, move_lines):
408408
# Obviously products should be well configured. This parameter is mandatory.
409409
return sum(
410410
[
@@ -414,13 +414,16 @@ def _schenker_shipping_information_without_packages_volume(self, picking):
414414
ml.qty_done, ml.product_id.uom_id
415415
),
416416
)
417-
for ml in picking.move_line_ids
417+
for ml in move_lines
418418
if not ml.result_package_id
419419
]
420420
)
421421

422422
def _schenker_shipping_information_without_packages(self, picking):
423-
if all(move_line.result_package_id for move_line in picking.move_line_ids):
423+
move_lines_without_package = picking.move_line_ids.filtered(
424+
lambda ml: not ml.result_package_id
425+
)
426+
if not move_lines_without_package:
424427
return []
425428
weight = picking.shipping_weight or picking.weight
426429
return [
@@ -429,15 +432,15 @@ def _schenker_shipping_information_without_packages(self, picking):
429432
"dgr": False,
430433
"cargoDesc": picking.name,
431434
# For a more complex solution use packaging properly
432-
"grossWeight": self._schenker_shipping_information_round_weight(
433-
weight / picking.number_of_packages
434-
),
435+
"grossWeight": self._schenker_shipping_information_round_weight(weight),
435436
"volume": self._schenker_shipping_information_round_volume(
436-
self._schenker_shipping_information_without_packages_volume(picking)
437+
self._schenker_shipping_information_without_packages_volume(
438+
move_lines_without_package
439+
)
437440
),
438441
"packageType": self.schenker_default_packaging_id.shipper_package_code,
439442
"stackable": self.schenker_default_packaging_id.schenker_stackable,
440-
"pieces": picking.number_of_packages,
443+
"pieces": 1,
441444
}
442445
]
443446

delivery_schenker/static/description/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ <h1 class="title">Delivery Schenker</h1>
367367
!! This file is generated by oca-gen-addon-readme !!
368368
!! changes will be overwritten. !!
369369
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
370-
!! source digest: sha256:d4bb07ec262f28ebf12722c6b529cee813a3022a5f73e4010970171abe752de3
370+
!! source digest: sha256:4f0a596c6bac6914af4ecc42714c6f39e446a09b4404bca36651af0fd55792ff
371371
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
372372
<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/delivery-carrier/tree/14.0/delivery_schenker"><img alt="OCA/delivery-carrier" src="https://img.shields.io/badge/github-OCA%2Fdelivery--carrier-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/delivery-carrier-14-0/delivery-carrier-14-0-delivery_schenker"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/delivery-carrier&amp;target_branch=14.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
373373
<p>This module links the <a class="reference external" href="https://www.dbschenker.com">DB Schenker</a> booking and tracking

0 commit comments

Comments
 (0)