[MIG] delivery_package_type_number_parcels: Migration to 18.0

Author: BhaveshHeliconia

delivery_package_type_number_parcels/README.rst

@@ -35,6 +35,10 @@ if this latter is overkill.
 
 This field is set manually by the user on package type.
 
+The number of parcels is also displayed in the delivery package wizard
+when selecting a package type, giving users immediate visibility of the
+parcel count during the delivery process.
+
 **Table of contents**
 
 .. contents::
@@ -62,6 +66,9 @@ Contributors
 ------------
 
 - Hughes Damry <hughes.damry@acsone.eu>
+- `Heliconia Solutions Pvt. Ltd. <https://www.heliconia.io>`__
+
+  - Bhavesh Heliconia
 
 Maintainers
 -----------

delivery_package_type_number_parcels/__manifest__.py

@@ -4,11 +4,11 @@
 {
     "name": "Delivery Package Type Number Parcels",
     "summary": "Number of parcels in a package type",
-    "version": "16.0.1.0.2",
+    "version": "18.0.1.0.0",
     "license": "AGPL-3",
     "author": "ACSONE SA/NV,Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/delivery-carrier",
-    "depends": ["delivery"],
+    "depends": ["stock_delivery"],
     "data": [
         "views/stock_quant_package_views.xml",
         "views/stock_package_type_views.xml",

delivery_package_type_number_parcels/readme/CONTRIBUTORS.md

@@ -1 +1,3 @@
 - Hughes Damry \<<hughes.damry@acsone.eu>\>
+- [Heliconia Solutions Pvt. Ltd.](https://www.heliconia.io)
+  - Bhavesh Heliconia

delivery_package_type_number_parcels/readme/DESCRIPTION.md

@@ -1,6 +1,11 @@
-This module adds the number_of_parcels on package type and its related
-on package. As so it gives a simple way to have the number of
-pieces/boxes of the package type without playing with the package levels
-if this latter is overkill.
+This module adds the number_of_parcels on package type
+and its related on package. As so it gives a simple way
+to have the number of pieces/boxes of the package type
+without playing with the package levels if this latter
+is overkill.
 
 This field is set manually by the user on package type.
+
+The number of parcels is also displayed in the delivery package
+wizard when selecting a package type, giving users immediate
+visibility of the parcel count during the delivery process.

delivery_package_type_number_parcels/static/description/index.html

@@ -375,6 +375,9 @@ <h1 class="title">Delivery Package Type Number Parcels</h1>
 pieces/boxes of the package type without playing with the package levels
 if this latter is overkill.</p>
 <p>This field is set manually by the user on package type.</p>
+<p>The number of parcels is also displayed in the delivery package wizard
+when selecting a package type, giving users immediate visibility of the
+parcel count during the delivery process.</p>
 <p><strong>Table of contents</strong></p>
 <div class="contents local topic" id="contents">
 <ul class="simple">
@@ -407,6 +410,10 @@ <h2><a class="toc-backref" href="#toc-entry-3">Authors</a></h2>
 <h2><a class="toc-backref" href="#toc-entry-4">Contributors</a></h2>
 <ul class="simple">
 <li>Hughes Damry &lt;<a class="reference external" href="mailto:hughes.damry&#64;acsone.eu">hughes.damry&#64;acsone.eu</a>&gt;</li>
+<li><a class="reference external" href="https://www.heliconia.io">Heliconia Solutions Pvt. Ltd.</a><ul>
+<li>Bhavesh Heliconia</li>
+</ul>
+</li>
 </ul>
 </div>
 <div class="section" id="maintainers">

delivery_package_type_number_parcels/tests/test_package_type_number_parcels.py

@@ -13,8 +13,9 @@ def setUpClass(cls):
         cls.product_test = cls.env["product.product"].create(
             {
                 "name": "Product TEST",
-                "type": "product",
+                "type": "consu",
                 "weight": 0.1,
+                "is_storable": True,
                 "uom_id": cls.uom_kg.id,
                 "uom_po_id": cls.uom_kg.id,
             }
@@ -65,7 +66,7 @@ def test_put_in_pack_choose_carrier_wizard(self):
                 "product_id": self.product_test.id,
                 "product_uom_id": self.uom_kg.id,
                 "picking_id": picking_ship.id,
-                "qty_done": 5,
+                "quantity": 5,
                 "location_id": self.stock_location.id,
                 "location_dest_id": self.customer_location.id,
             }
@@ -76,7 +77,7 @@ def test_put_in_pack_choose_carrier_wizard(self):
         # We make sure the correct action was returned
         self.assertEqual(pack_action_model, "choose.delivery.package")
         # check there is no package yet for the picking
-        self.assertEqual(len(picking_ship.package_ids), 0)
+        self.assertEqual(len(picking_ship.package_level_ids), 0)
         # We instanciate the wizard with the context of the action
         pack_wiz = (
             self.env["choose.delivery.package"]
@@ -91,21 +92,23 @@ def test_put_in_pack_choose_carrier_wizard(self):
         )
         pack_wiz.action_put_in_pack()
         # check that one package has been created with the same number of packages
-        self.assertEqual(len(picking_ship.package_ids), 1)
-        package1 = picking_ship.package_ids[0]
+        self.assertEqual(len(picking_ship.package_level_ids), 1)
+        package1 = picking_ship.package_level_ids[0]
         # check the related number_of_parcels is ok in the package
         self.assertEqual(
-            package1.number_of_parcels, self.package_type.number_of_parcels
+            package1.package_id.number_of_parcels, self.package_type.number_of_parcels
         )
         return package1
 
     def test_manual_number_of_parcels(self):
         package = self.test_put_in_pack_choose_carrier_wizard()
-        self.assertEqual(package.number_of_parcels, 7)
+        self.assertEqual(package.package_id.number_of_parcels, 7)
         self.package_type.number_of_parcels = 8
-        self.assertEqual(package.number_of_parcels, 7)
-        package.number_of_parcels = 9
-        self.assertEqual(package.number_of_parcels, 9)
+        self.assertEqual(package.package_id.number_of_parcels, 7)
+        package.package_id.number_of_parcels = 9
+        self.assertEqual(package.package_id.number_of_parcels, 9)
         self.assertEqual(self.package_type.number_of_parcels, 8)
-        package.package_type_id = self.package_type.copy({"number_of_parcels": 10})
-        self.assertEqual(package.number_of_parcels, 10)
+        package.package_id.package_type_id = self.package_type.copy(
+            {"number_of_parcels": 10}
+        )
+        self.assertEqual(package.package_id.number_of_parcels, 10)

delivery_package_type_number_parcels/views/stock_package_type_views.xml

@@ -26,7 +26,7 @@
                 <field
                     name="number_of_parcels"
                     optional="show"
-                    attrs="{'invisible': [('number_of_parcels', '=', 0)]}"
+                    invisible="number_of_parcels == 0"
                 />
             </xpath>
         </field>

delivery_package_type_number_parcels/views/stock_quant_package_views.xml

@@ -10,10 +10,7 @@
         <field name="inherit_id" ref="stock.view_quant_package_form" />
         <field name="arch" type="xml">
             <field name="package_type_id" position="after">
-                <field
-                    name="number_of_parcels"
-                    attrs="{'invisible': [('number_of_parcels', '=', 0)]}"
-                />
+                <field name="number_of_parcels" invisible="number_of_parcels == 0" />
             </field>
         </field>
     </record>
@@ -29,7 +26,7 @@
                 <field
                     name="number_of_parcels"
                     optional="show"
-                    attrs="{'invisible': [('number_of_parcels', '=', 0)]}"
+                    invisible="number_of_parcels == 0"
                 />
             </field>
         </field>

delivery_package_type_number_parcels/wizards/choose_delivery_package_views.xml

@@ -5,13 +5,13 @@
             name="name"
         >choose.delivery.package.form (in delivery_package_type_number_parcels)</field>
         <field name="model">choose.delivery.package</field>
-        <field name="inherit_id" ref="delivery.choose_delivery_package_view_form" />
+        <field
+            name="inherit_id"
+            ref="stock_delivery.choose_delivery_package_view_form"
+        />
         <field name="arch" type="xml">
             <field name="delivery_package_type_id" position="after">
-                <field
-                    name="number_of_parcels"
-                    attrs="{'invisible': [('number_of_parcels', '=', 0)]}"
-                />
+                <field name="number_of_parcels" invisible="number_of_parcels == 0" />
             </field>
         </field>
     </record>