[MIG] delivery_package_number: Migration to 18.0

Author: CarlosRoca13

delivery_package_number/__manifest__.py

@@ -3,7 +3,7 @@
 {
     "name": "Stock Picking Package Number",
     "summary": "Set or compute number of packages for a picking",
-    "version": "17.0.1.0.0",
+    "version": "18.0.1.0.0",
     "category": "Delivery",
     "website": "https://github.com/OCA/delivery-carrier",
     "author": "Tecnativa, Odoo Community Association (OCA)",

delivery_package_number/models/stock_picking.py

@@ -18,11 +18,12 @@ class StockPicking(models.Model):
     )
     ask_number_of_packages = fields.Boolean(compute="_compute_ask_number_of_packages")
 
-    @api.depends("package_ids")
+    @api.depends('move_line_ids', 'move_line_ids.result_package_id')
     def _compute_number_of_packages(self):
         for picking in self:
-            if picking.package_ids:
-                picking.number_of_packages = len(picking.package_ids)
+            packages = picking.move_line_ids.result_package_id
+            if packages:
+                picking.number_of_packages = len(packages)
 
     def _action_generate_number_of_packages_wizard(self):
         view = self.env.ref("delivery_package_number.view_number_package_validate")
@@ -44,7 +45,7 @@ def _compute_ask_number_of_packages(self):
         for picking in self:
             picking.ask_number_of_packages = bool(
                 picking.carrier_id
-                and not picking.package_ids
+                and not picking.move_line_ids.result_package_id
                 or picking.picking_type_id.force_set_number_of_packages
             )
 

delivery_package_number/reports/report_package_number.xml

@@ -4,7 +4,7 @@
         <t t-call="web.basic_layout">
             <t
                 t-set="move_ids"
-                t-value="doc.move_ids._rollup_move_dests({doc.move_ids[:1].id})"
+                t-value="doc.move_ids._rollup_move_dests()"
             />
             <t
                 t-set="dest_picking"

delivery_package_number/views/stock_picking_type_views.xml

@@ -4,7 +4,7 @@
         <field name="model">stock.picking.type</field>
         <field name="inherit_id" ref="stock.view_picking_type_form" />
         <field name="arch" type="xml">
-            <xpath expr="//field[@name='default_location_src_id']/.." position="after">
+            <xpath expr="//group[@name='locations']" position="after">
                 <group string="Number of packages">
                     <field name="force_set_number_of_packages" />
                     <field name="report_number_of_packages" />

delivery_package_number/views/stock_picking_views.xml

@@ -8,7 +8,6 @@
         />
         <field name="arch" type="xml">
             <xpath expr="//group[@name='carrier_data']" position="inside">
-                <field name="package_ids" invisible="1" />
                 <field name="number_of_packages" readonly="state == 'done'" />
             </xpath>
         </field>

delivery_package_number/wizard/stock_number_package_validate_wiz_view.xml

@@ -17,15 +17,15 @@
                     invisible="not stock_number_package_validation_line_ids"
                     nolabel="1"
                 >
-                    <tree create="0" delete="0" editable="1">
+                    <list create="0" delete="0" editable="bottom">
                         <field
                             name="picking_id"
                             options="{'no_open': True}"
                             readonly="1"
                             force_save="1"
                         />
                         <field name="number_of_packages" />
-                    </tree>
+                    </list>
                 </field>
                 <footer>
                     <button