Skip to content

Commit 225eaa1

Browse files
florian-dacostayankinmax
authored andcommitted
[FIX] delivery_roulier : get_tracking_link should return an url instead of a list of urls
1 parent e84d132 commit 225eaa1

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

delivery_roulier/models/delivery_carrier.py

+8-11
Original file line numberDiff line numberDiff line change
@@ -37,17 +37,14 @@ def cancel_shipment(self, pickings):
3737
# is on picking. An we could have multiple urls for 1 picking, if there
3838
# are multiple package...
3939
# Maybe we will merge all this in future versions
40-
def get_tracking_link(self, pickings):
41-
if self._is_roulier():
42-
trackings = []
43-
for picking in pickings:
44-
packages = picking.package_ids
45-
first_package = packages and packages[0]
46-
if first_package:
47-
trackings.append(first_package._get_tracking_link())
48-
return trackings
49-
else:
50-
return super().get_tracking_link(pickings)
40+
def get_tracking_link(self, picking):
41+
if not self._is_roulier():
42+
return super().get_tracking_link(picking)
43+
packages = picking.package_ids
44+
if not packages:
45+
return ""
46+
first_package = packages[0]
47+
return first_package._get_tracking_link()
5148

5249
def rate_shipment(self, order):
5350
res = super().rate_shipment(order)

0 commit comments

Comments
 (0)