FIX PRECOMMIT

Author: Tisho99

delivery_ups_oca/__manifest__.py

@@ -8,7 +8,8 @@
     "development_status": "Beta",
     "category": "Delivery",
     "website": "https://github.com/OCA/delivery-carrier",
-    "author": "Hunki Enterprises BV, Tecnativa, ForgeFlow, Odoo Community Association (OCA)",
+    "author": """Hunki Enterprises BV, Tecnativa, ForgeFlow,
+             Odoo Community Association (OCA)""",
     "license": "AGPL-3",
     "excludes": ["delivery_ups"],
     "depends": [

delivery_ups_oca/models/delivery_carrier.py

@@ -156,11 +156,7 @@ def _create_ups_label(self, picking, labels):
         val_list = []
         for label in labels:
             format_code = label["format_code"].upper()
-            attachment_name = "%s-%s.%s" % (
-                label["tracking_ref"],
-                format_code,
-                format_code,
-            )
+            attachment_name = f"{label['tracking_ref']}-{format_code}.{format_code}"
             val_list.append(
                 self._prepare_ups_label_attachment(
                     picking,

delivery_ups_oca/models/ups_request.py

@@ -36,8 +36,8 @@ def __init__(self, carrier):
     def _raise_for_status(self, status, skip_errors=True):
         errors = status.get("response", {}).get("errors")
         if errors:
-            msg = _("Sending to UPS: %s") % (
-                "\n".join("%(code)s %(message)s" % error for error in errors),
+            msg = _("Sending to UPS: {}").format(
+                "\n".join("{code} {message}".format(**error) for error in errors),
             )
             if skip_errors:
                 _logger.info(msg)
@@ -55,7 +55,8 @@ def _get_new_token(self):
         if not (self.client_id and self.client_secret):
             raise UserError(
                 _(
-                    "Both Client ID and Client Secret must be set in UPS delivery carriers."
+                    "Both Client ID and Client Secret"
+                    " must be set in UPS delivery carriers."
                 )
             )
         url = "%s/security/v1/oauth/token" % self.url
@@ -175,7 +176,7 @@ def _prepare_create_shipping(self, picking):
             )
             for i in range(0, picking.number_of_packages):
                 package_item = package_info
-                package_name = "%s (%s)" % (picking.name, i + 1)
+                package_name = f"{picking.name} ({i+1})"
                 package_item["Description"] = package_name
                 package_item["NumOfPieces"] = "1"
                 package_item["Packaging"]["Description"] = package_name
@@ -363,7 +364,7 @@ def tracking_state_update(self, picking):
             "M": "in_transit",
         }
         status = self._process_reply(
-            url="%s/api/track/v1/details/%s" % (self.url, picking.carrier_tracking_ref),
+            url=f"{self.url}/api/track/v1/details/{picking.carrier_tracking_ref}",
             method="get",
             headers_extra={
                 "transId": f"{datetime.datetime.now().timestamp()}",
@@ -396,9 +397,9 @@ def tracking_state_update(self, picking):
             else:
                 for warning in shipment.get("warnings"):
                     states_list.append(
-                        _("{} - Warning: {}").format(
-                            datetime.datetime.now().strftime("%Y-%m-%d %H:%M:%S"),
-                            warning.get("message"),
+                        _("{date} - Warning: {warn}").format(
+                            date=datetime.datetime.now().strftime("%Y-%m-%d %H:%M:%S"),
+                            warn=warning.get("message"),
                         )
                     )
 

delivery_ups_oca/tests/test_delivery_ups.py

@@ -70,7 +70,7 @@ def _create_sale_order(self):
         sale = order_form.save()
         delivery_wizard = Form(
             self.env["choose.delivery.carrier"].with_context(
-                {"default_order_id": sale.id, "default_carrier_id": self.carrier.id}
+                **{"default_order_id": sale.id, "default_carrier_id": self.carrier.id}
             )
         ).save()
         delivery_wizard.button_confirm()