[14.0][FIX] delivery_carrier_label_batch: new environmenent execution ordering leads to false behavior on labels regeneration

Author: Hadrien Huvelle

delivery_carrier_label_batch/models/stock_batch_picking.py

@@ -1,6 +1,8 @@
 # Copyright 2013-2019 Camptocamp SA
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl)
-from odoo import _, api, fields, models
+from contextlib import contextmanager
+
+from odoo import _, api, fields, models, registry, tools
 
 
 class StockBatchPicking(models.Model):
@@ -36,6 +38,19 @@ def _get_options_to_add(self, carrier=None):
         options = carrier.available_option_ids
         return options.filtered(lambda rec: rec.mandatory or rec.by_default)
 
+    @contextmanager
+    @api.model
+    def _do_in_new_env(self):
+        # Be careful with the test_enable flag, as this behavior won't be the same on tests.
+        # If in test mode, there won't be any concurrent threading.
+        if tools.config["test_enable"]:
+            yield self.env
+            return
+
+        with api.Environment.manage():
+            with registry(self.env.cr.dbname).cursor() as new_cr:
+                yield api.Environment(new_cr, self.env.uid, self.env.context)
+
     @api.onchange("carrier_id")
     def carrier_id_change(self):
         """Inherit this method in your module"""
@@ -106,10 +121,11 @@ def create(self, values):
         return super().create(values)
 
     def purge_tracking_references(self):
-        """Purge tracking for each picking and destination package"""
         for batch in self:
             move_lines = batch.move_line_ids
-            packs = move_lines.result_package_id.filtered(lambda p: p.parcel_tracking)
+            packs = move_lines.result_package_id.filtered(
+                lambda p: p.parcel_tracking
+            )
             if packs:
                 packs.write({"parcel_tracking": False})
             pickings = self.env["stock.picking"].search(
@@ -120,3 +136,17 @@ def purge_tracking_references(self):
             )
             if pickings:
                 pickings.write({"carrier_tracking_ref": False})
+
+    #WARNING ! Do not call this function unless you know what you do ;-)
+    def purge_tracking_references_in_new_env(self):
+        """Purge tracking for each picking and destination package"""
+        with self._do_in_new_env() as new_env:
+
+            # labels = new_env['shipping.label']
+            new_self = self.with_env(new_env)
+            new_self.purge_tracking_references()
+            # may not be necessary but we leave it here for now
+            self.env.cr.commit()
+
+
+

delivery_carrier_label_batch/wizard/generate_labels.py

@@ -62,6 +62,8 @@ def _find_pack_label(self, pack):
     @contextmanager
     @api.model
     def _do_in_new_env(self):
+        # Be careful with the test_enable flag, as this behavior won't be the same on tests.
+        # If in test mode, there won't be any concurrent threading.
         if tools.config["test_enable"]:
             yield self.env
             return
@@ -252,7 +254,7 @@ def action_generate_labels(self):
                 lambda rec: rec.id not in already_generated_ids
             )
         else:
-            to_generate.purge_tracking_references()
+            to_generate.purge_tracking_references_in_new_env()
 
         for batch in to_generate:
             labels = self._get_all_files(batch)