[MIG] account_journal_lock_date: Migration to 18.0

Author: StefanRijnhart

account_journal_lock_date/__manifest__.py

@@ -4,7 +4,7 @@
 {
     "name": "Account Journal Lock Date",
     "summary": "Lock each journal independently",
-    "version": "17.0.1.0.0",
+    "version": "18.0.1.0.0",
     "license": "AGPL-3",
     "author": "ACSONE SA/NV, Tecnativa, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/account-financial-tools",

account_journal_lock_date/models/account_move.py

@@ -9,14 +9,14 @@
 class AccountMove(models.Model):
     _inherit = "account.move"
 
-    def _check_fiscalyear_lock_date(self):
-        res = super()._check_fiscalyear_lock_date()
+    def _check_fiscal_lock_dates(self):
+        res = super()._check_fiscal_lock_dates()
         if self.env.context.get("bypass_journal_lock_date"):
             return res
 
         date_min = fields.date.min
         for move in self:
-            if self.user_has_groups("account.group_account_manager"):
+            if self.env.user.has_group("account.group_account_manager"):
                 lock_date = move.journal_id.fiscalyear_lock_date or date_min
             else:
                 lock_date = max(
@@ -25,7 +25,7 @@ def _check_fiscalyear_lock_date(self):
                 )
             if move.date <= lock_date:
                 lock_date = format_date(self.env, lock_date)
-                if self.user_has_groups("account.group_account_manager"):
+                if self.env.user.has_group("account.group_account_manager"):
                     message = _(
                         "You cannot add/modify entries for the journal '%(journal)s' "
                         "prior to and inclusive of the lock date %(journal_date)s"

account_journal_lock_date/tests/test_journal_lock_date.py

@@ -4,54 +4,49 @@
 from datetime import date, timedelta
 
 from odoo.exceptions import UserError
+from odoo.fields import Command
 from odoo.tests import tagged
 
 from odoo.addons.account.tests import common
 
 
 @tagged("post_install", "-at_install")
 class TestJournalLockDate(common.AccountTestInvoicingCommon):
-    def setUp(self):
-        super().setUp()
-        self.account_move_obj = self.env["account.move"]
-        self.account_move_line_obj = self.env["account.move.line"]
-        self.company_id = self.ref("base.main_company")
-        self.partner = self.browse_ref("base.res_partner_12")
-
-        self.account = self.company_data["default_account_revenue"]
-        self.account2 = self.company_data["default_account_expense"]
-        self.journal = self.company_data["default_journal_bank"]
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls.account_move_obj = cls.env["account.move"]
+        cls.account_move_line_obj = cls.env["account.move.line"]
+        cls.account = cls.company_data["default_account_revenue"]
+        cls.account2 = cls.company_data["default_account_expense"]
+        cls.journal = cls.company_data["default_journal_bank"]
 
         # create a move and post it
-        self.move = self.account_move_obj.create(
+        cls.move = cls.account_move_obj.create(
             {
                 "date": date.today(),
-                "journal_id": self.journal.id,
+                "journal_id": cls.journal.id,
                 "line_ids": [
-                    (
-                        0,
-                        0,
+                    Command.create(
                         {
-                            "account_id": self.account.id,
+                            "account_id": cls.account.id,
                             "credit": 1000.0,
                             "name": "Credit line",
                         },
                     ),
-                    (
-                        0,
-                        0,
+                    Command.create(
                         {
-                            "account_id": self.account2.id,
+                            "account_id": cls.account2.id,
                             "debit": 1000.0,
                             "name": "Debit line",
                         },
                     ),
                 ],
             }
         )
-        self.move.action_post()
+        cls.move.action_post()
         # lock journal, set 'Lock Date for Non-Advisers'
-        self.journal.period_lock_date = date.today() + timedelta(days=2)
+        cls.journal.period_lock_date = date.today() + timedelta(days=2)
 
     def test_journal_lock_date(self):
         self.env.user.write({"groups_id": [(3, self.ref("base.group_system"))]})
@@ -77,18 +72,14 @@ def test_journal_lock_date(self):
                 "date": self.journal.period_lock_date + timedelta(days=3),
                 "journal_id": self.journal.id,
                 "line_ids": [
-                    (
-                        0,
-                        0,
+                    Command.create(
                         {
                             "account_id": self.account.id,
                             "credit": 1000.0,
                             "name": "Credit line",
                         },
                     ),
-                    (
-                        0,
-                        0,
+                    Command.create(
                         {
                             "account_id": self.account2.id,
                             "debit": 1000.0,
@@ -108,18 +99,14 @@ def test_journal_lock_date(self):
                 "date": self.journal.period_lock_date,
                 "journal_id": self.journal.id,
                 "line_ids": [
-                    (
-                        0,
-                        0,
+                    Command.create(
                         {
                             "account_id": self.account.id,
                             "credit": 1000.0,
                             "name": "Credit line",
                         },
                     ),
-                    (
-                        0,
-                        0,
+                    Command.create(
                         {
                             "account_id": self.account2.id,
                             "debit": 1000.0,
@@ -166,18 +153,14 @@ def test_journal_lock_date_adviser(self):
                 "date": self.journal.period_lock_date,
                 "journal_id": self.journal.id,
                 "line_ids": [
-                    (
-                        0,
-                        0,
+                    Command.create(
                         {
                             "account_id": self.account.id,
                             "credit": 1000.0,
                             "name": "Credit line",
                         },
                     ),
-                    (
-                        0,
-                        0,
+                    Command.create(
                         {
                             "account_id": self.account2.id,
                             "debit": 1000.0,