kitty: Test Failure with Fish integration in v.4.0.0

[jfietz]

Nixpkgs version

• Unstable (25.05)

Describe the bug

Here's the upstream bug: kovidgoyal/kitty#8385

The failure is in the test test_fish_integration (kitty_tests.shell_integration.ShellIntegration.test_fish_integration)

error.log

Steps to reproduce

Upgrade to latest unstable with fish in version 4.0.0 and try to build kitty with it.

Expected behaviour

Build successfully

Relevant log output

[...]
test_font_selection (kitty_tests.fonts.Selection.test_font_selection) ... ok
test_bash_integration (kitty_tests.shell_integration.ShellIntegration.test_bash_integration) ... ok
test_fish_integration (kitty_tests.shell_integration.ShellIntegration.test_fish_integration) ... ERROR
test_zsh_integration (kitty_tests.shell_integration.ShellIntegration.test_zsh_integration) ... ok
test_bash_integration (kitty_tests.shell_integration.ShellIntegrationWithKitten.test_bash_integration) ... ok
test_fish_integration (kitty_tests.shell_integration.ShellIntegrationWithKitten.test_fish_integration) ... ERROR
test_zsh_integration (kitty_tests.shell_integration.ShellIntegrationWithKitten.test_zsh_integration) ... ok
test_os_window_size_calculation (kitty_tests.glfw.TestGLFW.test_os_window_size_calculation) ... ok
test_utf_8_strndup (kitty_tests.glfw.TestGLFW.test_utf_8_strndup) ... skipped 'Skipping test on macOS because glfw-cocoa.so is not built with backend_utils'

======================================================================
ERROR: test_fish_integration (kitty_tests.shell_integration.ShellIntegration.test_fish_integration)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/private/tmp/nix-build-kitty-0.39.1.drv-1/source/kitty/launcher/kitty.app/Contents/MacOS/../../../../../kitty_tests/shell_integration.py", line 206, in test_fish_integration
    pty.wait_till(lambda: pty.screen.last_reported_cwd.decode().endswith(q))
    cmd = 'string match -q -- "*/private/tmp/nix-build-kitty-0.39.1.drv-1/source/shell-integration*" "$XDG_DATA_DIRS" || echo "XDD_OK"'
    completions_dir = '/private/tmp/nix-build-kitty-0.39.1.drv-1/source/shell-integration/fish/vendor_completions.d'
    fish_prompt = 'left>'
    pty = <kitty_tests.PTY object at 0x1108b2840>
    q = '/private/tmp/nix-build-kitty-0.39.1.drv-1/tmpdp67whb0/testing-cwd-notification-🐱'
    right_prompt = '<right'
    self = <kitty_tests.shell_integration.ShellIntegration testMethod=test_fish_integration>
  File "/private/tmp/nix-build-kitty-0.39.1.drv-1/source/kitty/launcher/kitty.app/Contents/MacOS/../../../../../kitty_tests/__init__.py", line 404, in wait_till
    raise TimeoutError(f'Timed out: {msg}. Screen contents: \n {repr(self.screen_contents())}')
    end_time = 468375.37713
    msg = 'The condition was not met'
    q = <function ShellIntegration.test_fish_integration.<locals>.<lambda> at 0x107c41d00>
    self = <kitty_tests.PTY object at 0x1108b2840>
    timeout = 10
    timeout_msg = None
TimeoutError: Timed out: The condition was not met. Screen contents: 
 'left>string match -q -- "*/private/tmp/nix-build-kitty-0.39.1.drv-1/source/shell-integration*" "$XDG_DATA_DIRS" || echo "XDD_OK"                                              <right\nXDD_OK\nleft>cd /private/tmp/nix-build-kitty-0.>

======================================================================
ERROR: test_fish_integration (kitty_tests.shell_integration.ShellIntegrationWithKitten.test_fish_integration)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/private/tmp/nix-build-kitty-0.39.1.drv-1/source/kitty/launcher/kitty.app/Contents/MacOS/../../../../../kitty_tests/shell_integration.py", line 206, in test_fish_integration
    pty.wait_till(lambda: pty.screen.last_reported_cwd.decode().endswith(q))
    cmd = 'string match -q -- "*/private/tmp/nix-build-kitty-0.39.1.drv-1/source/shell-integration*" "$XDG_DATA_DIRS" || echo "XDD_OK"'
    completions_dir = '/private/tmp/nix-build-kitty-0.39.1.drv-1/source/shell-integration/fish/vendor_completions.d'
    fish_prompt = 'left>'
    pty = <kitty_tests.PTY object at 0x34ac277d0>
    q = '/private/tmp/nix-build-kitty-0.39.1.drv-1/tmpg9klkwfq/testing-cwd-notification-🐱'
    right_prompt = '<right'
    self = <kitty_tests.shell_integration.ShellIntegrationWithKitten testMethod=test_fish_integration>
  File "/private/tmp/nix-build-kitty-0.39.1.drv-1/source/kitty/launcher/kitty.app/Contents/MacOS/../../../../../kitty_tests/__init__.py", line 404, in wait_till
    raise TimeoutError(f'Timed out: {msg}. Screen contents: \n {repr(self.screen_contents())}')
    end_time = 468386.856846208
    msg = 'The condition was not met'
    q = <function ShellIntegration.test_fish_integration.<locals>.<lambda> at 0x34ac00540>
    self = <kitty_tests.PTY object at 0x34ac277d0>
    timeout = 10
    timeout_msg = None
TimeoutError: Timed out: The condition was not met. Screen contents: 
 'left>string match -q -- "*/private/tmp/nix-build-kitty-0.39.1.drv-1/source/shell-integration*" "$XDG_DATA_DIRS" || echo "XDD_OK"                                              <right\nXDD_OK\nleft>cd /private/tmp/nix-build-kitty-0.>

----------------------------------------------------------------------
Ran 147 tests in 37.282s

FAILED (errors=2, skipped=3)
All Go tests succeeded, ran in 37.9 seconds
Error: Some tests failed!
make: *** [Makefile:16: test] Error 1

Additional context

No response

System metadata

i'm running on nix-darwin, but this should be independent, see upstream bug.

• system: "aarch64-darwin"
• host os: Darwin 24.3.0, macOS 15.3.1
• multi-user?: no
• sandbox: yes
• version: nix-env (Nix) 2.26.2
• nixpkgs: unstable

Notify maintainers

---

Note for maintainers: Please tag this issue in your pull request description. (i.e. Resolves #ISSUE.)

I assert that this issue is relevant for Nixpkgs

• I assert that this is a bug and not a support request.
• I assert that this is not a duplicate of an existing issue.
• I assert that I have read the NixOS Code of Conduct and agree to abide by it.

Is this issue important to you?

Add a 👍 reaction to issues you find important.

[leiserfg]

Try with #388182 and see if that solves it.