Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librewolf: Always store cookies/data toggle missing #387506

Closed
3 tasks done
Joseph-DiGiovanni opened this issue Mar 6, 2025 · 8 comments · Fixed by #388153
Closed
3 tasks done

librewolf: Always store cookies/data toggle missing #387506

Joseph-DiGiovanni opened this issue Mar 6, 2025 · 8 comments · Fixed by #388153
Labels
0.kind: bug Something is broken

Comments

@Joseph-DiGiovanni
Copy link

Nixpkgs version

  • Stable (24.11)

Describe the bug

The option to add exceptions to deleting cookies/data on close is not present in the site information menu. This applies to both librewolf and librewolf-unwrapped packages.

Steps to reproduce

  1. Open LibreWolf
  2. Navigate to any website
  3. Click the lock icon next to the URL
  4. The "Always store cookies/data" option is not there

Expected behaviour

Always store cookies/data option should be present in the site information menu.

Screenshots

Image

Relevant log output

Additional context

No response

System metadata

  • system: "x86_64-linux"
  • host os: Linux 6.13.5, NixOS, 24.11 (Vicuna), 24.11.20250228.b27ba4e
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.24.12
  • nixpkgs: /nix/store/5k90vvmnhiyjfyz2fq2qcznb2l13c8x8-source

Notify maintainers

@squalus @dwrege

Note for maintainers: Please tag this issue in your pull request description. (i.e. Resolves #ISSUE.)

I assert that this issue is relevant for Nixpkgs

Is this issue important to you?

Add a 👍 reaction to issues you find important.

@Joseph-DiGiovanni Joseph-DiGiovanni added the 0.kind: bug Something is broken label Mar 6, 2025
@donovanglover
Copy link
Member

Is this a recent feature? #387387 should be in 24.11 soon.

@Joseph-DiGiovanni
Copy link
Author

Joseph-DiGiovanni commented Mar 6, 2025

I don't believe so. The gitlab source has the patch as long as 2 years ago and it isn't in the unstable packages either.

There are a bunch of inconsistencies in general, such as firefox labs not being renamed to experimental features, which I think is safe to assume that is also not a new change. The top right hamburger menu is also slightly different even between the same version of librewolf and librewolf-unwrapped. Unwrapped has the "sync and save data" option at the top while the normal and binary package don't.

@donovanglover
Copy link
Member

@emaryn Since you refactored librewolf-bin in #387662, would you be interested in helping with this?

@emaryn
Copy link
Contributor

emaryn commented Mar 7, 2025

Indeed it does. librewolf-bin has no such problem. cc @DominicWrege

@donovanglover
Copy link
Member

Possibly related: #344417

@Joseph-DiGiovanni
Copy link
Author

Thanks for linking that. I hadn't noticed since I have a search engine declared in my config. Frankly I think the package should be taken down until these issues are resolved as its pretty misleading to call it LibreWolf when some privacy related patches are not being applied. You can't just apply a few LibreWolf patches to Firefox and call it LibreWolf.

@emaryn
Copy link
Contributor

emaryn commented Mar 8, 2025

It might be related to [this line](

if ! sed -n '/nvidia-wayland-backported-fixes-.*-Bug-1898476/p'; then
). Based on the build log, no LibreWolf patches seem to have been applied.

@fpletz
Copy link
Member

fpletz commented Mar 8, 2025

This PR broke it: #336304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants