Build failure: Vesktop #293083

madser123 · 2024-03-03T20:16:57Z

Steps To Reproduce

Steps to reproduce the behavior:

build Vesktop on 23.11 stable

Build log

Error: tsx must be loaded with --import instead of --loader
The --loader flag was deprecated in Node v20.6.0
    at Q (file:///build/source/node_modules/tsx/dist/esm/index.mjs:1:1793)
    at Hooks.addCustomLoader (node:internal/modules/esm/hooks:202:24)
    at Hooks.register (node:internal/modules/esm/hooks:168:16)
    at async initializeHooks (node:internal/modules/esm/utils:167:5)
    at async customizedModuleWorker (node:internal/modules/esm/worker:104:24)

Node.js v18.19.1
 ELIFECYCLE  Command failed with exit code 1.
/nix/store/10i1kjjq5szjn1gp6418x8bc1hswqc90-stdenv-linux/setup: line 131: pop_var_context: head of shell_variables not a function context
error: builder for '/nix/store/lfm77jsycm42siapivy36sggjp26lh5w-vesktop-0.4.4.drv' failed with exit code 1
error: 1 dependencies of derivation '/nix/store/rvjki9jx0mmi2pm1wvdracldfmxrj7z5-system-path.drv' failed to build
error: 1 dependencies of derivation '/nix/store/z64aclkkd2vsnryycjv3vmzk8dgfql7x-nixos-system-nixos-23.11.4976.79baff8812a0.drv' failed to build

Additional context

https://www.reddit.com/r/NixOS/comments/1b5gyja/nixos_stable_package_failing_to_install/

This is also reproducible by others.

Notify maintainers

@trofi @vgskye

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.79, NixOS, 23.11 (Tapir), 23.11.20240301.79baff8`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Add a 👍 reaction to issues you find important.

The text was updated successfully, but these errors were encountered:

trofi · 2024-03-03T20:39:59Z

/cc all maintainers: @getchoo @Scrumplex @vgskye @pluiedev

trofi · 2024-03-03T20:43:05Z

At least on unstable it looks fine: https://hydra.nixos.org/job/nixpkgs/trunk/vesktop.x86_64-linux

And release-23.11 indeed started failing 2 days ago: https://hydra.nixos.org/job/nixos/release-23.11/nixpkgs.vesktop.x86_64-linux

ghost · 2024-03-04T02:39:47Z

Can vouch for this, build failed for me aswell

pluiedev · 2024-03-04T07:35:28Z

Can reproduce via nix build github:NixOS/nixpkgs/release-23.11#vesktop. Here's a log output of what's happening:

vesktop> Running phase: unpackPhase
vesktop> unpacking source archive /nix/store/xhnw5jzxk1jca75x1jxj8cmfcx4s0y6f-source
vesktop> source root is source
vesktop> Running phase: patchPhase
vesktop> applying patch /nix/store/jl023dqmmbzyrn3gplhwmvazfdwkzwgf-use_system_vencord.patch
vesktop> patching file src/main/constants.ts
vesktop> applying patch /nix/store/zk8mavbkyfcbjlybrk1g7jxjw8swmwyl-disable_update_checking.patch
vesktop> patching file src/updater/main.ts
vesktop> Running phase: updateAutotoolsGnuConfigScriptsPhase
vesktop> Running phase: configurePhase
vesktop> no configure script, doing nothing
vesktop> Running phase: buildPhase
vesktop> Lockfile is up to date, resolution step is skipped
vesktop> Packages: +554
vesktop> Progress: resolved 0, reused 1, downloaded 0, added 0
vesktop> Progress: resolved 0, reused 533, downloaded 0, added 103
vesktop> Progress: resolved 0, reused 535, downloaded 0, added 554
vesktop> Progress: resolved 0, reused 535, downloaded 0, added 554, done
vesktop> Done in 1.1s
vesktop> patching script interpreter paths in node_modules/7zip-bin node_modules/@aashutoshrathi node_modules/@develar node_modules/@electron node_modules/@esbuild node_modules/@eslint node_modules/@eslint-community node_modules/@fal-works node_modules/@humanwhocodes node_modules/@malept node_modules/@nodelib node_modules/@pkgr node_modules/@sindresorhus node_modules/@szmarczak node_modules/@tootallnate node_modules/@types node_modules/@typescript-eslint node_modules/@ungap node_modules/@vencord node_modules/@xmldom node_modules/acorn node_modules/acorn-jsx node_modules/agent-base node_modules/ajv node_modules/ajv-keywords node_modules/ansi-regex node_modules/ansi-styles node_modules/app-builder-bin node_modules/app-builder-lib node_modules/aproba node_modules/are-we-there-yet node_modules/argparse node_modules/arr-diff node_modules/arr-union node_modules/array-buffer-byte-length node_modules/array-includes node_modules/array-union node_modules/array-unique node_modules/array.prototype.findlastindex node_modules/array.prototype.flat node_modules/array.prototype.flatmap node_modules/arraybuffer.prototype.slice node_modules/arrpc node_modules/assign-symbols node_modules/async node_modules/async-exit-hook node_modules/asynckit node_modules/at-least-node node_modules/atob node_modules/available-typed-arrays node_modules/axios node_modules/balanced-match node_modules/base node_modules/base64-js node_modules/big-integer node_modules/bluebird node_modules/bluebird-lst node_modules/boolean node_modules/bplist-parser node_modules/brace-expansion node_modules/braces node_modules/buffer-crc32 node_modules/buffer-equal node_modules/buffer-from node_modules/builder-util node_modules/builder-util-runtime node_modules/bundle-name node_modules/cache-base node_modules/cacheable-lookup node_modules/cacheable-request node_modules/call-bind node_modules/callsites node_modules/chalk node_modules/chownr node_modules/chromium-pickle-js node_modules/ci-info node_modules/class-utils node_modules/cliui node_modules/clone-response node_modules/cmake-js node_modules/collection-visit node_modules/color-convert node_modules/color-name node_modules/color-support node_modules/combined-stream node_modules/commander node_modules/compare-version node_modules/component-emitter node_modules/concat-map node_modules/config-file-ts node_modules/console-control-strings node_modules/copy-descriptor node_modules/cross-spawn node_modules/csstype node_modules/debug node_modules/decode-uri-component node_modules/decompress-response node_modules/deep-extend node_modules/deep-is node_modules/default-browser node_modules/default-browser-id node_modules/defer-to-connect node_modules/define-data-property node_modules/define-lazy-prop node_modules/define-properties node_modules/define-property node_modules/delayed-stream node_modules/delegates node_modules/detect-node node_modules/dir-compare node_modules/dir-glob node_modules/discord-types node_modules/dmg-builder node_modules/doctrine node_modules/dotenv node_modules/dotenv-expand node_modules/ejs node_modules/electron node_modules/electron-builder node_modules/electron-publish node_modules/emoji-regex node_modules/end-of-stream node_modules/env-paths node_modules/err-code node_modules/es-abstract node_modules/es-set-tostringtag node_modules/es-shim-unscopables node_modules/es-to-primitive node_modules/es6-error node_modules/esbuild node_modules/escalade node_modules/escape-string-regexp node_modules/eslint node_modules/eslint-config-prettier node_modules/eslint-import-resolver-alias node_modules/eslint-import-resolver-node node_modules/eslint-module-utils node_modules/eslint-plugin-import node_modules/eslint-plugin-license-header node_modules/eslint-plugin-path-alias node_modules/eslint-plugin-prettier node_modules/eslint-plugin-simple-import-sort node_modules/eslint-plugin-unused-imports node_modules/eslint-rule-composer node_modules/eslint-scope node_modules/eslint-visitor-keys node_modules/espree node_modules/esquery node_modules/esrecurse node_modules/estraverse node_modules/esutils node_modules/execa node_modules/extend-shallow node_modules/extract-zip node_modules/fast-deep-equal node_modules/fast-diff node_modules/fast-glob node_modules/fast-json-stable-stringify node_modules/fast-levenshtein node_modules/fastq node_modules/fd-slicer node_modules/file-entry-cache node_modules/filelist node_modules/fill-range node_modules/find-up node_modules/flat-cache node_modules/flatted node_modules/follow-redirects node_modules/for-each node_modules/for-in node_modules/form-data node_modules/fragment-cache node_modules/fs-extra node_modules/fs-minipass node_modules/fs.realpath node_modules/function-bind node_modules/function.prototype.name node_modules/functions-have-names node_modules/gauge node_modules/get-caller-file node_modules/get-intrinsic node_modules/get-stream node_modules/get-symbol-description node_modules/get-tsconfig node_modules/get-value node_modules/glob node_modules/glob-parent node_modules/global-agent node_modules/globals node_modules/globalthis node_modules/globby node_modules/gopd node_modules/got node_modules/graceful-fs node_modules/graphemer node_modules/has-bigints node_modules/has-flag node_modules/has-property-descriptors node_modules/has-proto node_modules/has-symbols node_modules/has-tostringtag node_modules/has-unicode node_modules/has-value node_modules/has-values node_modules/hasown node_modules/hosted-git-info node_modules/http-cache-semantics node_modules/http-proxy-agent node_modules/http2-wrapper node_modules/https-proxy-agent node_modules/human-signals node_modules/iconv-lite node_modules/ignore node_modules/import-fresh node_modules/imurmurhash node_modules/inflight node_modules/inherits node_modules/ini node_modules/internal-slot node_modules/is-accessor-descriptor node_modules/is-array-buffer node_modules/is-bigint node_modules/is-boolean-object node_modules/is-buffer node_modules/is-callable node_modules/is-ci node_modules/is-core-module node_modules/is-data-descriptor node_modules/is-date-object node_modules/is-descriptor node_modules/is-docker node_modules/is-extendable node_modules/is-extglob node_modules/is-fullwidth-code-point node_modules/is-glob node_modules/is-inside-container node_modules/is-negative-zero node_modules/is-number node_modules/is-number-object node_modules/is-path-inside node_modules/is-plain-object node_modules/is-regex node_modules/is-shared-array-buffer node_modules/is-stream node_modules/is-string node_modules/is-symbol node_modules/is-typed-array node_modules/is-weakref node_modules/is-windows node_modules/is-wsl node_modules/isarray node_modules/isbinaryfile node_modules/isexe node_modules/isobject node_modules/jake node_modules/js-yaml node_modules/json-buffer node_modules/json-schema-traverse node_modules/json-stable-stringify-without-jsonify node_modules/json-stringify-safe node_modules/json5 node_modules/jsonfile node_modules/keyv node_modules/kind-of node_modules/lazy-val node_modules/levn node_modules/locate-path node_modules/lodash node_modules/lodash.isplainobject node_modules/lodash.merge node_modules/lowercase-keys node_modules/lru-cache node_modules/map-cache node_modules/map-visit node_modules/matcher node_modules/memory-stream node_modules/merge-stream node_modules/merge2 node_modules/micromatch node_modules/mime node_modules/mime-db node_modules/mime-types node_modules/mimic-fn node_modules/mimic-response node_modules/minimatch node_modules/minimist node_modules/minipass node_modules/minizlib node_modules/mixin-deep node_modules/mkdirp node_modules/moment node_modules/ms node_modules/nanomatch node_modules/natural-compare node_modules/node-api-headers node_modules/normalize-url node_modules/npm-run-path node_modules/npmlog node_modules/object-copy node_modules/object-inspect node_modules/object-keys node_modules/object-visit node_modules/object.assign node_modules/object.fromentries node_modules/object.groupby node_modules/object.pick node_modules/object.values node_modules/once node_modules/onetime node_modules/open node_modules/optionator node_modules/p-cancelable node_modules/p-limit node_modules/p-locate node_modules/parent-module node_modules/pascalcase node_modules/path-exists node_modules/path-is-absolute node_modules/path-key node_modules/path-parse node_modules/path-type node_modules/pend node_modules/picocolors node_modules/picomatch node_modules/pkg-prebuilds node_modules/plist node_modules/prelude-ls node_modules/prettier node_modules/prettier-linter-helpers node_modules/progress node_modules/promise-retry node_modules/proxy-from-env node_modules/pump node_modules/punycode node_modules/queue-microtask node_modules/quick-lru node_modules/rc node_modules/read-config-file node_modules/readable-stream node_modules/regex-not node_modules/regexp.prototype.flags node_modules/require-directory node_modules/requireindex node_modules/resolve node_modules/resolve-alpn node_modules/resolve-from node_modules/resolve-pkg-maps node_modules/resolve-url node_modules/responselike node_modules/ret node_modules/retry node_modules/reusify node_modules/rimraf node_modules/roarr node_modules/run-applescript node_modules/run-parallel node_modules/safe-array-concat node_modules/safe-buffer node_modules/safe-regex node_modules/safe-regex-test node_modules/safer-buffer node_modules/sanitize-filename node_modules/sax node_modules/semver node_modules/semver-compare node_modules/serialize-error node_modules/set-blocking node_modules/set-function-length node_modules/set-function-name node_modules/set-value node_modules/shebang-command node_modules/shebang-regex node_modules/side-channel node_modules/signal-exit node_modules/simple-update-notifier node_modules/slash node_modules/snapdragon node_modules/source-map node_modules/source-map-resolve node_modules/source-map-support node_modules/source-map-url node_modules/split-string node_modules/sprintf-js node_modules/standalone-electron-types node_modules/stat-mode node_modules/static-extend node_modules/string-width node_modules/string.prototype.trim node_modules/string.prototype.trimend node_modules/string.prototype.trimstart node_modules/string_decoder node_modules/strip-ansi node_modules/strip-bom node_modules/strip-final-newline node_modules/strip-json-comments node_modules/sumchecker node_modules/supports-color node_modules/supports-preserve-symlinks-flag node_modules/synckit node_modules/tar node_modules/temp-file node_modules/text-table node_modules/titleize node_modules/tmp node_modules/tmp-promise node_modules/to-object-path node_modules/to-regex node_modules/to-regex-range node_modules/truncate-utf8-bytes node_modules/ts-api-utils node_modules/tsconfig-paths node_modules/tslib node_modules/tsx node_modules/type-check node_modules/type-fest node_modules/typed-array-buffer node_modules/typed-array-byte-length node_modules/typed-array-byte-offset node_modules/typed-array-length node_modules/typescript node_modules/unbox-primitive node_modules/undici-types node_modules/union-value node_modules/universalify node_modules/unset-value node_modules/untildify node_modules/uri-js node_modules/urix node_modules/url-join node_modules/use node_modules/utf8-byte-length node_modules/util-deprecate node_modules/which node_modules/which-boxed-primitive node_modules/which-typed-array node_modules/wide-align node_modules/wrap-ansi node_modules/wrappy node_modules/ws node_modules/xmlbuilder node_modules/y18n node_modules/yallist node_modules/yargs node_modules/yargs-parser node_modules/yauzl node_modules/yocto-queue node_modules/.bin node_modules/.modules.yaml node_modules/.pnpm
vesktop> node_modules/@electron/asar/bin/asar.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/@electron/osx-sign/bin/electron-osx-sign.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/@electron/osx-sign/bin/electron-osx-flat.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/@electron/get/node_modules/semver/bin/semver.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/@vencord/venmic/node_modules/node-addon-api/tools/conversion.js: interpreter directive changed from "#! /usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/acorn/bin/acorn: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/arrpc/src/index.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/atob/bin/atob.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/cmake-js/bin/cmake-js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/color-support/bin.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/config-file-ts/node_modules/typescript/bin/tsc: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/config-file-ts/node_modules/typescript/bin/tsserver: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/ejs/bin/cli.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/electron/cli.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/electron-builder/install-app-deps.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/electron-builder/cli.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/esbuild/bin/esbuild: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/eslint/bin/eslint.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/eslint-config-prettier/bin/cli.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/eslint-plugin-import/node_modules/semver/bin/semver.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/extract-zip/cli.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/is-ci/bin.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/is-docker/cli.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/is-inside-container/cli.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/is-wsl/node_modules/is-docker/cli.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/jake/bin/cli.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/jake/bin/bash_completion.sh: interpreter directive changed from "#!/bin/bash" to "/nix/store/r9h133c9m8f6jnlsqzwf89zg9w0w78s8-bash-5.2-p15/bin/bash"
vesktop> node_modules/js-yaml/bin/js-yaml.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/json5/lib/cli.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/mime/cli.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/mkdirp/bin/cmd.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/open/xdg-open: interpreter directive changed from "#!/bin/sh" to "/nix/store/r9h133c9m8f6jnlsqzwf89zg9w0w78s8-bash-5.2-p15/bin/sh"
vesktop> node_modules/pkg-prebuilds/bin/copy.mjs: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/pkg-prebuilds/bin/verify.mjs: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/prettier/bin/prettier.cjs: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/rc/cli.js: interpreter directive changed from "#! /usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/resolve/bin/resolve: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/rimraf/bin.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/semver/bin/semver.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/tsconfig-paths/node_modules/json5/lib/cli.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/tsx/dist/cli.mjs: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/tsx/node_modules/esbuild/bin/esbuild: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/typescript/bin/tsc: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/typescript/bin/tsserver: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/url-join/bin/changelog: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> node_modules/which/bin/node-which: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/wnbxah2y943l73hdmq5r7lb92lsa5f8z-nodejs-18.19.1/bin/node"
vesktop> no Makefile or custom buildPhase, doing nothing
vesktop> > VencordDesktop@0.4.4 build /build/source
vesktop> > tsx scripts/build/build.mts
vesktop> node:internal/process/esm_loader:40
vesktop>       internalBinding('errors').triggerUncaughtException(
vesktop>                                 ^
vesktop> Error: tsx must be loaded with --import instead of --loader
vesktop> The --loader flag was deprecated in Node v20.6.0
vesktop>     at Q (file:///build/source/node_modules/tsx/dist/esm/index.mjs:1:1793)
vesktop>     at Hooks.addCustomLoader (node:internal/modules/esm/hooks:202:24)
vesktop>     at Hooks.register (node:internal/modules/esm/hooks:168:16)
vesktop>     at async initializeHooks (node:internal/modules/esm/utils:167:5)
vesktop>     at async customizedModuleWorker (node:internal/modules/esm/worker:104:24)
vesktop> Node.js v18.19.1
vesktop>  ELIFECYCLE  Command failed with exit code 1.
vesktop> /nix/store/10i1kjjq5szjn1gp6418x8bc1hswqc90-stdenv-linux/setup: line 131: pop_var_context: head of shell_variables not a function context
error: builder for '/nix/store/lfm77jsycm42siapivy36sggjp26lh5w-vesktop-0.4.4.drv' failed with exit code 1;
       last 10 log lines:
       > The --loader flag was deprecated in Node v20.6.0
       >     at Q (file:///build/source/node_modules/tsx/dist/esm/index.mjs:1:1793)
       >     at Hooks.addCustomLoader (node:internal/modules/esm/hooks:202:24)
       >     at Hooks.register (node:internal/modules/esm/hooks:168:16)
       >     at async initializeHooks (node:internal/modules/esm/utils:167:5)
       >     at async customizedModuleWorker (node:internal/modules/esm/worker:104:24)
       >
       > Node.js v18.19.1
       >  ELIFECYCLE  Command failed with exit code 1.
       > /nix/store/10i1kjjq5szjn1gp6418x8bc1hswqc90-stdenv-linux/setup: line 131: pop_var_context: head of shell_variables not a function context
       For full logs, run 'nix log /nix/store/lfm77jsycm42siapivy36sggjp26lh5w-vesktop-0.4.4.drv'.

I'm gonna look a bit further into what scripts/build/build.mts does and try to find a fix for this

pluiedev · 2024-03-04T07:45:49Z

Looks like this is a very well known issue (privatenumber/tsx#421). What is curious to me is that, it appears that Vesktop already uses tsx 4.7.0, and shouldn't be affected by this at all... 🤔 Unstable also works, which means there is a diff somewhere between 23.11 and unstable that's breaking this build

jmarmstrong1207 · 2024-03-06T03:15:40Z

I dont understand how this build failure could've been missed when updating 23.11

jmarmstrong1207 · 2024-03-06T07:48:09Z

Looks like this is a very well known issue (privatenumber/tsx#421). What is curious to me is that, it appears that Vesktop already uses tsx 4.7.0, and shouldn't be affected by this at all... 🤔 Unstable also works, which means there is a diff somewhere between 23.11 and unstable that's breaking this build

From what I'm seeing, The upgrade to Node v18.19 merged into nixos 23.11 causes this issue. I saw this thread about this exact issue here: nuxt/devtools#606, and they have stated that upgrading tsx to above v4.6.1 fixes it. Vesktop 0.4.3 uses tsx v3.13. I couldn't find the Vesktop tag 0.4.4 in their repo oddly enough. What version is this derivation actually downloading then?

jmarmstrong1207 · 2024-03-06T07:57:46Z

Update: I've done nix --extra-experimental-features "nix-command flakes" develop github:NixOS/nixpkgs/release-23.11#vesktop, then ran runPhase unpackPhase, and checked the pnpm-lock.yaml file. It's using tsx v4.6.0, which I think is the source of the problem.

Here is from the official tsx repo, showing that this problem has been fixed with v4.6.1 as well:
privatenumber/tsx#421

The easiest way to fix this I guess is to just push Vesktop 1.5.0 to 23.11?

Scrumplex · 2024-03-06T09:52:52Z

The easiest way to fix this I guess is to just push Vesktop 1.5.0 to 23.11?

We decided against this, as it would be a breaking change (new data directory location and binary name)
#281669

pluiedev · 2024-03-06T12:06:06Z

We would have to patch the 1.4.x series with tsx 4.6.1+ then... we should maybe then make a PR specific to 23.11 for that

hannylicious · 2024-03-11T12:10:17Z

Hate to resurrect something closed - but did anyone determine a fix for this?

How do we get around it?

jmarmstrong1207 · 2024-03-11T12:33:35Z

Hate to resurrect something closed - but did anyone determine a fix for this?

How do we get around it?

Don't worry, this issue is still open. You were looking at the duplicate issue referenced above.

But to fix this, you can install vesktop from the unstable channel. Here is how for non-flakes. If you are using nix flakes, use this

chmanie · 2024-03-13T06:32:23Z

Sadly the unstable version is super sluggish for me due to mismatching mesa bindings:

DRI driver not from this Mesa build ('23.1.9' vs '24.0.2')

Warning: vkCreateInstance: Found no drivers!
Warning: vkCreateInstance failed with VK_ERROR_INCOMPATIBLE_DRIVER

Is there any way to get around this or do I have to wait until this is fixed for good (or 24.05)?

pluiedev · 2024-03-13T07:22:52Z

Sadly the unstable version is super sluggish for me due to mismatching mesa bindings:

Yikes. I'm going to try to patch this for the time being then

pluiedev · 2024-03-13T08:09:39Z

It builds!!!

Fixes the build failure caused by outdated versions of the tsx library on Node 18.19+ (privatenumber/tsx#421). Fixes NixOS#293083

Letgamer · 2024-03-30T13:42:09Z

Apparently the Pull Request fixed this #295540
Anyone tried building it to confirm so that this issue can then be closed?

vgskye · 2024-03-30T14:50:28Z

release-23.11 confirmed builds fine

Scrumplex · 2024-03-30T14:50:32Z

I just ran nix run github:NixOS/nixpkgs/release-23.11#vesktop to test and it works!

Fixes the build failure caused by outdated versions of the tsx library on Node 18.19+ (privatenumber/tsx#421). Fixes NixOS#293083

madser123 added the 0.kind: build failure A package fails to build label Mar 3, 2024

dotlambda added the 6.topic: nodejs label Mar 3, 2024

eclairevoyant mentioned this issue Mar 10, 2024

error: builder for '/nix/store/8r6hvk43z84ccdf3ir01pvc2xqjcwj6a-vesktop-0.4.4.drv' failed with exit code 1; #294683

Closed

pluiedev mentioned this issue Mar 13, 2024

[23.11] vesktop: update tsx dependency to ^4.6.1 #295540

Merged

13 tasks

pluiedev added a commit to pluiedev/nixpkgs that referenced this issue Mar 17, 2024

[23.11] vesktop: update tsx dependency to ^4.6.1

56660ef

Fixes the build failure caused by outdated versions of the tsx library on Node 18.19+ (privatenumber/tsx#421). Fixes NixOS#293083

vgskye closed this as completed Mar 30, 2024

zeme-wana pushed a commit to input-output-hk/nixpkgs that referenced this issue May 8, 2024

[23.11] vesktop: update tsx dependency to ^4.6.1

82e2438

Fixes the build failure caused by outdated versions of the tsx library on Node 18.19+ (privatenumber/tsx#421). Fixes NixOS#293083

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build failure: Vesktop #293083

Build failure: Vesktop #293083

madser123 commented Mar 3, 2024 •

edited

Loading

trofi commented Mar 3, 2024

trofi commented Mar 3, 2024

ghost commented Mar 4, 2024

pluiedev commented Mar 4, 2024

pluiedev commented Mar 4, 2024 •

edited

Loading

jmarmstrong1207 commented Mar 6, 2024

jmarmstrong1207 commented Mar 6, 2024 •

edited

Loading

jmarmstrong1207 commented Mar 6, 2024 •

edited

Loading

Scrumplex commented Mar 6, 2024

pluiedev commented Mar 6, 2024

hannylicious commented Mar 11, 2024

jmarmstrong1207 commented Mar 11, 2024

chmanie commented Mar 13, 2024

pluiedev commented Mar 13, 2024 •

edited

Loading

pluiedev commented Mar 13, 2024

Letgamer commented Mar 30, 2024

vgskye commented Mar 30, 2024

Scrumplex commented Mar 30, 2024

Build failure: Vesktop #293083

Build failure: Vesktop #293083

Comments

madser123 commented Mar 3, 2024 • edited Loading

Steps To Reproduce

Build log

Additional context

Notify maintainers

Metadata

trofi commented Mar 3, 2024

trofi commented Mar 3, 2024

ghost commented Mar 4, 2024

pluiedev commented Mar 4, 2024

pluiedev commented Mar 4, 2024 • edited Loading

jmarmstrong1207 commented Mar 6, 2024

jmarmstrong1207 commented Mar 6, 2024 • edited Loading

jmarmstrong1207 commented Mar 6, 2024 • edited Loading

Scrumplex commented Mar 6, 2024

pluiedev commented Mar 6, 2024

hannylicious commented Mar 11, 2024

jmarmstrong1207 commented Mar 11, 2024

chmanie commented Mar 13, 2024

pluiedev commented Mar 13, 2024 • edited Loading

pluiedev commented Mar 13, 2024

Letgamer commented Mar 30, 2024

vgskye commented Mar 30, 2024

Scrumplex commented Mar 30, 2024

madser123 commented Mar 3, 2024 •

edited

Loading

pluiedev commented Mar 4, 2024 •

edited

Loading

jmarmstrong1207 commented Mar 6, 2024 •

edited

Loading

jmarmstrong1207 commented Mar 6, 2024 •

edited

Loading

pluiedev commented Mar 13, 2024 •

edited

Loading