-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade examples to BioNeMo 2 #3095
Conversation
241f8ec
to
e051663
Compare
e051663
to
aaf1e48
Compare
/build |
Suggestion regarding accumulation TB history for the clients. Clients recording TB history locally from from tensorboard.backend.event_processing.event_accumulator import EventAccumulator
def get_tensorboard_history(trainer):
# Get the log directory from trainer's logger
log_dir = trainer.logger.experiment.log_dir
# Create an EventAccumulator object
event_acc = EventAccumulator(log_dir)
event_acc.Reload() # Load all data
# Get available tags (metrics)
tags = event_acc.Tags()['scalars']
# Extract history for each metric
history = {}
for tag in tags:
events = event_acc.Scalars(tag)
# Each event has attributes: wall_time, step, value
history[tag] = [(e.step, e.value) for e in events]
return history And then after sharing through tb_writer = SummaryWriter('continuous_logs')
for shareable in shareables:
metrics_history = shareable['history']
# Write each metric to the continuous log
for metric_name, values in metrics_history.items():
for step, value in values:
global_step = (current_round * max_steps_per_round) + step
writer.add_scalar(f'continuous/{metric_name}', value, global_step=global_step) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TB accumulation will be addressed in a separate PR. Filed an issue for tracking #3249 |
/build |
/build |
examples/advanced/bionemo/task_fitting/src/bionemo_mlp_learner.py
Outdated
Show resolved
Hide resolved
...d/bionemo/task_fitting/jobs/embeddings/app/models/vocab/protein_sequence_sentencepiece.model
Outdated
Show resolved
Hide resolved
examples/advanced/bionemo/task_fitting/src/bionemo_inference_processor.py
Show resolved
Hide resolved
/build |
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/build |
Fixes # .
Description
Upgrade existing bionemo example to use version 2.4 (upcoming release)
Types of changes
./runtest.sh
.