Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ctests for conventional prepobs data. #7

Open
4 tasks
nicholasesposito opened this issue Jan 30, 2025 · 1 comment
Open
4 tasks

Add ctests for conventional prepobs data. #7

nicholasesposito opened this issue Jan 30, 2025 · 1 comment
Assignees

Comments

@nicholasesposito
Copy link

nicholasesposito commented Jan 30, 2025

Add ctests for conventional prepobs data, similar to what is in bufr-query.

For this issue, the ctests added are for

  • ADPSFC prepbufr
  • SFCSHP prepbufr
  • acft_profiles prepbufr
  • adpupa_prepbufr

Notes:

  • Small change to ctest generation step of non-prepbufr conventional data.
  • All have been tested
  • All 8 ADPSFC prepbufr tests pass and all 8 SFCSHP prepbufr tests pass when paired with their respective SPOC branches.
  • acft_profiles and ADPUPA use the group_by function, which is having problems right now. The tests fail as of writing (1/30/25). Once the group_by is fixed, run the scripts again, validate by plotting, move the new data to obsforge-0.0.0.tgz and test
  • The current versions of all three do not include a line in the python scripts that add dateTime reference so once bufr_query is updated, we can add those. We will have to update the outputs in the obsforge-0.0.0.tgz file once that's done.
  • Other prepbufr tests can easily be added to his.
@nicholasesposito nicholasesposito self-assigned this Jan 30, 2025
@nicholasesposito
Copy link
Author

nicholasesposito commented Jan 30, 2025

To test on Hera, run
source /home/Emily.Liu/modules/env_obsforge.sh
The tests are taking longer than usual, I think because Hera /scratch1/NCEPDEV/da/ is completely full.

Afterwards, for adpsfc:

[Nicholas.Esposito@hfe11 build]$ ctest -R test_obsforge_convobs_prepbufr_adpsfc_prepbufr
Test project /scratch1/NCEPDEV/da/Nicholas.Esposito/JEDI/obsForge_20250128/build
    Start 869: test_obsforge_convobs_prepbufr_adpsfc_prepbufr_bufr2netcdf
1/8 Test #869: test_obsforge_convobs_prepbufr_adpsfc_prepbufr_bufr2netcdf ...........   Passed   10.15 sec
    Start 870: test_obsforge_convobs_prepbufr_adpsfc_prepbufr_bufr2netcdf_mpi4
2/8 Test #870: test_obsforge_convobs_prepbufr_adpsfc_prepbufr_bufr2netcdf_mpi4 ......   Passed  211.59 sec
    Start 871: test_obsforge_convobs_prepbufr_adpsfc_prepbufr_script2netcdf
3/8 Test #871: test_obsforge_convobs_prepbufr_adpsfc_prepbufr_script2netcdf .........   Passed   15.52 sec
    Start 872: test_obsforge_convobs_prepbufr_adpsfc_prepbufr_script2netcdf_mpi4
4/8 Test #872: test_obsforge_convobs_prepbufr_adpsfc_prepbufr_script2netcdf_mpi4 ....   Passed  441.05 sec
    Start 873: test_obsforge_convobs_prepbufr_adpsfc_prepbufr_bufr4backend
5/8 Test #873: test_obsforge_convobs_prepbufr_adpsfc_prepbufr_bufr4backend ..........   Passed   64.74 sec
    Start 874: test_obsforge_convobs_prepbufr_adpsfc_prepbufr_bufr4backend_mpi4
6/8 Test #874: test_obsforge_convobs_prepbufr_adpsfc_prepbufr_bufr4backend_mpi4 .....   Passed  312.06 sec
    Start 875: test_obsforge_convobs_prepbufr_adpsfc_prepbufr_script4backend
7/8 Test #875: test_obsforge_convobs_prepbufr_adpsfc_prepbufr_script4backend ........   Passed   20.07 sec
    Start 876: test_obsforge_convobs_prepbufr_adpsfc_prepbufr_script4backend_mpi4
8/8 Test #876: test_obsforge_convobs_prepbufr_adpsfc_prepbufr_script4backend_mpi4 ...   Passed   41.51 sec

100% tests passed, 0 tests failed out of 8

Label Time Summary:
mpi               = 1006.21 sec*proc (4 tests)
obsforge_tests    = 1116.69 sec*proc (8 tests)
script            = 1116.69 sec*proc (8 tests)

Total Test time (real) = 1117.72 sec

sfcshp:

[Nicholas.Esposito@hfe11 build]$ ctest -R test_obsforge_convobs_prepbufr_sfcshp_prepbufr
Test project /scratch1/NCEPDEV/da/Nicholas.Esposito/JEDI/obsForge_20250128/build
    Start 877: test_obsforge_convobs_prepbufr_sfcshp_prepbufr_bufr2netcdf
1/8 Test #877: test_obsforge_convobs_prepbufr_sfcshp_prepbufr_bufr2netcdf ...........   Passed    3.81 sec
    Start 878: test_obsforge_convobs_prepbufr_sfcshp_prepbufr_bufr2netcdf_mpi4
2/8 Test #878: test_obsforge_convobs_prepbufr_sfcshp_prepbufr_bufr2netcdf_mpi4 ......   Passed   11.62 sec
    Start 879: test_obsforge_convobs_prepbufr_sfcshp_prepbufr_script2netcdf
3/8 Test #879: test_obsforge_convobs_prepbufr_sfcshp_prepbufr_script2netcdf .........   Passed    9.11 sec
    Start 880: test_obsforge_convobs_prepbufr_sfcshp_prepbufr_script2netcdf_mpi4
4/8 Test #880: test_obsforge_convobs_prepbufr_sfcshp_prepbufr_script2netcdf_mpi4 ....   Passed   57.25 sec
    Start 881: test_obsforge_convobs_prepbufr_sfcshp_prepbufr_bufr4backend
5/8 Test #881: test_obsforge_convobs_prepbufr_sfcshp_prepbufr_bufr4backend ..........   Passed    7.03 sec
    Start 882: test_obsforge_convobs_prepbufr_sfcshp_prepbufr_bufr4backend_mpi4

6/8 Test #882: test_obsforge_convobs_prepbufr_sfcshp_prepbufr_bufr4backend_mpi4 .....   Passed  508.30 sec
    Start 883: test_obsforge_convobs_prepbufr_sfcshp_prepbufr_script4backend
7/8 Test #883: test_obsforge_convobs_prepbufr_sfcshp_prepbufr_script4backend ........   Passed   10.41 sec
    Start 884: test_obsforge_convobs_prepbufr_sfcshp_prepbufr_script4backend_mpi4
8/8 Test #884: test_obsforge_convobs_prepbufr_sfcshp_prepbufr_script4backend_mpi4 ...   Passed  502.88 sec

100% tests passed, 0 tests failed out of 8

Label Time Summary:
mpi               = 1080.05 sec*proc (4 tests)
obsforge_tests    = 1110.41 sec*proc (8 tests)
script            = 1110.41 sec*proc (8 tests)

Total Test time (real) = 1112.25 sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant