Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve module dependency mismatch for GSI soil DA #3390

Open
ClaraDraper-NOAA opened this issue Feb 25, 2025 · 0 comments
Open

resolve module dependency mismatch for GSI soil DA #3390

ClaraDraper-NOAA opened this issue Feb 25, 2025 · 0 comments

Comments

@ClaraDraper-NOAA
Copy link
Contributor

What is wrong?

Currently, the GSI soil analysis (DO_GSISOILDA) calls regridding code from GDASApp/DA-utils. This regridding is called from the sfcanl and esfc jobs. This introduces 2 complications:

  1. Requires GDASApp to be built to do the soil DA, but only requires a tiny executable.
  2. On hear at least, requires that the modules from ufsda be loaded in place of the standard workflow modules for these jobs.

specifically jobs/rocoto/sfcanl.sh and esfc.sh

must call load_ufsda_modules.sh instead of load_fv3gfs_modules.sh.

We need a more general solution that can call the same module script with / without the soil DA.

What should have happened?

It would be preferable to be able to run the GSI soil DA without compiling GDASApp.

Need to remove current manual switch of the module file in the job scripts when using the soil DA.

What machines are impacted?

All or N/A

What global-workflow hash are you using?

Issue introduced for PR #3295

Steps to reproduce

setting DO_GSISOILDA to YES will crash in the sfcanal and escf jobs if the module script is not manually switched to load_ufsda_modules.sh

Additional information

No response

Do you have a proposed solution?

Best solution is probably to move the regridding code. @CoryMartin-NOAA

@ClaraDraper-NOAA ClaraDraper-NOAA added the triage Issues that are triage label Feb 25, 2025
@WalterKolczynski-NOAA WalterKolczynski-NOAA removed the triage Issues that are triage label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants