Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace status with err in bash scripts #3367

Open
2 tasks
DavidHuber-NOAA opened this issue Feb 24, 2025 · 2 comments
Open
2 tasks

Replace status with err in bash scripts #3367

DavidHuber-NOAA opened this issue Feb 24, 2025 · 2 comments
Assignees

Comments

@DavidHuber-NOAA
Copy link
Contributor

DavidHuber-NOAA commented Feb 24, 2025

What new functionality do you need?

In order to use err_chk to be more EE2 compliant, variables such as status should be replaced with err. This will make it easier to address #294.

What are the requirements for the new functionality?

All cases of stat, status, etc are replaced with err when representing a fatal error or a script-ending error.

Acceptance Criteria

  • All CI tests run successfully with no changes to products
  • Any remaining stat, status, etc, variables are for non-fatal errors

Suggest a solution (optional)

No response

@DavidHuber-NOAA DavidHuber-NOAA added feature New feature or request triage Issues that are triage labels Feb 24, 2025
@WalterKolczynski-NOAA WalterKolczynski-NOAA removed the triage Issues that are triage label Feb 24, 2025
@WalterKolczynski-NOAA WalterKolczynski-NOAA removed the feature New feature or request label Feb 24, 2025
@WalterKolczynski-NOAA
Copy link
Contributor

I want to split this into two separate issues. This one can be about renaming the variables. We already have an existing issue addressing err_chk (#294) and are still deciding how exactly to do it.

@DavidHuber-NOAA
Copy link
Contributor Author

Sounds good to me. I'll rework the title and description.

@DavidHuber-NOAA DavidHuber-NOAA changed the title Replace status with err and use err_chk in bash scripts Replace status with err in bash scripts Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants