diff --git a/ci/jobs-dev/run_post_hrrr_ifi_HERA.sh b/ci/jobs-dev/run_post_hrrr_ifi_HERA.sh index 9dc193ebe..3f398f6c7 100755 --- a/ci/jobs-dev/run_post_hrrr_ifi_HERA.sh +++ b/ci/jobs-dev/run_post_hrrr_ifi_HERA.sh @@ -72,9 +72,6 @@ write_ifi_debug_files=.true. EOF #FMIN -#copy fix data -cp $homedir/fix/fix_2.3.0/*bin . - #copy xml cp ${svndir}/parm/params_grib2_tbl_new params_grib2_tbl_new cp ${svndir}/parm/postxconfig-NT-ifi.txt postxconfig-NT.txt diff --git a/ci/rt.sh b/ci/rt.sh index a81ba913e..b1254af2d 100755 --- a/ci/rt.sh +++ b/ci/rt.sh @@ -71,7 +71,7 @@ run_rtma=yes # Tests with IFI enabled only work if libIFI is present. if [[ "$have_ifi" == yes && "$disable_ifi" == no ]] ; then run_hrrr_ifi=yes - run_ifi_standalone_hrrr=no # turned off by default because it doesn't match UPP output yet + run_ifi_standalone_hrrr=yes run_fv3r_ifi=yes run_ifi_standalone_fv3r=yes else diff --git a/sorc/ncep_post.fd/IFI.F b/sorc/ncep_post.fd/IFI.F index ce4dbc86a..05d5c35b7 100644 --- a/sorc/ncep_post.fd/IFI.F +++ b/sorc/ncep_post.fd/IFI.F @@ -1,5 +1,12 @@ !> @file !> @brief upp_ifi_mod declares variables used in the in-flight icing (IFI) routines. +!> +!> ### Program history log: +!> Date | Programmer | Comments +!> -----|------------|--------- +!> ca 2023-2025 | Sam Trahan and UCAR collaborators | Initial +!> 2025-02-27 | Sam Trahan | Bugfix: Reject IFI_APCP only where it is spval + module upp_ifi_mod #ifdef USE_IFI @@ -792,7 +799,7 @@ END SUBROUTINE EXCH_c_float !$OMP PARALLEL DO COLLAPSE(2) do j=jsta,jend do i=ista,iend - if(ifi_apcp(i,j)>9e9 .or. ifi_apcp(i,j)<-9e9 .or. ifi_apcp(i,j)==0) then + if(ifi_apcp(i,j) == spval) then ifi_apcp(i,j) = avgprec_cont(i,j)*to_hourly else if(ITPREC>1e-5) then ifi_apcp(i,j) = ifi_apcp(i,j)/itprec diff --git a/sorc/ncep_post.fd/SURFCE.f b/sorc/ncep_post.fd/SURFCE.f index d8c1c023b..b5b852528 100644 --- a/sorc/ncep_post.fd/SURFCE.f +++ b/sorc/ncep_post.fd/SURFCE.f @@ -56,6 +56,7 @@ !> 2024-06-11 | E James | Modifying RRFS hourly average smoke/dust fields to be PM2.5 and PM20 !> 2024-08-26 | K Asmar | Modify max winds at 10m agl for UFS time buckets !> 2024-10-29 | W Meng | Unify iSF_SURFACE_PHYSICS as:1 for NOHA,2 for NOAH MP,3 for RUC +!> 2025-02-27 | S Trahan | Update comment to match new use of IFI_APCP in IFI.F !> !> @note !> USAGE: CALL SURFCE @@ -4048,7 +4049,7 @@ SUBROUTINE SURFCE ENDIF ENDDO ENDDO - ! Note: IFI.F may replace IFI_APCP with other values where it is spval or 0 + ! Note: IFI.F may replace IFI_APCP=spval with other values ENDIF IF (IGET(434)>0.) THEN