You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed Myriad's main branch had been ~mostly upgraded to .NET 9 but the package wasn't available on NuGet. There are two issues:
The publish action is configured to install .NET 6 (and Windows — you probably don't want that). We should change this line to 9.x
We can't publish the package anyway, because the mergenupkg build step is broken in .NET 9:
Myriad cadence$ dotnet tool restore
Failed to validate package signing.
Verifying dotnet-mergenupkg.3.0.0
Signature type: Repository
Subject Name: CN=NuGet.org Repository by Microsoft, O=NuGet.org Repository by Microsoft, L=Redmond, S=Washington, C=US
SHA256 hash: 0E5F38F57DC1BCC806D8494F4F90FBCEDD988B46760709CBEEC6F4219AA6157D
Valid from: 4/9/2018 9:00:00 PM to 4/14/2021 9:00:00 AM
warn : NU3018: The repository primary signature found a chain building issue: RevocationStatusUnknown: An incomplete certificate revocation check occurred.
error: NU3037: The repository primary signature validity period has expired.
error: NU3028: The repository primary signature's timestamp found a chain building issue: ExplicitDistrust: The trust setting for this policy was set to Deny.
Package signature validation failed.
Instructions for reproduction
Install .NET 9 SDK
Run dotnet tool restore from repository root.
Proposed solution
Publish myriad as a .NET tool and Myriad.Sdk as a separate package
OR develop some solution to allow MSBuild to locate build scripts inside our dotnet tool install directory.
I'm leaning toward the first for simplicity sake. I tried to figure out how to make the second solution work, but it seems like more trouble than its worth. Let me know which approach you prefer and I'll submit a PR.
The text was updated successfully, but these errors were encountered:
Having two packages makes using it more difficult to use though though right?
I think, (I forget now because so much time has passed) that @enricosada used mergenupkg due to a limitation in dotnet tools at that point in time. I just cant remember now. When we were both working at Jet the basis for the package architecture came from Falanx which has the same build steps and cache checking. I mean, you dont need to know all this, I'm just thinking out loud :-)
Problem overview
I noticed Myriad's main branch had been ~mostly upgraded to .NET 9 but the package wasn't available on NuGet. There are two issues:
The publish action is configured to install .NET 6 (and Windows — you probably don't want that). We should change this line to
9.x
We can't publish the package anyway, because the
mergenupkg
build step is broken in .NET 9:Instructions for reproduction
dotnet tool restore
from repository root.Proposed solution
myriad
as a .NET tool andMyriad.Sdk
as a separate packageI'm leaning toward the first for simplicity sake. I tried to figure out how to make the second solution work, but it seems like more trouble than its worth. Let me know which approach you prefer and I'll submit a PR.
The text was updated successfully, but these errors were encountered: