Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The image displayed on left eye is with significant deviation as right eye with URP used. #720

Closed
Hanning-Liu opened this issue Apr 13, 2024 · 4 comments
Assignees
Labels
Status: External An issue caused by factors external to the MRTK project. Status: Invalid Not a valid discussion topic, bug, or feature request. Type: Bug A problem with an existing feature that can be fixed with the next patched release.

Comments

@Hanning-Liu
Copy link

Hanning-Liu commented Apr 13, 2024

Describe the bug

The canvas buttons are not displayed correctly on both eyes of HoloLens2 when the URP used.
And the image is very laggy.
The left eye will become fully white and the right eye can not see anything when the custom renderer feature is used.

To reproduce

  1. Install MRTK3, and OpenXR using MRTK feature tool
  2. install URP from unity package manager
  3. configure the MRTK remoting settings
  4. Hit the play button to start holographic remoting with HoloLens 2
  5. Add the Canvas and buttons from the Hierachy window
  6. See the images displayed on HoloLens on device, or through the Game "Preview" window in Unity (Turn on both Eyes setting)

Expected behavior

Images on both eyes are displaying the same images and being not laggay.
Works well with custom renderer feature of URP.

Screenshots

2024-04-13.21-57-02.mp4

Your setup (please complete the following information)

  • Unity Version 2021.3.34f1c1
  • MRTK Version or Commit
    image

Target platform (please complete the following information)

  • HoloLens 2 with Holographic Remoting App being used
  • Unity Version 2021.3.34f1c1
  • MRTK3
  • OpenXR
  • URP 12.1.13
@Hanning-Liu Hanning-Liu added Needs: Triage Needs to be triaged. Type: Bug A problem with an existing feature that can be fixed with the next patched release. labels Apr 13, 2024
@BenediktTobias
Copy link
Contributor

Usually a simple restart of the project fixes that shader issue that may occur directly after installing URP. If the issue still persists after a restart, try to rebuild Unity's shader cache.
To do this simply delete [ProjectName]/Library/ShaderCache and restart your project.

@AMollis
Copy link
Contributor

AMollis commented Apr 22, 2024

@Hanning-Liu what shaders are you using? Is everything in you're scene using shaders from the Mixed Reality Graphic Tools? https://github.com/microsoft/MixedReality-GraphicsTools-Unity

@AMollis AMollis added Needs: Author Attention Needs additional information from the issue author and removed Needs: Triage Needs to be triaged. labels Apr 22, 2024
@Hanning-Liu
Copy link
Author

Hi @AMollis. Thank you for your reply!
I used custom shader in this tutorial: https://www.youtube.com/watch?v=LMqio9NsqmM, I want to implement a mesh outline effect which is good to use.
As for Mixed Reality Graphic Tools, I've tried it, but the effect is nor good enough. You can look through this issue: microsoft/MixedReality-GraphicsTools-Unity#209

@shaynie shaynie removed the Needs: Author Attention Needs additional information from the issue author label Apr 24, 2024
@AMollis
Copy link
Contributor

AMollis commented May 6, 2024

@Hanning-Liu thank you for the issue you've reported. Unfortunately, this is not a bug in the MRTK3.

The issue is likely with your custom sharer. It's likely your OpenXR project is setup with Single Pass instance rendering.

Image

You can attempt to switch to "Mutli-pass" to confirm. However, it's highly recommended to use "single pass instancing" for the best performance. In which case you need to update your shader to support "single-pass instance". If you have further questions, please post in the discussion forum.

@AMollis AMollis closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2024
@AMollis AMollis added Status: Invalid Not a valid discussion topic, bug, or feature request. Status: External An issue caused by factors external to the MRTK project. labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: External An issue caused by factors external to the MRTK project. Status: Invalid Not a valid discussion topic, bug, or feature request. Type: Bug A problem with an existing feature that can be fixed with the next patched release.
Projects
None yet
Development

No branches or pull requests

4 participants