Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Call Stacks In Crash Reports] Redaction Levels #945

Open
issackjohn opened this issue Jan 27, 2025 · 2 comments
Open

[Call Stacks In Crash Reports] Redaction Levels #945

issackjohn opened this issue Jan 27, 2025 · 2 comments

Comments

@issackjohn
Copy link
Contributor

issackjohn commented Jan 27, 2025

We need to discuss the appropriate level of redaction for extension frames in call stacks.

There are three potential options to consider:

  • Full redaction
  • Per-frame redaction
  • No redaction for the main world

Discussion Points:

  • Is full redaction necessary, or can we consider per-frame redaction?
  • Should there be no redaction for the main world?

There was a rough consensus in the WebPerfWG that extension content was acceptable if it appeared in a place (main world) where it could be on the stack.

@issackjohn
Copy link
Contributor Author

issackjohn commented Jan 27, 2025

Must be a permissions issue but I can't add appropriate labels to the issue

@aluhrs13
Copy link
Contributor

It seems like per-frame redaction is the best path. That gives signal that there is a problem occurring that interacts with an extension, without exposing what or how.

Lack of a stack entirely feels like it could lead to a lot of issues in trying to interpret what's happening - Were we unable to get a stack? Did the page's processing pipeline drop the stack? Only redact the relevant frames gives something for the site owner to aggregate one instead of having a large "blank" bucket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants