Get correct message_source for deprecated messages (#311)

MichaelChirico · web-flow · commit 880218931a24 · 2024-03-26T17:27:18.000-07:00
diff --git a/R/get_po_messages.R b/R/get_po_messages.R
@@ -123,10 +123,11 @@ get_po_messages <- function(po_file) {
     msg_j = msg_j + 1L
   }
 
-  # somewhat hacky approach -- strip the comment markers & recurse
+  # somewhat hacky approach -- strip the comment markers & recurse;
+  #   retain the same file pattern to ensure 'message_source' is correct
   writeLines(
     gsub("^#~ ", "", grep("^#~ ", po_lines, value = TRUE)),
-    tmp <- tempfile()
+    tmp <- tempfile(pattern = basename(po_file))
   )
   on.exit(unlink(tmp))
   deprecated = get_po_messages(tmp)

Original file line number	Diff line number	Diff line change
`@@ -123,10 +123,11 @@ get_po_messages <- function(po_file) {`
`123`	`123`	`msg_j = msg_j + 1L`
`124`	`124`	`}`
`125`	`125`
`126`		`- # somewhat hacky approach -- strip the comment markers & recurse`
	`126`	`+ # somewhat hacky approach -- strip the comment markers & recurse;`
	`127`	`+ # retain the same file pattern to ensure 'message_source' is correct`
`127`	`128`	`writeLines(`
`128`	`129`	`gsub("^#~ ", "", grep("^#~ ", po_lines, value = TRUE)),`
`129`		`- tmp <- tempfile()`
	`130`	`+ tmp <- tempfile(pattern = basename(po_file))`
`130`	`131`	`)`
`131`	`132`	`on.exit(unlink(tmp))`
`132`	`133`	`deprecated = get_po_messages(tmp)`