Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change case on return value & format code for readability #2

Open
cliffhall opened this issue Sep 15, 2021 · 1 comment
Open

Change case on return value & format code for readability #2

cliffhall opened this issue Sep 15, 2021 · 1 comment

Comments

@cliffhall
Copy link

function royaltyInfo(uint256 _tokenId, uint256 _salePrice) external view override(IERC2981) returns (address Receiver, uint256 royaltyAmount) {

Readability is important in reference and framework code. Formatting it with that in mind (as we did in the ERC), will be appreciated by those who evaluate it when considering adoption.

function royaltyInfo(uint256 _tokenId, uint256 _salePrice) 
external 
view 
override(IERC2981) 
returns (address Receiver, uint256 royaltyAmount) { }

Also, return values should begin with lower case receiver not Receiver.

@MaxflowO2
Copy link
Owner

Yeah long night when I wrote this, but out of my silly season for a bit will update accordingly

MaxflowO2 pushed a commit that referenced this issue Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants