Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versionless Runtime Identifiers #1

Closed
LordBenjamin opened this issue Jan 4, 2019 · 2 comments
Closed

Versionless Runtime Identifiers #1

LordBenjamin opened this issue Jan 4, 2019 · 2 comments
Assignees
@LordBenjamin
Labels
enhancement New feature or request
Milestone
4.3.7

Comments

@LordBenjamin
Copy link
Owner

See matgr1/FreeImage-dotnet-core#12 (comment).

There is an issue when a .NET Core 2.1 project is published for the generic runtime identifiers (win-x64, win-x86 and linux-x64), the FreeImage native library is not copied to the output directory.

According to the RID graph if a project is published for RID win-x64 it will not include win7-x64.

Is it possible to add versionless RIDs to the package?
LordBenjamin added a commit that referenced this issue Jan 4, 2019
@LordBenjamin
Move DLLs from the win7-x86 / win7-x64 runtime folders to win-x86 / w…
44e41e6 
…in-x64.

Partially fixes #1.
@LordBenjamin LordBenjamin self-assigned this Jan 4, 2019
@LordBenjamin LordBenjamin added the enhancement New feature or request label Jan 4, 2019
@LordBenjamin LordBenjamin added this to the 4.3.7 milestone Jan 4, 2019
@LordBenjamin
Copy link
Owner Author

Need input / further research on genericising ubuntu.16.04-x64 and osx.10.10-x64 RIDs.

E.g. is it safe to just rename ubuntu.16.04-x64 to linux-x64, or is there something particularly Ubuntu 16.04 specific about this build of libfreeimage-3.17.0.so?

@LordBenjamin
Copy link
Owner Author

Tested current ubuntu.16.04-x64 build on openSUSE Tumbleweed (latest version) and it worked as expected.

Going to rename ubuntu.16.04-x64 to linux-x64 just now, may revisit in future if this causes issues.

@LordBenjamin LordBenjamin mentioned this issue Jan 5, 2019
Merged
LordBenjamin added a commit that referenced this issue Jan 5, 2019
@LordBenjamin
Versionless RIDs
ac9d457 
* Rename win7-x86 / win7-x64 runtime folders to win-x86 / win-x64.
* Rename ubuntu.16.04-x64 to linux-x64. Tested on openSUSE Tumbleweed.

Closes #1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LordBenjamin LordBenjamin

Labels
enhancement New feature or request
Projects
None yet
Milestone
4.3.7
Development

No branches or pull requests
1 participant
@LordBenjamin