CertVerifier Deployer #1302
CertVerifier Deployer #1302
Conversation
| This script can be used to deploy an EigenDACertVerifier contract with specified security thresholds and quorum numbers required | ||
|
|
There was a problem hiding this comment.
let's specify that deployments can only be done on an Ethereum network and this isn't supported for L3 rollups
| bytes memory raw = stdJson.parseRaw(data, ".eigenDAServiceManager"); | ||
| eigenDAServiceManager = abi.decode(raw, (address)); | ||
|
|
||
| raw = stdJson.parseRaw(data, ".eigenDAThresholdRegistry"); | ||
| eigenDAThresholdRegistry = abi.decode(raw, (address)); |
There was a problem hiding this comment.
why not used vm.envAddress("eigenDAServiceManager") and reference env as a .env instead of json? iiuc it'd be a bit of a nightmare though when reading structured values (i.e, defaultSecurityThresholds)
There was a problem hiding this comment.
nit - would it maybe be cleaner to define some struct DeploymentParams and decode the json input into that? https://book.getfoundry.sh/cheatcodes/parse-json#decoding-json-objects-into-solidity-structs
There was a problem hiding this comment.
ya json is a bit more straightforward to decode with the forge scripts
|
|
||
| console.log("Deployed new EigenDACertVerifier at address: ", eigenDACertVerifier); | ||
|
|
||
| string memory outputPath = "script/deploy/certverifier/output/certverifier_deployment_data.json"; |
There was a problem hiding this comment.
nit - wouldn't this override an existing deployment's metadata?
There was a problem hiding this comment.
ya I could add a input to pass in output file name
| "defaultSecurityThresholds": { | ||
| "0_confirmationThreshold": 55, | ||
| "1_adversaryThreshold": 33 | ||
| }, | ||
|
|
||
| "quorumNumbersRequired": "0x0001" |
There was a problem hiding this comment.
if I'm a customer and I wanna leverage custom quourm/threshold, do I just update these fields here?
There was a problem hiding this comment.
yup would just need to update quorumNumbersRequired
| @@ -0,0 +1,42 @@ | |||
| ## EigenDA Cert Verfier Deployer | |||
|
|
|||
| This script can be used to deploy an EigenDACertVerifier contract with specified security thresholds and quorum numbers required | |||
There was a problem hiding this comment.
nit:
| This script can be used to deploy an EigenDACertVerifier contract with specified security thresholds and quorum numbers required | |
| This script can be used to deploy an EigenDACertVerifier contract with custom security thresholds and quorum numbers |
| ```json | ||
| { | ||
| "eigenDACertVerifier": "0x..." | ||
| } | ||
| ``` |
There was a problem hiding this comment.
nit: is there any utility in capturing deployment inputs here?
There was a problem hiding this comment.
if you think its useful I can add it
Adds a script to deploy a CertVerifier with specified thresholds and required quorums based on a network config