Fix clippy alerts

Author: survived

.github/workflows/rust.yml

@@ -58,9 +58,9 @@ jobs:
       with:
         cache-on-failure: "true"
     - name: Run clippy
-      run: cargo clippy --all --lib --exclude cggmp21-tests -- --no-deps -D clippy::all -D clippy::unwrap_used -D clippy::expect_used
+      run: cargo clippy --all --all-features --lib --exclude cggmp21-tests -- --no-deps -D clippy::all -D clippy::unwrap_used -D clippy::expect_used
     - name: Run clippy tests
-      run: cargo clippy --tests --lib -- -D clippy::all
+      run: cargo clippy --tests --all-features --lib -- -D clippy::all
   bench:
     runs-on: ubuntu-latest
     permissions:

cggmp21-keygen/src/lib.rs

@@ -1,5 +1,5 @@
 //! Threshold and non-threshold CGGMP21 DKG
-#![allow(non_snake_case)]
+#![allow(non_snake_case, clippy::too_many_arguments)]
 
 pub mod progress;
 pub mod security_level;

key-share/src/lib.rs

@@ -151,6 +151,7 @@ impl<E: Curve> Validate for DirtyCoreKeyShare<E> {
     }
 }
 
+#[allow(clippy::nonminimal_bool)]
 fn validate_vss_key_share<E: Curve>(
     key_share: &DirtyCoreKeyShare<E>,
     n: u16,

key-share/src/utils.rs

@@ -1,5 +1,11 @@
-#[cfg(feature = "serde")]
+#[cfg(all(feature = "serde", feature = "hd-wallets"))]
 mod hex_or_bin;
 
-#[cfg(feature = "serde")]
+#[cfg(all(feature = "serde", feature = "hd-wallets"))]
 pub use hex_or_bin::HexOrBin;
+
+// `hex` dependnecy is only needed when both `serde` and `hd-wallets` features are on.
+// However, we can't express that in Cargo.toml, so whenever `serde` feature is on and
+// `hd-wallets` is off, unused dependency is introduced.
+#[cfg(all(feature = "serde", not(feature = "hd-wallets")))]
+use hex as _;

key-share/src/valid.rs

@@ -216,7 +216,7 @@ where
     where
         S: serde::Serializer,
     {
-        (&**self).serialize(serializer)
+        (**self).serialize(serializer)
     }
 }
 

tests/src/lib.rs

@@ -169,8 +169,7 @@ pub fn convert_from_stark_scalar(
 pub fn random_derivation_path(rng: &mut impl rand::RngCore) -> Vec<u32> {
     use rand::Rng;
     let len = rng.gen_range(1..=3);
-    let path = std::iter::repeat_with(|| rng.gen_range(0..cggmp21::slip_10::H))
+    std::iter::repeat_with(|| rng.gen_range(0..cggmp21::slip_10::H))
         .take(len)
-        .collect::<Vec<_>>();
-    path
+        .collect::<Vec<_>>()
 }