Enhance test_show_chassis_modules_status to check expected physical s… (sonic-net#17193)

* Enhance test_show_chassis_modules_status to check expected physical slot numbers based on Inventory Truth

Author: gechiang

tests/platform_tests/cli/test_show_chassis_module.py

@@ -1,6 +1,7 @@
 import logging
 import pytest
 from tests.common.helpers.assertions import pytest_assert
+from tests.common.utilities import get_inventory_files, get_host_visible_vars
 from .util import get_field_range, get_fields, get_skip_mod_list, get_skip_logical_module_list
 
 logger = logging.getLogger('__name__')
@@ -12,6 +13,13 @@
 CMD_SHOW_CHASSIS_MODULE = "show chassis modules"
 
 
+@pytest.fixture(scope='module')
+def dut_vars(duthosts, enum_rand_one_per_hwsku_hostname, request):
+    inv_files = get_inventory_files(request)
+    dut_vars = get_host_visible_vars(inv_files, enum_rand_one_per_hwsku_hostname)
+    yield dut_vars
+
+
 def parse_chassis_module(output, expected_headers):
     assert len(output) > 2
     f_ranges = get_field_range(output[1])
@@ -33,13 +41,32 @@ def parse_chassis_module(output, expected_headers):
     return result
 
 
-def test_show_chassis_module_status(duthosts, enum_rand_one_per_hwsku_hostname):
+def test_show_chassis_module_status(duthosts, enum_rand_one_per_hwsku_hostname, dut_vars):
     cmd = " ".join([CMD_SHOW_CHASSIS_MODULE, "status"])
     logger.info("verifying output of cli command {}".format(cmd))
     duthost = duthosts[enum_rand_one_per_hwsku_hostname]
     exp_headers = ["Name", "Description", "Physical-Slot", "Oper-Status", "Admin-Status"]
     skip_mod_list = get_skip_mod_list(duthost)
     skip_logical_lc_list = get_skip_logical_module_list(duthost)
+    """
+    Gather expected module slot data from a inventory file if 'module_slot_info' is defined in the inventory
+    # Sample inventory with module_slot_info:
+    str-sonic-chassis-01-sup:
+        ansible_host: 10.251.0.188
+        model: SOME-VENDOR-MODEL
+        serial: BADC0FFEE123
+        base_mac: 38:8a:29:13:45:67
+        module_slot_info:
+            "FABRIC-CARD0": "1"
+            "FABRIC-CARD3": "3"
+            "FABRIC-CARD4": "4"
+            "LINE-CARD1": "2"
+            "LINE-CARD3": "4"
+            "SUPERVISOR0": "Y"
+    """
+    exp_module_slot_info = {}
+    if 'module_slot_info' in dut_vars:
+        exp_module_slot_info = dut_vars['module_slot_info']
 
     output = duthost.command(cmd)
     res = parse_chassis_module(output['stdout_lines'], exp_headers)
@@ -62,6 +89,17 @@ def test_show_chassis_module_status(duthosts, enum_rand_one_per_hwsku_hostname):
             pytest_assert(res[mod_idx]['Oper-Status'] == 'Online',
                           "Oper-status for slot {} should be Online but it is {}".format(
                               mod_idx, res[mod_idx]['Oper-Status']))
+            # If inventory contains physical slot info, perform expected slot number check
+            if exp_module_slot_info:
+                pytest_assert(mod_idx in exp_module_slot_info,
+                              "Module {} is expected to be present but it is missing".format(
+                                  mod_idx))
+                pytest_assert(res[mod_idx]['Physical-Slot'] == exp_module_slot_info[mod_idx],
+                              "Module {} expected slot {} not matching show output {}".format(
+                                  mod_idx, exp_module_slot_info[mod_idx], res[mod_idx]['Physical-Slot']))
+            else:
+                # In case Inventory file does not have the slot info, just log it but no need to fail the test
+                logger.info("Inventory file has no record of module_slot_info")
 
 
 def test_show_chassis_module_midplane_status(duthosts, enum_rand_one_per_hwsku_hostname):