From e53c3949188ec17f9894199367aaeb2953fb2df4 Mon Sep 17 00:00:00 2001 From: Phu Ngo <12547020+NgoKimPhu@users.noreply.github.com> Date: Tue, 30 Jul 2024 17:43:34 +0700 Subject: [PATCH] chore: add back service_name for backwards-compat; fix typos in build.yaml --- .github/workflows/build.yaml | 4 ++-- .github/workflows/release.yaml | 7 +++++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 3c66f1e..dea45bc 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -77,7 +77,7 @@ jobs: labels: | kyber.network.schema-version=1.0 kyber.network.name=${{ inputs.service }} - kyber.network.version=${{ steps.prepare.outputs.version_tag }} + kyber.network.version=${{ inputs.version }} kyber.network.vcs-ref=${{ github.sha }} - uses: docker/build-push-action@v6 with: @@ -86,7 +86,7 @@ jobs: build-args: | GH_USER=kyber-ci-bot tags: ${{ steps.meta.outputs.tags }} - labels: ${{ steps.metadata.outputs.labels }} + labels: ${{ steps.meta.outputs.labels }} secrets: | "gh_pat=${{ secrets.GH_PAT }}" cache-from: type=gha diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 42d094b..2354a6e 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -17,6 +17,9 @@ on: description: 'Service repo name' type: string required: true + service_name: + description: 'Service name. Default to service' + type: string version: description: 'Release version' type: string @@ -66,8 +69,8 @@ jobs: git push origin "refs/tags/$VERSION" - uses: softprops/action-gh-release@v2 with: - # token: ${{ secrets.GH_PAT }} tag_name: ${{ env.VERSION }} generate_release_notes: true - name: ${{ inputs.release_name }} + name: ${{ inputs.release_name || + format('{0} {1}', inputs.service_name || inputs.service, env.VERSION) }} body: ${{ inputs.release_body }}