Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component - File uploader #10

Closed
lw-cdm opened this issue Dec 23, 2022 · 3 comments · Fixed by #63 or #92
Closed

Component - File uploader #10

lw-cdm opened this issue Dec 23, 2022 · 3 comments · Fixed by #63 or #92
Assignees
@lw-cdm
Labels
2023-w05-06 2023-w07-08 need-improve
Milestone
Milestone 5

Comments

@lw-cdm
Copy link

lw-cdm commented Dec 23, 2022 •
edited by sokol142
Loading

Design review: 4.5-Input: https://www.figma.com/file/eOUqz887O5EKZwIJhJQ13U/SubWallet-UI-Base?node-id=494%3A6768&t=f9u4O5zfC6AWcOah-4
Test URL: https://ui-preview.subwallet.app/?path=/story/form-single-file-dragger--default
@saltict saltict added w53 and removed w53 labels Dec 23, 2022
@saltict saltict assigned lw-cdm and unassigned Quangdm-cdm Jan 3, 2023
@lw-cdm lw-cdm mentioned this issue Jan 5, 2023
Merged
@saltict saltict linked a pull request Jan 5, 2023 that will close this issue
[Issue-6,9,10] Update file upload, icon components, switch storybook #63
Merged
@sokol142
Copy link

sokol142 commented Jan 12, 2023 •
edited
Loading

Design review: 4.5: Input
Please check:

  • Missing the component when active
  • Recheck with design

Image

@lw-cdm lw-cdm linked a pull request Jan 16, 2023 that will close this issue
[Issue 10,46] Fix some issues related to reviewer comments #92
Merged
@sokol142
Copy link

Require design for case: error file

@sokol142
Copy link

sokol142 commented Feb 8, 2023 •
edited
Loading

@lw-cdm The design is already available: https://www.figma.com/file/eOUqz887O5EKZwIJhJQ13U/SubWallet-UI-Base?node-id=1543%3A10136&t=FPAfgCVBcWQtUJz0-4

  • Please update the components in case the file is error => Implement when upgrade UI for extension

@hieudd hieudd added this to the Milestone 5 milestone Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lw-cdm lw-cdm

Labels
2023-w05-06 2023-w07-08 need-improve
Projects
None yet
Milestone
Milestone 5
5 participants
@hieudd @saltict @Quangdm-cdm @lw-cdm @sokol142