Skip to content

Commit 252898e

Browse files
authored
Revert per-config samples install directories (#113)
* Revert install tree modifications This reverts the changes made on #88 that modified the install location of the samples * Make vendors path not depend on hard-coded POCL install path
1 parent dbcae2c commit 252898e

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

.github/workflows/presubmit.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -658,7 +658,8 @@ jobs:
658658
if [[ "${{matrix.GEN}}" == "Ninja Multi-Config" && ! `which ninja` ]]; then brew install ninja; fi &&
659659
# We need to provide an OpenCL driver for Intel CPU on mac
660660
brew install pocl
661-
echo "OCL_ICD_VENDORS=/opt/homebrew/Cellar/pocl/6.0/etc/OpenCL/vendors" >> $GITHUB_ENV
661+
POCL_INSTALL_PATH=$(brew --prefix pocl)
662+
echo "OCL_ICD_VENDORS=$POCL_INSTALL_PATH/etc/OpenCL/vendors" >> $GITHUB_ENV
662663
cmake --version
663664
664665
- name: Install dependencies (Homebrew)

samples/CMakeLists.txt

+10-11
Original file line numberDiff line numberDiff line change
@@ -130,18 +130,17 @@ macro(add_sample)
130130
)
131131

132132
foreach(CONFIG ${OPENCL_SAMPLE_CONFIGS})
133-
install(TARGETS ${OPENCL_SAMPLE_TARGET} CONFIGURATIONS ${CONFIG} DESTINATION ${CMAKE_INSTALL_BINDIR}/${CONFIG})
134-
install(FILES ${OPENCL_SAMPLE_KERNELS} CONFIGURATIONS ${CONFIG} DESTINATION ${CMAKE_INSTALL_BINDIR}/${CONFIG})
135-
install(FILES ${OPENCL_SAMPLE_SHADERS} CONFIGURATIONS ${CONFIG} DESTINATION ${CMAKE_INSTALL_BINDIR}/${CONFIG})
136-
if(OPENCL_SDK_TEST_SAMPLES AND OPENCL_SAMPLE_TEST)
137-
add_test(
138-
NAME "${OPENCL_SAMPLE_TARGET}_${CONFIG}"
139-
COMMAND ${OPENCL_SAMPLE_TARGET}
140-
CONFIGURATIONS ${CONFIG}
141-
WORKING_DIRECTORY "$<TARGET_FILE_DIR:${OPENCL_SAMPLE_TARGET}>"
142-
)
143-
endif()
133+
install(TARGETS ${OPENCL_SAMPLE_TARGET} CONFIGURATIONS ${CONFIG} DESTINATION ${CMAKE_INSTALL_BINDIR})
134+
install(FILES ${OPENCL_SAMPLE_KERNELS} CONFIGURATIONS ${CONFIG} DESTINATION ${CMAKE_INSTALL_BINDIR})
135+
install(FILES ${OPENCL_SAMPLE_SHADERS} CONFIGURATIONS ${CONFIG} DESTINATION ${CMAKE_INSTALL_BINDIR})
144136
endforeach()
137+
if(OPENCL_SDK_TEST_SAMPLES AND OPENCL_SAMPLE_TEST)
138+
add_test(
139+
NAME ${OPENCL_SAMPLE_TARGET}
140+
COMMAND ${OPENCL_SAMPLE_TARGET}
141+
WORKING_DIRECTORY ${CMAKE_CURRENT_LIST_DIR}
142+
)
143+
endif()
145144
endmacro()
146145

147146

0 commit comments

Comments
 (0)