1616
1717// If you feel like getting in touch with us, you can do so at info@botlabs.org
1818
19- use crate :: { migrations:: StakingStorageVersion , CandidateCount , CandidatePool , Config , StorageVersion } ;
20- use frame_support:: { dispatch:: Weight , storage:: StorageValue , traits:: Get } ;
19+ use crate :: {
20+ migrations:: StakingStorageVersion ,
21+ set:: OrderedSet ,
22+ types:: { BalanceOf , Candidate , Stake , TotalStake } ,
23+ CandidateCount , CandidatePool , Config , StorageVersion , TopCandidates , TotalCollatorStake ,
24+ } ;
25+ use frame_support:: {
26+ dispatch:: Weight ,
27+ storage:: { IterableStorageMap , StorageValue } ,
28+ traits:: Get ,
29+ } ;
2130
2231#[ cfg( feature = "try-runtime" ) ]
2332pub ( crate ) fn pre_migrate < T : Config > ( ) -> Result < ( ) , & ' static str > {
@@ -31,21 +40,57 @@ pub(crate) fn migrate<T: Config>() -> Weight {
3140 // Kill selected candidates list
3241 old:: SelectedCandidates :: < T > :: kill ( ) ;
3342
34- // count candidates
35- let counter: u32 = CandidatePool :: < T > :: iter ( ) . fold ( 0 , |acc, _| acc. saturating_add ( 1 ) ) ;
43+ // migrate CandidatePool to TopCandidates
44+ // DANGER: this needs to happen before we write to the new CandidatePool!
45+ let old_candidate_pool = old:: CandidatePool :: < T > :: get ( ) ;
46+ TopCandidates :: < T > :: put ( old_candidate_pool) ;
47+ old:: CandidatePool :: < T > :: kill ( ) ;
48+
49+ // Copy over total
50+ let total = old:: Total :: < T > :: get ( ) ;
51+ TotalCollatorStake :: < T > :: set ( total) ;
52+ old:: Total :: < T > :: kill ( ) ;
53+
54+ // kill, copy & count candidates
55+ let counter: u32 = old:: CollatorState :: < T > :: drain ( ) . fold ( 0 , |acc, ( key, candidate) | {
56+ CandidatePool :: < T > :: insert ( & key, candidate) ;
57+ acc. saturating_add ( 1 )
58+ } ) ;
3659 CandidateCount :: < T > :: put ( counter) ;
3760
3861 // update storage version
3962 StorageVersion :: < T > :: put ( StakingStorageVersion :: V5 ) ;
4063 log:: info!( "Completed staking migration to StakingStorageVersion::V5" ) ;
4164
42- T :: DbWeight :: get ( ) . reads_writes ( counter. saturating_add ( 2 ) . into ( ) , 3 )
65+ // Writes: 3 * Kill, 3 * Put, `counter` * inserts, at max 32 additional kills <
66+ // counter + 38 Reads: (counter + 2) * get
67+ T :: DbWeight :: get ( ) . reads_writes ( counter. saturating_add ( 38 ) . into ( ) , counter. saturating_add ( 2 ) . into ( ) )
4368}
4469
4570#[ cfg( feature = "try-runtime" ) ]
4671pub ( crate ) fn post_migrate < T : Config > ( ) -> Result < ( ) , & ' static str > {
72+ use sp_runtime:: SaturatedConversion ;
73+
4774 assert_eq ! ( StorageVersion :: <T >:: get( ) , StakingStorageVersion :: V5 ) ;
48- assert ! ( CandidateCount :: <T >:: get( ) > T :: MinCollators :: get( ) ) ;
75+ log:: info!(
76+ "CandidateCount = {} >= {} = MinCollators" ,
77+ CandidateCount :: <T >:: get( ) ,
78+ T :: MinCollators :: get( )
79+ ) ;
80+ assert ! ( CandidateCount :: <T >:: get( ) >= T :: MinCollators :: get( ) ) ;
81+ log:: info!(
82+ "TopCandidates = {} >= {} = MinCollators" ,
83+ TopCandidates :: <T >:: get( ) . len( ) ,
84+ T :: MinCollators :: get( )
85+ ) ;
86+ assert ! ( TopCandidates :: <T >:: get( ) . len( ) . saturated_into:: <u32 >( ) >= T :: MinCollators :: get( ) ) ;
87+ assert ! ( TopCandidates :: <T >:: get( ) . len( ) . saturated_into:: <u32 >( ) <= CandidateCount :: <T >:: get( ) ) ;
88+ assert ! (
89+ TotalCollatorStake :: <T >:: get( ) . collators
90+ >= CandidateCount :: <T >:: get( ) . saturated_into:: <BalanceOf <T >>( ) * T :: MinCollatorStake :: get( )
91+ ) ;
92+ let counter: u32 = old:: CollatorState :: < T > :: iter ( ) . fold ( 0 , |acc, ( _, _) | acc. saturating_add ( 1 ) ) ;
93+ assert ! ( counter == 0 ) ;
4994 Ok ( ( ) )
5095}
5196
@@ -60,7 +105,10 @@ pub(crate) mod old {
60105
61106 decl_storage ! {
62107 trait Store for OldPallet <T : Config > as ParachainStaking {
108+ pub ( crate ) Total : TotalStake <BalanceOf <T >>;
63109 pub ( crate ) SelectedCandidates : Vec <T :: AccountId >;
110+ pub ( crate ) CollatorState : map hasher( twox_64_concat) T :: AccountId => Option <Candidate <T :: AccountId , BalanceOf <T >, T :: MaxDelegatorsPerCollator >>;
111+ pub ( crate ) CandidatePool : OrderedSet <Stake <T :: AccountId , BalanceOf <T >>, T :: MaxTopCandidates >;
64112 }
65113 }
66114}
0 commit comments