chore: fix benchmarking (#702)

# Fixes [#3591](KILTprotocol/ticket#3591)

This PR fixes the benchmarking logic. Instead of piping the output into
a specific file, the default value is used, which is the pallet name
itself. This change is necessary for pallets with multiple instances in
the runtime.

While running the benchmarks, some extrinsics failed due to insufficient
funds of the submitter. I'm not sure of the underlying issue, but the
tests are still passing. Simply increasing the funds should resolve it.

Author: Ad96el

pallets/parachain-staking/src/benchmarking.rs

@@ -438,7 +438,7 @@ benchmarks! {
 		assert_eq!(DelegatorState::<T>::get(&delegator).unwrap().amount, amount);
 
 		// increase stake so we can unstake, because current stake is minimum
-		T::Currency::set_balance(&delegator, T::CurrencyBalance::from(10u128.pow(15)));
+		T::Currency::set_balance(&delegator, T::CurrencyBalance::from(10u128.pow(17)));
 		assert_ok!(Pallet::<T>::delegator_stake_more(RawOrigin::Signed(delegator.clone()).into(), T::CurrencyBalance::from(u as u64)));
 		assert_eq!(DelegatorState::<T>::get(&delegator).unwrap().amount, amount + T::CurrencyBalance::from(u as u64));
 
@@ -474,7 +474,7 @@ benchmarks! {
 		assert_eq!(DelegatorState::<T>::get(&delegator).unwrap().amount, T::MinDelegatorStake::get());
 
 		// increase stake so we can unstake, because current stake is minimum
-		T::Currency::set_balance(&delegator, T::CurrencyBalance::from(10u128.pow(15)));
+		T::Currency::set_balance(&delegator, T::CurrencyBalance::from(10u128.pow(17)));
 		assert_ok!(Pallet::<T>::delegator_stake_more(RawOrigin::Signed(delegator.clone()).into(), amount + amount));
 		assert_eq!(DelegatorState::<T>::get(&delegator).unwrap().amount, T::MinDelegatorStake::get() + amount + amount);
 
@@ -511,7 +511,7 @@ benchmarks! {
 		assert_eq!(DelegatorState::<T>::get(&delegator).unwrap().amount, T::MinDelegatorStake::get());
 
 		// increase stake so we can unstake, because current stake is minimum
-		T::Currency::set_balance(&delegator, T::CurrencyBalance::from(10u128.pow(15)));
+		T::Currency::set_balance(&delegator, T::CurrencyBalance::from(10u128.pow(17)));
 		assert_ok!(Pallet::<T>::delegator_stake_more(RawOrigin::Signed(delegator.clone()).into(), amount + amount));
 		assert_eq!(DelegatorState::<T>::get(&delegator).unwrap().amount, T::MinDelegatorStake::get() + amount + amount);
 
@@ -533,7 +533,7 @@ benchmarks! {
 		let u in 1 .. (T::MaxUnstakeRequests::get() - 1);
 
 		let candidate = account("collator", 0u32, COLLATOR_ACCOUNT_SEED);
-		let free_balance = T::CurrencyBalance::from(10u128.pow(15));
+		let free_balance = T::CurrencyBalance::from(10u128.pow(20));
 		let stake = T::MinCollatorCandidateStake::get();
 		T::Currency::set_balance(&candidate, free_balance);
 		assert_ok!(Pallet::<T>::join_candidates(

runtimes/peregrine/src/lib.rs

@@ -517,7 +517,7 @@ impl pallet_collective::Config<CouncilCollective> for Runtime {
 	type MaxProposals = constants::governance::CouncilMaxProposals;
 	type MaxMembers = constants::governance::CouncilMaxMembers;
 	type DefaultVote = pallet_collective::PrimeDefaultVote;
-	type WeightInfo = weights::pallet_collective::WeightInfo<Runtime>;
+	type WeightInfo = weights::pallet_collective_council::WeightInfo<Runtime>;
 	type SetMembersOrigin = EnsureRoot<AccountId>;
 }
 
@@ -531,7 +531,7 @@ impl pallet_collective::Config<TechnicalCollective> for Runtime {
 	type MaxProposals = constants::governance::TechnicalMaxProposals;
 	type MaxMembers = constants::governance::TechnicalMaxMembers;
 	type DefaultVote = pallet_collective::PrimeDefaultVote;
-	type WeightInfo = weights::pallet_collective::WeightInfo<Runtime>;
+	type WeightInfo = weights::pallet_collective_technical_committee::WeightInfo<Runtime>;
 	type SetMembersOrigin = EnsureRoot<AccountId>;
 }
 

runtimes/peregrine/src/weights/pallet_dmp_queue.rs runtimes/peregrine/src/weights/cumulus_pallet_dmp_queue.rs

@@ -19,23 +19,25 @@
 //! Autogenerated weights for `cumulus_pallet_dmp_queue`
 //!
 //! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 33.0.0
-//! DATE: 2024-06-21, STEPS: `50`, REPEAT: `20`, LOW RANGE: `[]`, HIGH RANGE: `[]`
+//! DATE: 2024-08-23, STEPS: `50`, REPEAT: `20`, LOW RANGE: `[]`, HIGH RANGE: `[]`
 //! WORST CASE MAP SIZE: `1000000`
 //! HOSTNAME: `eyrie-7`, CPU: `Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz`
 //! EXECUTION: , WASM-EXECUTION: Compiled, CHAIN: Some("dev"), DB CACHE: 1024
 
 // Executed Command:
-// ./target/debug/kilt-parachain
+// ./target/release/kilt-parachain
 // benchmark
 // pallet
 // --template=.maintain/runtime-weight-template.hbs
 // --header=HEADER-GPL
 // --wasm-execution=compiled
+// --heap-pages=4096
+// --steps=50
+// --repeat=20
 // --chain=dev
-// --pallet
-// cumulus-pallet-dmp-queue
+// --pallet=cumulus-pallet-dmp-queue
 // --extrinsic=*
-// --output=./spend.rs
+// --output=./runtimes/peregrine/src/weights/cumulus_pallet_dmp_queue.rs
 
 #![cfg_attr(rustfmt, rustfmt_skip)]
 #![allow(unused_parens)]
@@ -63,8 +65,8 @@ impl<T: frame_system::Config> cumulus_pallet_dmp_queue::WeightInfo for WeightInf
 		// Proof Size summary in bytes:
 		//  Measured:  `65764`
 		//  Estimated: `69229`
-		// Minimum execution time: 698_233_000 picoseconds.
-		Weight::from_parts(701_118_000, 0)
+		// Minimum execution time: 131_132_000 picoseconds.
+		Weight::from_parts(132_136_000, 0)
 			.saturating_add(Weight::from_parts(0, 69229))
 			.saturating_add(T::DbWeight::get().reads(5))
 			.saturating_add(T::DbWeight::get().writes(5))
@@ -79,8 +81,8 @@ impl<T: frame_system::Config> cumulus_pallet_dmp_queue::WeightInfo for WeightInf
 		// Proof Size summary in bytes:
 		//  Measured:  `65660`
 		//  Estimated: `69125`
-		// Minimum execution time: 487_148_000 picoseconds.
-		Weight::from_parts(511_739_000, 0)
+		// Minimum execution time: 65_674_000 picoseconds.
+		Weight::from_parts(66_685_000, 0)
 			.saturating_add(Weight::from_parts(0, 69125))
 			.saturating_add(T::DbWeight::get().reads(3))
 			.saturating_add(T::DbWeight::get().writes(2))
@@ -103,8 +105,8 @@ impl<T: frame_system::Config> cumulus_pallet_dmp_queue::WeightInfo for WeightInf
 		// Proof Size summary in bytes:
 		//  Measured:  `65794`
 		//  Estimated: `69259`
-		// Minimum execution time: 753_994_000 picoseconds.
-		Weight::from_parts(757_367_000, 0)
+		// Minimum execution time: 126_289_000 picoseconds.
+		Weight::from_parts(127_492_000, 0)
 			.saturating_add(Weight::from_parts(0, 69259))
 			.saturating_add(T::DbWeight::get().reads(6))
 			.saturating_add(T::DbWeight::get().writes(6))
@@ -121,8 +123,8 @@ impl<T: frame_system::Config> cumulus_pallet_dmp_queue::WeightInfo for WeightInf
 		// Proof Size summary in bytes:
 		//  Measured:  `65690`
 		//  Estimated: `69155`
-		// Minimum execution time: 532_680_000 picoseconds.
-		Weight::from_parts(539_061_000, 0)
+		// Minimum execution time: 59_799_000 picoseconds.
+		Weight::from_parts(60_416_000, 0)
 			.saturating_add(Weight::from_parts(0, 69155))
 			.saturating_add(T::DbWeight::get().reads(4))
 			.saturating_add(T::DbWeight::get().writes(3))

runtimes/peregrine/src/weights/mod.rs

@@ -19,19 +19,20 @@
 
 pub mod attestation;
 pub mod ctype;
+pub mod cumulus_pallet_dmp_queue;
 pub mod cumulus_pallet_parachain_system;
 pub mod delegation;
 pub mod did;
 pub mod frame_system;
 pub mod pallet_asset_switch;
 pub mod pallet_assets;
 pub mod pallet_balances;
-pub mod pallet_collective;
+pub mod pallet_collective_council;
+pub mod pallet_collective_technical_committee;
 pub mod pallet_democracy;
 pub mod pallet_deposit_storage;
 pub mod pallet_did_lookup;
 pub mod pallet_dip_provider;
-pub mod pallet_dmp_queue;
 pub mod pallet_indices;
 pub mod pallet_inflation;
 pub mod pallet_membership;