Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some of the CI tests fail when using MMTk #57103

Open
udesou opened this issue Jan 20, 2025 · 0 comments
Open

Some of the CI tests fail when using MMTk #57103

udesou opened this issue Jan 20, 2025 · 0 comments
Labels
GC: MMTK MMTK GC integration GC Garbage collector test This change adds or pertains to unit tests

Comments

@udesou
Copy link
Contributor

udesou commented Jan 20, 2025 •
edited
Loading

Some Julia CI tests are currently incompatible with MMTk. They are related to:

  • jl_n_gcthreads is set to 0 for MMTk since it uses its own worker threads. The tests in cmdlineargs.jl that are related to --gc-threads=X currently fail.
  • MMTk does not support dumping a heap snapshot (at least not in the same format as the stock GC), some tests fail for this reason.
  • When doing fastpath allocation we currently do not have a callback for the allocation profiler; some of the tests related to codegen and the allocation profiler fail when using MMTk.
  • This test may fail, which I think is also because of how fastpath allocation works. (see also Failed test/checked: Evaluated: 0 ≈ 1 (rtol=0.9) mmtk/mmtk-julia#209)
  • MMTk uses a different logging style than the stock GC. This test in misc.jl fails.
  • --heap-size-hint is not implemented by MMTk since it only supports a hard heap limit. The tests related to that also fail.
  • Some GC tests rely on the FULL_SWEEP_REASONS variable, which is specific to the stock GC. Furthermore, tests that check for page utilization also fail.

This issue is to document these tests until we decide whether they should be specific to the stock GC or until we implement the same semantics for MMTk (or change the semantics such the tests are compatible with both GCs).
@udesou udesou added GC Garbage collector test This change adds or pertains to unit tests labels Jan 20, 2025
@udesou udesou mentioned this issue Jan 20, 2025
Merged
d-netto pushed a commit that referenced this issue Jan 24, 2025
@udesou
Skip some stock GC-specific tests when using MMTk (#57104)
899d2f5 
As noted in #57103, there are a
few tests that are specific to the stock GC and will fail for MMTk. For
now, this PR simply skips those tests when not using the stock GC until
we agree on how to approach the incompatibilities described in the
issue.
@udesou udesou added the GC: MMTK MMTK GC integration label Jan 28, 2025
@udesou udesou mentioned this issue Feb 7, 2025
Merged
d-netto pushed a commit that referenced this issue Feb 8, 2025
@udesou
Updating binding version to fix MMTk CI (#57298)
72f8a10 
Updating mmtk-julia version to include
mmtk/mmtk-julia#228 and fix the MMTk CI.

I've also changed the allocation profiler tests to skip all tests
instead of just a few since I've seen some spurious errors - they should
all be related though, we need to make sure the profiler accounts for
fastpath allocation (see
#57103)

This should fix #57306.
KristofferC pushed a commit that referenced this issue Feb 11, 2025
@udesou @KristofferC
Updating binding version to fix MMTk CI (#57298)
24ad17b 
Updating mmtk-julia version to include
mmtk/mmtk-julia#228 and fix the MMTk CI.

I've also changed the allocation profiler tests to skip all tests
instead of just a few since I've seen some spurious errors - they should
all be related though, we need to make sure the profiler accounts for
fastpath allocation (see
#57103)

This should fix #57306.

(cherry picked from commit 72f8a10)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GC: MMTK MMTK GC integration GC Garbage collector test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@udesou