Merge pull request #259 from JuliaGPU/jps/fix-signbit-return

math: Make signbit return Bool

Author: jpsamaroo

src/device/gcn/math.jl

@@ -63,7 +63,7 @@ for jltype in (Float32, Float64)
     push!(MATH_INTRINSICS, GCNIntrinsic(:isfinite; inp_args=(jltype,), out_arg=Int32, tobool=true))
     push!(MATH_INTRINSICS, GCNIntrinsic(:isinf; inp_args=(jltype,), out_arg=Int32, tobool=true))
     push!(MATH_INTRINSICS, GCNIntrinsic(:isnan; inp_args=(jltype,), out_arg=Int32, tobool=true))
-    push!(MATH_INTRINSICS, GCNIntrinsic(:signbit; inp_args=(jltype,), out_arg=Int32))
+    push!(MATH_INTRINSICS, GCNIntrinsic(:signbit; inp_args=(jltype,), out_arg=Int32, tobool=true))
 end
 
 for intr in MATH_INTRINSICS

test/device/math.jl

@@ -16,9 +16,11 @@ using Base.FastMath
                    isdefined(SpecialFunctions, jlintr) ? SpecialFunctions :
                    nothing)
         modname !== nothing || continue
+
         # FIXME: Handle all input and output args
         T = intr.inp_args[1]
         intr_kern = Symbol("intr_$(jlintr)_$T")
+
         @eval begin
             function $intr_kern(out, a)
                 i = Device.workitemIdx().x
@@ -38,6 +40,8 @@ using Base.FastMath
             end
             len = prod(dims)
 
+            @test only(Base.return_types($modname.$jlintr, (eltype(d_a),))) === eltype(d_out)
+
             wait(@roc groupsize=len $intr_kern(d_out, d_a))
             out = Array(d_out)
             @test $modname.$jlintr.(a) ≈ out