Skip to content

Commit f65720c

Browse files
authored
Fix tests on 1.10 (#168)
1 parent ec66ad4 commit f65720c

File tree

2 files changed

+36
-7
lines changed

2 files changed

+36
-7
lines changed

.github/workflows/ci.yml

+2
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ on:
66
- master
77
tags:
88
- '*'
9+
schedule:
10+
- cron: '0 0 * * 1' # runs 00:00 UTC on every Monday
911
jobs:
1012
test:
1113
name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }}

test/tests.jl

+34-7
Original file line numberDiff line numberDiff line change
@@ -151,8 +151,15 @@ end
151151
DSE.format(SIGNATURES, buf, doc)
152152
str = String(take!(buf))
153153
@test occursin("\n```julia\n", str)
154-
@test occursin("\ng()\n", str)
155-
@test occursin("\ng(x)\n", str)
154+
# On 1.10+, automatically generated methods have keywords in the metadata,
155+
# hence the display difference between Julia versions.
156+
if VERSION >= v"1.10"
157+
@test occursin("\ng(; ...)\n", str)
158+
@test occursin("\ng(x; ...)\n", str)
159+
else
160+
@test occursin("\ng()\n", str)
161+
@test occursin("\ng()\n", str)
162+
end
156163
@test occursin("\n```\n", str)
157164

158165
doc.data = Dict(
@@ -163,9 +170,17 @@ end
163170
DSE.format(SIGNATURES, buf, doc)
164171
str = String(take!(buf))
165172
@test occursin("\n```julia\n", str)
166-
@test occursin("\ng()\n", str)
167-
@test occursin("\ng(x)\n", str)
168-
@test occursin("\ng(x, y)\n", str)
173+
# On 1.10+, automatically generated methods have keywords in the metadata,
174+
# hence the display difference between Julia versions.
175+
if VERSION >= v"1.10"
176+
@test occursin("\ng(; ...)\n", str)
177+
@test occursin("\ng(x; ...)\n", str)
178+
@test occursin("\ng(x, y; ...)\n", str)
179+
else
180+
@test occursin("\ng()\n", str)
181+
@test occursin("\ng(x)\n", str)
182+
@test occursin("\ng(x, y)\n", str)
183+
end
169184
@test occursin("\ng(x, y, z; kwargs...)\n", str)
170185
@test occursin("\n```\n", str)
171186

@@ -245,9 +260,21 @@ end
245260
str = String(take!(buf))
246261
@test occursin("\n```julia\n", str)
247262
if typeof(1) === Int64
248-
@test occursin("\nh(x::Int64) -> Int64\n", str)
263+
# On 1.10+, automatically generated methods have keywords in the metadata,
264+
# hence the display difference between Julia versions.
265+
if VERSION >= v"1.10"
266+
@test occursin("\nh(x::Int64; ...) -> Int64\n", str)
267+
else
268+
@test occursin("\nh(x::Int64) -> Int64\n", str)
269+
end
249270
else
250-
@test occursin("\nh(x::Int32) -> Int32\n", str)
271+
# On 1.10+, automatically generated methods have keywords in the metadata,
272+
# hence the display difference between Julia versions.
273+
if VERSION >= v"1.10"
274+
@test occursin("\nh(x::Int32; ...) -> Int32\n", str)
275+
else
276+
@test occursin("\nh(x::Int32) -> Int32\n", str)
277+
end
251278
end
252279
@test occursin("\n```\n", str)
253280

0 commit comments

Comments
 (0)