Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 9fd6d55

Browse files
oguzkaganoztpre-commit-ci[bot]knzo25YoshiRi
authoredJun 10, 2024
refactor(sensing/image_transport_decompressor): rework parameters (autowarefoundation#6746)
* add param, schema file, update readme Signed-off-by: oguzkaganozt <oguzkaganozt@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: oguzkaganozt <oguzkaganozt@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com>
1 parent f7ac46f commit 9fd6d55

5 files changed

+38
-1
lines changed
 

‎sensing/image_transport_decompressor/README.md

+2
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ The `image_transport_decompressor` is a node that decompresses images.
2222

2323
## Parameters
2424

25+
{{ json_to_markdown("sensing/image_transport_decompressor/schema/image_transport_decompressor.schema.json") }}
26+
2527
## Assumptions / Known limits
2628

2729
## (Optional) Error detection and handling
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
/**:
2+
ros__parameters:
3+
encoding: default
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
<launch>
22
<arg name="input_topic_name" default="/input/compressed_image"/>
33
<arg name="output_topic_name" default="/output/raw_image"/>
4+
<arg name="param_file" default="$(find-pkg-share image_transport_decompressor)/config/image_transport_decompressor.param.yaml"/>
45

56
<node pkg="image_transport_decompressor" exec="image_transport_decompressor_node" name="$(anon image_transport_decompressor_node)">
67
<remap from="~/input/compressed_image" to="$(var input_topic_name)"/>
78
<remap from="~/output/raw_image" to="$(var output_topic_name)"/>
9+
<param from="$(var param_file)" allow_substs="true"/>
810
</node>
911
</launch>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
{
2+
"$schema": "http://json-schema.org/draft-07/schema#",
3+
"title": "Parameters for Image Transport Decompressor",
4+
"type": "object",
5+
"definitions": {
6+
"image_transport_decompressor": {
7+
"type": "object",
8+
"properties": {
9+
"encoding": {
10+
"type": "string",
11+
"description": "The image encoding to use for the decompressed image",
12+
"default": "default"
13+
}
14+
},
15+
"required": ["encoding"]
16+
}
17+
},
18+
"properties": {
19+
"/**": {
20+
"type": "object",
21+
"properties": {
22+
"ros__parameters": {
23+
"$ref": "#/definitions/image_transport_decompressor"
24+
}
25+
},
26+
"required": ["ros__parameters"]
27+
}
28+
},
29+
"required": ["/**"]
30+
}

‎sensing/image_transport_decompressor/src/image_transport_decompressor.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ namespace image_preprocessor
6969
{
7070
ImageTransportDecompressor::ImageTransportDecompressor(const rclcpp::NodeOptions & node_options)
7171
: rclcpp::Node("image_transport_decompressor", node_options),
72-
encoding_(declare_parameter("encoding", "default"))
72+
encoding_(declare_parameter<std::string>("encoding"))
7373
{
7474
compressed_image_sub_ = create_subscription<sensor_msgs::msg::CompressedImage>(
7575
"~/input/compressed_image", rclcpp::SensorDataQoS(),

0 commit comments

Comments
 (0)