Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance MATLAB API #20

Open
3 of 4 tasks
jgroehl opened this issue Jan 18, 2022 · 2 comments
Open
3 of 4 tasks

Enhance MATLAB API #20

jgroehl opened this issue Jan 18, 2022 · 2 comments
Assignees
@jgroehl
Labels
enhancement New feature or request

Comments

@jgroehl
Copy link
Member

jgroehl commented Jan 18, 2022 •
edited
Loading

  • Refactor MATLAB code to mirror the Python code more closely
  • Write function to save a pa_data struct to HDF5
  • Test if that file is then Python readable
  • Create a convenience classes that enables the generation of the meta data similar to the python tools

This issue is a prerequisite for #14
@jgroehl jgroehl added the enhancement New feature or request label Jan 18, 2022
@jgroehl jgroehl self-assigned this Jan 18, 2022
jgroehl added a commit that referenced this issue Jan 18, 2022
@jgroehl
Refactor MATLAB API.
8b4d7fb 
Related to #20
@jgroehl
Copy link
Member Author

jgroehl commented Jan 21, 2022

File is not Python readable after MATLAB export! 🤦

@jgroehl
Copy link
Member Author

jgroehl commented Jan 25, 2022

Added a workaround in the Python load method to be able to handle MATLAB written files.
These two work in both directions now.

The resulting HDF5 files are not equal on a byte level though, even though the loaded dictionaries are equal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgroehl jgroehl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jgroehl